This is an archive of the discontinued LLVM Phabricator instance.

[docs] Explain address spaces a bit more in opaque pointers doc
ClosedPublic

Authored by aeubanks on May 14 2021, 12:14 PM.

Diff Detail

Event Timeline

aeubanks created this revision.May 14 2021, 12:14 PM
aeubanks requested review of this revision.May 14 2021, 12:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2021, 12:14 PM

This text explicitly does not talk about address spaces. For typed and opaque pointers, they still play the same role. For more information, see
DataLayout <LangRef.html#langref-datalayout>_.

The new paragraph or something similar LGTM, although probably @theraven should be the one to sign off given the post-commit feedback.

This text explicitly does not talk about address spaces. For typed and opaque pointers, they still play the same role. For more information, see
DataLayout <LangRef.html#langref-datalayout>_.

I'm not sure; I feel like @aeubanks's current text might be a little more useful, if the purpose is to head off the sorts of questions brought up in https://reviews.llvm.org/D102292. Pointers have two axes of variability/kinds and we're taking one away; I don't think everyone has clarity on what each one was for in the first place. IMO, this should serve as a "if you're worried about lowering, that's not changing, don't worry" kind of disclaimer, carving a distinction between the two axes. With your suggested more succinct text, the reader must already fully understand address spaces vs. pointer types to get that insight.

aeubanks updated this revision to Diff 346269.May 18 2021, 1:55 PM

make more explicit that opaque pointers aren't changing lowering

theraven accepted this revision.May 25 2021, 9:49 AM
This revision is now accepted and ready to land.May 25 2021, 9:49 AM