This is an archive of the discontinued LLVM Phabricator instance.

Differential D102514

[LLD][MinGW] Add --fatal-warnings and --no-fatal-warnings flags
ClosedPublic

Authored by mati865 on May 14 2021, 10:49 AM.

Details

Reviewers
mstorsjo
Commits
rG84306ef9c442: [LLD][MinGW] Add --fatal-warnings and --no-fatal-warnings flags
Summary

Couldn't find the pattern for ordering flags in Driver.cpp so put it in a random position.

Diff Detail

Unit TestsFailed

TimeTest
1,530 msx64 debian > lld.MinGW::driver.test
4,840 msx64 windows > lld.MinGW::driver.test

Event Timeline

mati865 created this revision.May 14 2021, 10:49 AM
Herald added a subscriber: dang. · View Herald TranscriptMay 14 2021, 10:49 AM
mati865 requested review of this revision.May 14 2021, 10:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2021, 10:49 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B104541: Diff 345493.May 14 2021, 11:38 AM
mstorsjo added a comment.May 14 2021, 11:59 AM

Couldn't find the pattern for ordering flags in Driver.cpp so put it in a random position.

Yeah there's probably no very clear pattern, so far it's mostly grouped according to options that have similar code for handling them.

lld/MinGW/Options.td
49

Typo, erros.

lld/test/MinGW/driver.test
298

This line doesn't seem to match the default indicated both in Options.td and the code (and the CI also seems to conclude that this fails).

mati865 updated this revision to Diff 345583.May 14 2021, 4:21 PM

Fix typo and the test

mati865 marked an inline comment as done.May 14 2021, 4:22 PM
mati865 added inline comments.
lld/test/MinGW/driver.test
298

I have no idea how that happened, I must have ran tests before saving the file.

Harbormaster completed remote builds in B104612: Diff 345583.May 14 2021, 5:16 PM
mstorsjo accepted this revision.May 17 2021, 12:47 AM

LGTM

This revision is now accepted and ready to land.May 17 2021, 12:47 AM
Closed by commit rG84306ef9c442: [LLD][MinGW] Add --fatal-warnings and --no-fatal-warnings flags (authored by mati865, committed by mstorsjo). · Explain WhyMay 17 2021, 12:47 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG84306ef9c442: [LLD][MinGW] Add --fatal-warnings and --no-fatal-warnings flags.

Revision Contents

PathSize
lld/
MinGW/
5 lines
3 lines
test/
MinGW/
9 lines

Diff 345493

lld/MinGW/Driver.cpp

Context not available.
add("-debug:dwarf"); add("-debug:dwarf");
} }
if (args.hasFlag(OPT_fatal_warnings, OPT_no_fatal_warnings, false))
add("-WX");
else
add("-WX:no");
if (args.hasArg(OPT_shared)) if (args.hasArg(OPT_shared))
add("-dll"); add("-dll");
if (args.hasArg(OPT_verbose)) if (args.hasArg(OPT_verbose))
Context not available.

lld/MinGW/Options.td

Context not available.
HelpText<"Don't automatically export any symbols">; HelpText<"Don't automatically export any symbols">;
def export_all_symbols: F<"export-all-symbols">, def export_all_symbols: F<"export-all-symbols">,
HelpText<"Export all symbols even if a def file or dllexport attributes are used">; HelpText<"Export all symbols even if a def file or dllexport attributes are used">;
defm fatal_warnings: B<"fatal-warnings",
"Treat warnings as erros",
mstorsjoUnsubmitted
Done
ReplyInline Actions

Typo, erros.

mstorsjo: Typo, `erros`.
"Do not treat warnings as errors (default)">;
defm file_alignment: Eq<"file-alignment", "Set file alignment">; defm file_alignment: Eq<"file-alignment", "Set file alignment">;
defm gc_sections: B<"gc-sections", defm gc_sections: B<"gc-sections",
"Remove unused sections", "Remove unused sections",
Context not available.

lld/test/MinGW/driver.test

Context not available.
RUN: ld.lld -### -m i386pep foo.o -no-demangle | FileCheck -check-prefix NO-DEMANGLE %s RUN: ld.lld -### -m i386pep foo.o -no-demangle | FileCheck -check-prefix NO-DEMANGLE %s
RUN: ld.lld -### -m i386pep foo.o --no-demangle | FileCheck -check-prefix NO-DEMANGLE %s RUN: ld.lld -### -m i386pep foo.o --no-demangle | FileCheck -check-prefix NO-DEMANGLE %s
NO-DEMANGLE: -demangle:no NO-DEMANGLE: -demangle:no
RUN: ld.lld -### -m i386pep foo.o | FileCheck -check-prefix FATAL_WARNINGS %s
mstorsjoUnsubmitted
Not Done
ReplyInline Actions

This line doesn't seem to match the default indicated both in Options.td and the code (and the CI also seems to conclude that this fails).

mstorsjo: This line doesn't seem to match the default indicated both in Options.td and the code (and the…
mati865AuthorUnsubmitted
Done
ReplyInline Actions

I have no idea how that happened, I must have ran tests before saving the file.

mati865: I have no idea how that happened, I must have ran tests before saving the file.
RUN: ld.lld -### -m i386pep foo.o -fatal-warnings | FileCheck -check-prefix FATAL_WARNINGS %s
RUN: ld.lld -### -m i386pep foo.o --fatal-warnings | FileCheck -check-prefix FATAL_WARNINGS %s
FATAL_WARNINGS: -WX{{ }}
RUN: ld.lld -### -m i386pep foo.o -no-fatal-warnings | FileCheck -check-prefix NO-FATAL_WARNINGS %s
RUN: ld.lld -### -m i386pep foo.o --no-fatal-warnings | FileCheck -check-prefix NO-FATAL_WARNINGS %s
NO-FATAL_WARNINGS: -WX:no
Context not available.