Page MenuHomePhabricator

[Coroutines] Mark every parameter
AbandonedPublic

Authored by lxfind on May 13 2021, 10:06 PM.

Details

Reviewers
None

Diff Detail

Unit TestsFailed

TimeTest
70 msx64 debian > Clang.CodeGenCoroutines::coro-dest-slot.cpp
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/disks/ssd0/agent/llvm-project/build/lib/clang/13.0.0/include -nostdsysteminc -triple x86_64-unknown-linux-gnu -fcoroutines-ts -std=c++14 -emit-llvm /mnt/disks/ssd0/agent/llvm-project/clang/test/CodeGenCoroutines/coro-dest-slot.cpp -o - -disable-llvm-passes | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/clang/test/CodeGenCoroutines/coro-dest-slot.cpp
80 msx64 debian > Clang.CodeGenCoroutines::coro-params.cpp
Script: -- : 'RUN: at line 5'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/disks/ssd0/agent/llvm-project/build/lib/clang/13.0.0/include -nostdsysteminc -std=c++1z -fcoroutines-ts -triple=x86_64-unknown-linux-gnu -emit-llvm -o - /mnt/disks/ssd0/agent/llvm-project/clang/test/CodeGenCoroutines/coro-params.cpp -disable-llvm-passes -fexceptions | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/clang/test/CodeGenCoroutines/coro-params.cpp
80 msx64 windows > Clang.CodeGenCoroutines::coro-dest-slot.cpp
Script: -- : 'RUN: at line 1'; c:\ws\w16c2-2\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -internal-isystem c:\ws\w16c2-2\llvm-project\premerge-checks\build\lib\clang\13.0.0\include -nostdsysteminc -triple x86_64-unknown-linux-gnu -fcoroutines-ts -std=c++14 -emit-llvm C:\ws\w16c2-2\llvm-project\premerge-checks\clang\test\CodeGenCoroutines\coro-dest-slot.cpp -o - -disable-llvm-passes | c:\ws\w16c2-2\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16c2-2\llvm-project\premerge-checks\clang\test\CodeGenCoroutines\coro-dest-slot.cpp
90 msx64 windows > Clang.CodeGenCoroutines::coro-params.cpp
Script: -- : 'RUN: at line 5'; c:\ws\w16c2-2\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -internal-isystem c:\ws\w16c2-2\llvm-project\premerge-checks\build\lib\clang\13.0.0\include -nostdsysteminc -std=c++1z -fcoroutines-ts -triple=x86_64-unknown-linux-gnu -emit-llvm -o - C:\ws\w16c2-2\llvm-project\premerge-checks\clang\test\CodeGenCoroutines\coro-params.cpp -disable-llvm-passes -fexceptions | c:\ws\w16c2-2\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16c2-2\llvm-project\premerge-checks\clang\test\CodeGenCoroutines\coro-params.cpp

Event Timeline

lxfind created this revision.May 13 2021, 10:06 PM
lxfind requested review of this revision.May 13 2021, 10:06 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 13 2021, 10:06 PM

If it would take times to mark parameter passed by value only, I think we could proceed with this one first. We can try to optimize it later. After all, correctness is most important.

lxfind abandoned this revision.Thu, Jun 10, 1:27 PM