This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][test] Make string.modifiers/clear_and_shrink_db1.pass.cpp a regular mode test
ClosedPublic

Authored by krisb on May 10 2021, 1:25 PM.

Details

Summary

Turn this test into a normal mode as it contains well-formed code and
checks for defined behavior. It still can be run in debug mode as of D100866.

Diff Detail

Event Timeline

krisb requested review of this revision.May 10 2021, 1:25 PM
krisb created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2021, 1:25 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

If buildkite is happy with this, I'm happy. (I'm mildly confused why this test wanted to redefine _LIBCPP_ASSERT in the first place.)

libcxx/test/libcxx/strings/basic.string/string.modifiers/clear_and_shrink.pass.cpp
37

Please add return 0; at the end of main here, for consistency with 2df59c50688c122bbcae7467d3eaf862c3ea3088 . (I don't know why it was missed in that commit, and I don't think it matters.)

This revision was not accepted when it landed; it landed in state Needs Review.May 11 2021, 1:16 AM
This revision was automatically updated to reflect the committed changes.
krisb marked an inline comment as done.