Page MenuHomePhabricator

[Matrix] Implement static cast for matrix types
ClosedPublic

Authored by SaurabhJha on May 9 2021, 12:19 AM.

Details

Summary

This patch implements static casts for matrix types. This patch finishes all the work needed for https://bugs.llvm.org/show_bug.cgi?id=47141

Diff Detail

Event Timeline

SaurabhJha created this revision.May 9 2021, 12:19 AM
SaurabhJha requested review of this revision.May 9 2021, 12:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2021, 12:19 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

I have commit access so I can get this into main branch after its approved.

fhahn accepted this revision.May 9 2021, 12:34 PM

LGTM from the mechanical aspect. Please wait a few days with committing, in case there are any conceptual issues with supporting matrix casts here.

This revision is now accepted and ready to land.May 9 2021, 12:34 PM

LGTM from the mechanical aspect. Please wait a few days with committing, in case there are any conceptual issues with supporting matrix casts here.

Sure, sounds good.

I am planning to commit this on Sunday.

This revision was automatically updated to reflect the committed changes.