Fix for substitutes-in-compile-flags.sh.cpp to run it properly on Windows platform.
- Group Reviewers
- rG384dd9ddaf61: [libc++] Run `substitutes-in-compile-flags.sh.cpp` test on Windows.
these changes should work on Windows, Linux and Darwin platforms, but I'm not sure about the others. In case of any problems we can disable this test for Windows with https://reviews.llvm.org/D102045.
Currently this test still gets failed on the windows to linux cross builders, as example: https://lab.llvm.org/buildbot/#/builders/119/builds/3724
Generally LGTM with a few comments. Ship it once reviewer feedback has been applied.
Can you name the file something like %t.escaped.grep instead? It makes it more obvious that the only purpose is to escape paths.
This isn't needed. We generally don't clean up the temporary files in the tests.