This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Fix argument types in SIMD narrowing intrinsics
ClosedPublic

Authored by tlively on May 6 2021, 12:35 AM.

Details

Summary

The builtins were updated to take signed parameters in 627a52695537, but the
intrinsics that use those builtins were not updated as well. The intrinsic test
did not catch this sign mismatch because it is only reported as an error under
-fno-lax-vector-conversions.

This commit fixes the type mismatch and adds -fno-lax-vector-conversions to the
test to catch similar problems in the future.

Diff Detail

Event Timeline

tlively created this revision.May 6 2021, 12:35 AM
tlively requested review of this revision.May 6 2021, 12:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2021, 12:35 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aheejin accepted this revision.May 6 2021, 12:56 AM
This revision is now accepted and ready to land.May 6 2021, 12:56 AM
This revision was landed with ongoing or failed builds.May 6 2021, 10:08 AM
This revision was automatically updated to reflect the committed changes.