This is an archive of the discontinued LLVM Phabricator instance.

Differential D101883

[WebAssembly] Update narrowing builtin function operand types
ClosedPublic

Authored by tlively on May 4 2021, 9:09 PM.

Details

Reviewers
aheejin
Commits
rG627a52695537: [WebAssembly] Update narrowing builtin function operand types
Summary

Make the inputs to all narrowing builtins signed, which is how they are
interpreted by the underlying instructions (only the result changes sign
between instructions).

Diff Detail

Event Timeline

tlively created this revision.May 4 2021, 9:09 PM
Herald added subscribers: wingo, ecnelises, sunfish and 3 others. · View Herald TranscriptMay 4 2021, 9:09 PM
tlively requested review of this revision.May 4 2021, 9:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2021, 9:09 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B102665: Diff 342937.May 4 2021, 9:44 PM
tlively updated this revision to Diff 342946.May 4 2021, 9:57 PM
  • Remove (incorrect) const pointer changes. Will fix them and put them in a separate revision.
tlively retitled this revision from [WebAssembly] Update SIMD builtin function operand types to [WebAssembly] Update narrowing builtin function operand types.May 4 2021, 9:59 PM
tlively edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B102668: Diff 342946.May 4 2021, 10:31 PM
aheejin accepted this revision.May 5 2021, 1:21 AM
This revision is now accepted and ready to land.May 5 2021, 1:21 AM
Closed by commit rG627a52695537: [WebAssembly] Update narrowing builtin function operand types (authored by tlively). · Explain WhyMay 5 2021, 1:04 PM
This revision was automatically updated to reflect the committed changes.
tlively added a commit: rG627a52695537: [WebAssembly] Update narrowing builtin function operand types.

Revision Contents

PathSize
clang/
include/
clang/
Basic/
4 lines
test/
CodeGen/
4 lines

Diff 343154

clang/include/clang/Basic/BuiltinsWebAssembly.def

Show First 20 Lines • Show All 179 Lines • ▼ Show 20 Lines
TARGET_BUILTIN(__builtin_wasm_sqrt_f32x4, "V4fV4f", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_sqrt_f32x4, "V4fV4f", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_sqrt_f64x2, "V2dV2d", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_sqrt_f64x2, "V2dV2d", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_trunc_saturate_s_i32x4_f32x4, "V4iV4f", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_trunc_saturate_s_i32x4_f32x4, "V4iV4f", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_trunc_saturate_u_i32x4_f32x4, "V4iV4f", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_trunc_saturate_u_i32x4_f32x4, "V4iV4f", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_narrow_s_i8x16_i16x8, "V16ScV8sV8s", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_narrow_s_i8x16_i16x8, "V16ScV8sV8s", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_narrow_u_i8x16_i16x8, "V16UcV8UsV8Us", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_narrow_u_i8x16_i16x8, "V16UcV8sV8s", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_narrow_s_i16x8_i32x4, "V8sV4iV4i", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_narrow_s_i16x8_i32x4, "V8sV4iV4i", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_narrow_u_i16x8_i32x4, "V8UsV4UiV4Ui", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_narrow_u_i16x8_i32x4, "V8UsV4iV4i", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_s_f64x2_i32x4, "V4iV2d", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_s_f64x2_i32x4, "V4iV2d", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_u_f64x2_i32x4, "V4UiV2d", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_u_f64x2_i32x4, "V4UiV2d", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_demote_zero_f64x2_f32x4, "V4fV2d", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_demote_zero_f64x2_f32x4, "V4fV2d", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_promote_low_f32x4_f64x2, "V2dV4f", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_promote_low_f32x4_f64x2, "V2dV4f", "nc", "simd128")
TARGET_BUILTIN(__builtin_wasm_load32_zero, "V4ii*", "n", "simd128") TARGET_BUILTIN(__builtin_wasm_load32_zero, "V4ii*", "n", "simd128")
TARGET_BUILTIN(__builtin_wasm_load64_zero, "V2LLiLLi*", "n", "simd128") TARGET_BUILTIN(__builtin_wasm_load64_zero, "V2LLiLLi*", "n", "simd128")
Show All 12 Lines

clang/test/CodeGen/builtins-wasm.c

Show First 20 Lines • Show All 851 Lines • ▼ Show 20 Lines
i8x16 narrow_s_i8x16_i16x8(i16x8 low, i16x8 high) { i8x16 narrow_s_i8x16_i16x8(i16x8 low, i16x8 high) {
return __builtin_wasm_narrow_s_i8x16_i16x8(low, high); return __builtin_wasm_narrow_s_i8x16_i16x8(low, high);
// WEBASSEMBLY: call <16 x i8> @llvm.wasm.narrow.signed.v16i8.v8i16( // WEBASSEMBLY: call <16 x i8> @llvm.wasm.narrow.signed.v16i8.v8i16(
// WEBASSEMBLY-SAME: <8 x i16> %low, <8 x i16> %high) // WEBASSEMBLY-SAME: <8 x i16> %low, <8 x i16> %high)
// WEBASSEMBLY: ret // WEBASSEMBLY: ret
} }
u8x16 narrow_u_i8x16_i16x8(u16x8 low, u16x8 high) { u8x16 narrow_u_i8x16_i16x8(i16x8 low, i16x8 high) {
return __builtin_wasm_narrow_u_i8x16_i16x8(low, high); return __builtin_wasm_narrow_u_i8x16_i16x8(low, high);
// WEBASSEMBLY: call <16 x i8> @llvm.wasm.narrow.unsigned.v16i8.v8i16( // WEBASSEMBLY: call <16 x i8> @llvm.wasm.narrow.unsigned.v16i8.v8i16(
// WEBASSEMBLY-SAME: <8 x i16> %low, <8 x i16> %high) // WEBASSEMBLY-SAME: <8 x i16> %low, <8 x i16> %high)
// WEBASSEMBLY: ret // WEBASSEMBLY: ret
} }
i16x8 narrow_s_i16x8_i32x4(i32x4 low, i32x4 high) { i16x8 narrow_s_i16x8_i32x4(i32x4 low, i32x4 high) {
return __builtin_wasm_narrow_s_i16x8_i32x4(low, high); return __builtin_wasm_narrow_s_i16x8_i32x4(low, high);
// WEBASSEMBLY: call <8 x i16> @llvm.wasm.narrow.signed.v8i16.v4i32( // WEBASSEMBLY: call <8 x i16> @llvm.wasm.narrow.signed.v8i16.v4i32(
// WEBASSEMBLY-SAME: <4 x i32> %low, <4 x i32> %high) // WEBASSEMBLY-SAME: <4 x i32> %low, <4 x i32> %high)
// WEBASSEMBLY: ret // WEBASSEMBLY: ret
} }
u16x8 narrow_u_i16x8_i32x4(u32x4 low, u32x4 high) { u16x8 narrow_u_i16x8_i32x4(i32x4 low, i32x4 high) {
return __builtin_wasm_narrow_u_i16x8_i32x4(low, high); return __builtin_wasm_narrow_u_i16x8_i32x4(low, high);
// WEBASSEMBLY: call <8 x i16> @llvm.wasm.narrow.unsigned.v8i16.v4i32( // WEBASSEMBLY: call <8 x i16> @llvm.wasm.narrow.unsigned.v8i16.v4i32(
// WEBASSEMBLY-SAME: <4 x i32> %low, <4 x i32> %high) // WEBASSEMBLY-SAME: <4 x i32> %low, <4 x i32> %high)
// WEBASSEMBLY: ret // WEBASSEMBLY: ret
} }
i32x4 trunc_sat_zero_s_f64x2_i32x4(f64x2 x) { i32x4 trunc_sat_zero_s_f64x2_i32x4(f64x2 x) {
return __builtin_wasm_trunc_sat_zero_s_f64x2_i32x4(x); return __builtin_wasm_trunc_sat_zero_s_f64x2_i32x4(x);
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines