This is an archive of the discontinued LLVM Phabricator instance.

Differential D101706

[NFC] Use getParamByValType instead of pointee type
ClosedPublic

Authored by aeubanks on May 1 2021, 9:02 PM.

Details

Reviewers
dblaikie
Commits
rG07a9df599367: [NFC] Use getParamByValType instead of pointee type
Summary

To reduce dependence on pointee types for opaque pointers.

Diff Detail

Event Timeline

aeubanks created this revision.May 1 2021, 9:02 PM
Herald added subscribers: haicheng, hiraditya, eraman. · View Herald TranscriptMay 1 2021, 9:02 PM
aeubanks requested review of this revision.May 1 2021, 9:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2021, 9:02 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks added a reviewer: dblaikie.May 1 2021, 9:02 PM
dblaikie accepted this revision.May 1 2021, 9:08 PM

Looks good - thanks!

This revision is now accepted and ready to land.May 1 2021, 9:08 PM
This revision was landed with ongoing or failed builds.May 1 2021, 9:23 PM
Closed by commit rG07a9df599367: [NFC] Use getParamByValType instead of pointee type (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG07a9df599367: [NFC] Use getParamByValType instead of pointee type.
Harbormaster completed remote builds in B102141: Diff 342200.May 1 2021, 9:55 PM

Revision Contents

PathSize
llvm/
lib/
Analysis/
2 lines

Diff 342200

llvm/lib/Analysis/InlineCost.cpp

Show First 20 Lines • Show All 2,438 Lines • ▼ Show 20 Lines
int llvm::getCallsiteCost(CallBase &Call, const DataLayout &DL) { int llvm::getCallsiteCost(CallBase &Call, const DataLayout &DL) {
int Cost = 0; int Cost = 0;
for (unsigned I = 0, E = Call.arg_size(); I != E; ++I) { for (unsigned I = 0, E = Call.arg_size(); I != E; ++I) {
if (Call.isByValArgument(I)) { if (Call.isByValArgument(I)) {
// We approximate the number of loads and stores needed by dividing the // We approximate the number of loads and stores needed by dividing the
// size of the byval type by the target's pointer size. // size of the byval type by the target's pointer size.
PointerType *PTy = cast<PointerType>(Call.getArgOperand(I)->getType()); PointerType *PTy = cast<PointerType>(Call.getArgOperand(I)->getType());
unsigned TypeSize = DL.getTypeSizeInBits(PTy->getElementType()); unsigned TypeSize = DL.getTypeSizeInBits(Call.getParamByValType(I));
unsigned AS = PTy->getAddressSpace(); unsigned AS = PTy->getAddressSpace();
unsigned PointerSize = DL.getPointerSizeInBits(AS); unsigned PointerSize = DL.getPointerSizeInBits(AS);
// Ceiling division. // Ceiling division.
unsigned NumStores = (TypeSize + PointerSize - 1) / PointerSize; unsigned NumStores = (TypeSize + PointerSize - 1) / PointerSize;
// If it generates more than 8 stores it is likely to be expanded as an // If it generates more than 8 stores it is likely to be expanded as an
// inline memcpy so we take that as an upper bound. Otherwise we assume // inline memcpy so we take that as an upper bound. Otherwise we assume
// one load and one store per word copied. // one load and one store per word copied.
▲ Show 20 Lines • Show All 351 Lines • Show Last 20 Lines