This is an archive of the discontinued LLVM Phabricator instance.

hurd: Fix i386 research path
ClosedPublic

Authored by sthibaul on Apr 26 2021, 11:43 AM.

Details

Summary

f26341840253 ("[Driver] Gnu.cpp: remove obsoleted i386 triple detection
from end-of-life distribution versions") dropped the i686-gnu gcc path, but
GNU/Hurd's gcc is actually using it, and not i386.

This fixes the gcc path and update the tests to reflect it.

Diff Detail

Event Timeline

sthibaul requested review of this revision.Apr 26 2021, 11:43 AM
sthibaul created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2021, 11:43 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sthibaul updated this revision to Diff 340749.Apr 27 2021, 1:11 AM

Retrigger buildable

sthibaul updated this revision to Diff 340751.Apr 27 2021, 1:12 AM

Retrigger buildable

@MaskRay could you review this one as well? Most others are based on it.

MaskRay accepted this revision.Apr 27 2021, 9:00 AM

i386-gnu no longer exists? That's great.

clang/test/Driver/hurd.c
2

While we currently detects several aliases, it'd be good that clang driver doesn't need to do so.

i686-gnu may be preferred (matching the lib/gcc/$triple name).

This revision is now accepted and ready to land.Apr 27 2021, 9:00 AM
sthibaul updated this revision to Diff 340875.Apr 27 2021, 9:22 AM
sthibaul marked an inline comment as done.

Fix triplet

clang/test/Driver/hurd.c
2

Ok, updated so.

This revision was automatically updated to reflect the committed changes.