This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [test] Add tests for coredumps with multiple threads
ClosedPublic

Authored by mgorny on Apr 23 2021, 5:24 AM.

Diff Detail

Event Timeline

mgorny created this revision.Apr 23 2021, 5:24 AM
mgorny requested review of this revision.Apr 23 2021, 5:24 AM
mgorny updated this revision to Diff 340003.Apr 23 2021, 6:41 AM

Check for thread select instructions rather than output.

lldb/test/Shell/Register/Core/x86-64-linux-multithread.test
21

Fun fact: it seems that register read outputs immediately while thread select can output after register read output. Weird.

mgorny updated this revision to Diff 340030.Apr 23 2021, 7:40 AM

Now with complete set of amd64 tests.

mgorny updated this revision to Diff 340035.Apr 23 2021, 8:01 AM
mgorny edited the summary of this revision. (Show Details)

Complete set of tests.

mgorny retitled this revision from [lldb] [test] Add tests for core dumps of multithreaded programs [WIP] to [lldb] [test] Add tests for coredumps with multiple threads.Apr 23 2021, 8:01 AM
mgorny updated this revision to Diff 340586.Apr 26 2021, 10:57 AM

Add FreeBSD/aarch64 test.

@labath, could you give me at least a rough idea how you feel about this one? I'd like to know if I need to change the test code before I start adding coredumps for more architectures.

krytarowski accepted this revision.Sep 8 2021, 12:49 AM
This revision is now accepted and ready to land.Sep 8 2021, 12:49 AM
This revision was landed with ongoing or failed builds.Sep 9 2021, 1:47 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2021, 1:47 AM