This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] Correct some comments in the TableGen parser [NFC]
ClosedPublic

Authored by Paul-C-Anagnostopoulos on Apr 22 2021, 10:29 AM.

Details

Summary

This revision corrects a few comments in the TableGen parser. These are primarily comments about statement syntax.

I think it's okay to accept this revision myself in a day or two?

Diff Detail

Event Timeline

Paul-C-Anagnostopoulos requested review of this revision.Apr 22 2021, 10:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2021, 10:29 AM
dblaikie accepted this revision.Apr 22 2021, 11:09 AM

I think it's okay to accept this revision myself in a day or two?

Generally this isn't an acceptable practice - the idea is that if it was worth sending for review, it should be reviewed before being submitted. (otherwise things might get a bit slippery - "I sent it for review but no one's replied, so I'm just going to commit it now")

There is sometimes narrow space for "I'm curious about feedback, but happy to commit this if no one has any" - but a change like this should be easy enough to get someone to say "I don't see anything wrong with this" when you ask.

But, yeah, something like this I think it'd be fine for you to commit without sending it for review in the first place.

This revision is now accepted and ready to land.Apr 22 2021, 11:09 AM

Ah, so a trivial change like this doesn't need review. Thanks!