Page MenuHomePhabricator

[libc++][doc] Adds a Format library status page.
ClosedPublic

Authored by Mordante on Thu, Apr 22, 10:20 AM.

Details

Summary

A status page for libc++'s Format library. The page is inspired by
@zoecarver's Ranges status page.

Diff Detail

Event Timeline

Mordante created this revision.Thu, Apr 22, 10:20 AM
Mordante requested review of this revision.Thu, Apr 22, 10:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Apr 22, 10:20 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
zoecarver accepted this revision as: zoecarver.Thu, Apr 22, 10:27 AM

Love this. Thanks for working on it. I say ship it!

libcxx/docs/FormatProposalStatus.csv
3

Nit: we say "In Progress" in the other status documents, so might make sense to say that instead of WIP here. That being said, people will get the idea, so I don't think it matters too much. You could fix this locally, leave it, or fix it later.

Quuxplusone accepted this revision.Thu, Apr 22, 10:55 AM
Quuxplusone added subscribers: vitaut, Quuxplusone.

"Ship it!" SGTM. Feel free to hold off if you're looking for review specifically from Louis (or @vitaut) or something.

libcxx/docs/FormatIssuePaperStatus.csv
9

/:;/::/
Also grep for two-spaces-in-a-row.

libcxx/docs/FormatProposalStatus.csv
3

It'd also be nice to put " quotes around all the paper titles, not just the ones with embedded commas. Will reduce cut-and-paste errors in the future.

libcxx/docs/FormatStatus.rst
40–41

FWIW, I don't understand what qualifies as a "required update" in this context. Is that like a Windows security patch? ;)
I suspect this sentence just means "Please mark all Format-related TODO comments with the string TODO FMT, so we can find them easily."

This revision is now accepted and ready to land.Thu, Apr 22, 10:55 AM
Mordante marked 4 inline comments as done.Sat, Apr 24, 7:32 AM

Thanks for the reviews! I'll make the changes before landing the patch.

libcxx/docs/FormatStatus.rst
40–41

That wording is a copy-paste. I like your suggestion.

This revision was landed with ongoing or failed builds.Sat, Apr 24, 7:38 AM
This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.