A status page for libc++'s Format library. The page is inspired by
@zoecarver's Ranges status page.
Details
- Reviewers
zoecarver • Quuxplusone - Group Reviewers
Restricted Project - Commits
- rGca177dcda301: [libc++][doc] Adds a Format library status page.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Love this. Thanks for working on it. I say ship it!
libcxx/docs/FormatProposalStatus.csv | ||
---|---|---|
3 | Nit: we say "In Progress" in the other status documents, so might make sense to say that instead of WIP here. That being said, people will get the idea, so I don't think it matters too much. You could fix this locally, leave it, or fix it later. |
"Ship it!" SGTM. Feel free to hold off if you're looking for review specifically from Louis (or @vitaut) or something.
libcxx/docs/FormatIssuePaperStatus.csv | ||
---|---|---|
9 | /:;/::/ | |
libcxx/docs/FormatProposalStatus.csv | ||
3 | It'd also be nice to put " quotes around all the paper titles, not just the ones with embedded commas. Will reduce cut-and-paste errors in the future. | |
libcxx/docs/FormatStatus.rst | ||
40–41 | FWIW, I don't understand what qualifies as a "required update" in this context. Is that like a Windows security patch? ;) |
Thanks for the reviews! I'll make the changes before landing the patch.
libcxx/docs/FormatStatus.rst | ||
---|---|---|
40–41 | That wording is a copy-paste. I like your suggestion. |
/:;/::/
Also grep for two-spaces-in-a-row.