This is an archive of the discontinued LLVM Phabricator instance.

Differential D101006

[llvm-profgen] Couple tweaks to the testing harness.
ClosedPublic

Authored by hoy on Apr 21 2021, 6:02 PM.

Details

Reviewers
wenlei
thakis
wlei
Commits
rGaaf120b5282d: [llvm-profgen] A couple tweaks to the testing harness.
Summary
  1. Remove unnecessary filtering code.
  2. Add llvm-profgen to tool substitutions.

Diff Detail

Event Timeline

hoy created this revision.Apr 21 2021, 6:02 PM
Herald added a subscriber: wenlei. · View Herald TranscriptApr 21 2021, 6:02 PM
hoy requested review of this revision.Apr 21 2021, 6:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2021, 6:02 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
wenlei accepted this revision.Apr 21 2021, 6:04 PM

lgtm, thanks.

This revision is now accepted and ready to land.Apr 21 2021, 6:04 PM
hoy added reviewers: thakis, wlei.Apr 21 2021, 6:04 PM
Harbormaster completed remote builds in B100127: Diff 339432.Apr 21 2021, 6:34 PM
This revision was landed with ongoing or failed builds.Apr 22 2021, 8:57 AM
Closed by commit rGaaf120b5282d: [llvm-profgen] A couple tweaks to the testing harness. (authored by hoy). · Explain Why
This revision was automatically updated to reflect the committed changes.
hoy added a commit: rGaaf120b5282d: [llvm-profgen] A couple tweaks to the testing harness..

Revision Contents

PathSize
llvm/
test/
2 lines
tools/
llvm-profgen/
2 lines

Diff 339666

llvm/test/lit.cfg.py

Show First 20 Lines • Show All 155 Lines • ▼ Show 20 Linestools.extend([
'dsymutil', 'lli', 'lli-child-target', 'llvm-ar', 'llvm-as', 'dsymutil', 'lli', 'lli-child-target', 'llvm-ar', 'llvm-as',
'llvm-addr2line', 'llvm-bcanalyzer', 'llvm-bitcode-strip', 'llvm-config', 'llvm-addr2line', 'llvm-bcanalyzer', 'llvm-bitcode-strip', 'llvm-config',
'llvm-cov', 'llvm-cxxdump', 'llvm-cvtres', 'llvm-diff', 'llvm-dis', 'llvm-cov', 'llvm-cxxdump', 'llvm-cvtres', 'llvm-diff', 'llvm-dis',
'llvm-dwarfdump', 'llvm-dlltool', 'llvm-exegesis', 'llvm-extract', 'llvm-dwarfdump', 'llvm-dlltool', 'llvm-exegesis', 'llvm-extract',
'llvm-isel-fuzzer', 'llvm-ifs', 'llvm-isel-fuzzer', 'llvm-ifs',
'llvm-install-name-tool', 'llvm-jitlink', 'llvm-opt-fuzzer', 'llvm-lib', 'llvm-install-name-tool', 'llvm-jitlink', 'llvm-opt-fuzzer', 'llvm-lib',
'llvm-link', 'llvm-lto', 'llvm-lto2', 'llvm-mc', 'llvm-mca', 'llvm-link', 'llvm-lto', 'llvm-lto2', 'llvm-mc', 'llvm-mca',
'llvm-modextract', 'llvm-nm', 'llvm-objcopy', 'llvm-objdump', 'llvm-otool', 'llvm-modextract', 'llvm-nm', 'llvm-objcopy', 'llvm-objdump', 'llvm-otool',
'llvm-pdbutil', 'llvm-profdata', 'llvm-ranlib', 'llvm-rc', 'llvm-readelf', 'llvm-pdbutil', 'llvm-profdata', 'llvm-profgen', 'llvm-ranlib', 'llvm-rc', 'llvm-readelf',
'llvm-readobj', 'llvm-rtdyld', 'llvm-size', 'llvm-split', 'llvm-strings', 'llvm-readobj', 'llvm-rtdyld', 'llvm-size', 'llvm-split', 'llvm-strings',
'llvm-strip', 'llvm-tblgen', 'llvm-undname', 'llvm-c-test', 'llvm-cxxfilt', 'llvm-strip', 'llvm-tblgen', 'llvm-undname', 'llvm-c-test', 'llvm-cxxfilt',
'llvm-xray', 'yaml2obj', 'obj2yaml', 'yaml-bench', 'verify-uselistorder', 'llvm-xray', 'yaml2obj', 'obj2yaml', 'yaml-bench', 'verify-uselistorder',
'bugpoint', 'llc', 'llvm-symbolizer', 'opt', 'sancov', 'sanstats']) 'bugpoint', 'llc', 'llvm-symbolizer', 'opt', 'sancov', 'sanstats'])
# The following tools are optional # The following tools are optional
tools.extend([ tools.extend([
ToolSubst('llvm-go', unresolved='ignore'), ToolSubst('llvm-go', unresolved='ignore'),
▲ Show 20 Lines • Show All 208 Lines • Show Last 20 Lines

llvm/test/tools/llvm-profgen/lit.local.cfg

import subprocess import subprocess
import lit.util import lit.util
config.suffixes = ['.test', '.ll', '.s', '.yaml'] config.suffixes = ['.test', '.ll', '.s', '.yaml']
if not lit.util.which("llvm-profgen", config.llvm_tools_dir):
config.unsupported = True
if not 'X86' in config.root.targets: if not 'X86' in config.root.targets:
config.unsupported = True config.unsupported = True