This is an archive of the discontinued LLVM Phabricator instance.

Differential D100968

Update shebang for clang-format-diff script to python3.
ClosedPublic

Authored by PaulkaToast on Apr 21 2021, 9:41 AM.

Details

Reviewers
MaskRay
DavidSpickett
Commits
rG71e80386d0fe: Update shebang for clang-format-diff script to python3.
Summary

Different distributions have different strategies migrating the python symlink. Debian and its derivatives provide python-is-python2 and python-is-python3. If neither is installed, the user gets no /usr/bin/python. The clang-format-diff script and consequently arc diff can thus fail with a python not found error. Since we require python greater than 3.6 as part of llvm prerequisites (https://llvm.org/docs/GettingStarted.html#software), let's go ahead and update this shebang.

Diff Detail

Event Timeline

PaulkaToast requested review of this revision.Apr 21 2021, 9:41 AM
PaulkaToast created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2021, 9:41 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay accepted this revision.Apr 21 2021, 9:44 AM

On newer Linux distributions

Different distributions have different strategies migrating the /usr/bin/python symlink. Debian and its derivatives provide python-is-python2 and python-is-python3. If neither is installed, the user gets no /usr/bin/python.

LG with this clarified.

This revision is now accepted and ready to land.Apr 21 2021, 9:44 AM
PaulkaToast edited the summary of this revision. (Show Details)Apr 21 2021, 9:49 AM
In D100968#2705598, @MaskRay wrote:

On newer Linux distributions

Different distributions have different strategies migrating the /usr/bin/python symlink. Debian and its derivatives provide python-is-python2 and python-is-python3. If neither is installed, the user gets no /usr/bin/python.

LG with this clarified.

Thank you, added to the change description for more context. (:

Harbormaster completed remote builds in B100012: Diff 339271.Apr 21 2021, 10:00 AM
MaskRay added a comment.Apr 21 2021, 2:35 PM

Still LG:)

This revision was landed with ongoing or failed builds.Apr 22 2021, 6:48 AM
Closed by commit rG71e80386d0fe: Update shebang for clang-format-diff script to python3. (authored by PaulkaToast). · Explain Why
This revision was automatically updated to reflect the committed changes.
PaulkaToast added a commit: rG71e80386d0fe: Update shebang for clang-format-diff script to python3..

Revision Contents

PathSize
clang/
tools/
clang-format/
2 lines

Diff 339609

clang/tools/clang-format/clang-format-diff.py

#!/usr/bin/env python #!/usr/bin/env python3
# #
#===- clang-format-diff.py - ClangFormat Diff Reformatter ----*- python -*--===# #===- clang-format-diff.py - ClangFormat Diff Reformatter ----*- python -*--===#
# #
# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information. # See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
# #
#===------------------------------------------------------------------------===# #===------------------------------------------------------------------------===#
▲ Show 20 Lines • Show All 126 Lines • Show Last 20 Lines