Page MenuHomePhabricator

[lsan] Test to show lsan dependency on globals
ClosedPublic

Authored by vitalybuka on Apr 20 2021, 4:12 PM.

Details

Summary

This test from @MaskRay comment on D69428. The patch is looking to
break this behavior. If we go with D69428 I hope we will have some
workaround for this test or include explicit test update into the patch.

Diff Detail

Event Timeline

vitalybuka requested review of this revision.Apr 20 2021, 4:12 PM
vitalybuka created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2021, 4:12 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka edited the summary of this revision. (Show Details)Apr 20 2021, 4:14 PM
vitalybuka retitled this revision from [lsan] Test reflect lsan deppendency on globals to [lsan] Test to show lsan dependency on global.
vitalybuka retitled this revision from [lsan] Test to show lsan dependency on global to [lsan] Test to show lsan dependency on globals.
MaskRay accepted this revision.Apr 20 2021, 4:39 PM

Looks great!

compiler-rt/test/lsan/TestCases/use_globals_unused.cpp
5

If report_objects=1 is used, the file should check more patterns; otherwise report_objects=1 is unneeded.

7

--implicit-check-not=leak

Double quotes may give a false implication that they are significant.

26

internalization -> localization

GlobalOpt makes the global variable essentially a local variable.

This revision is now accepted and ready to land.Apr 20 2021, 4:39 PM
vitalybuka marked 3 inline comments as done.

update

This revision was landed with ongoing or failed builds.Apr 20 2021, 10:00 PM
This revision was automatically updated to reflect the committed changes.