This is an archive of the discontinued LLVM Phabricator instance.

[CMake][llvm] Using -D in COMPILE_DEFINITIONS can create a lone -D w/generator-expressions
AcceptedPublic

Authored by radford on Apr 20 2021, 3:15 PM.

Download Raw Diff

Details

Reviewers

arphaman
sepavloff
JDevlieghere

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	150 ms	x64 debian > LLVM.Bindings/Go::go.test
	11,600 ms	x64 debian > MLIR.Examples/standalone::test.toy
	31,020 ms	x64 windows > Clang.Driver::darwin-ld.c

Event Timeline

radford created this revision.Apr 20 2021, 3:15 PM

Herald added a subscriber: mgorny. · View Herald TranscriptApr 20 2021, 3:15 PM

radford requested review of this revision.Apr 20 2021, 3:15 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2021, 3:15 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B99816: Diff 339008.Apr 20 2021, 3:57 PM

LGTM

This revision is now accepted and ready to land.Apr 22 2021, 6:42 PM

Revision Contents

Path

Size

llvm/

cmake/

modules/

HandleLLVMOptions.cmake

9 lines

Diff 339008

llvm/cmake/modules/HandleLLVMOptions.cmake

Show First 20 Lines • Show All 1,111 Lines • ▼ Show 20 Lines	option(LLVM_ENABLE_IDE
"Disable optional build system features that cause problems for IDE generators"		"Disable optional build system features that cause problems for IDE generators"
${LLVM_ENABLE_IDE_default})		${LLVM_ENABLE_IDE_default})
if (CMAKE_CONFIGURATION_TYPES AND NOT LLVM_ENABLE_IDE)		if (CMAKE_CONFIGURATION_TYPES AND NOT LLVM_ENABLE_IDE)
message(WARNING "Disabling LLVM_ENABLE_IDE on multi-configuration generators is not recommended.")		message(WARNING "Disabling LLVM_ENABLE_IDE on multi-configuration generators is not recommended.")
endif()		endif()

function(get_compile_definitions)		function(get_compile_definitions)
get_directory_property(top_dir_definitions DIRECTORY ${CMAKE_SOURCE_DIR} COMPILE_DEFINITIONS)		get_directory_property(top_dir_definitions DIRECTORY ${CMAKE_SOURCE_DIR} COMPILE_DEFINITIONS)
foreach(definition ${top_dir_definitions})		set(LLVM_DEFINITIONS "${top_dir_definitions}" PARENT_SCOPE)
if(DEFINED result)
string(APPEND result " -D${definition}")
else()
set(result "-D${definition}")
endif()
endforeach()
set(LLVM_DEFINITIONS "${result}" PARENT_SCOPE)
endfunction()		endfunction()
get_compile_definitions()		get_compile_definitions()

option(LLVM_FORCE_ENABLE_STATS "Enable statistics collection for builds that wouldn't normally enable it" OFF)		option(LLVM_FORCE_ENABLE_STATS "Enable statistics collection for builds that wouldn't normally enable it" OFF)

check_symbol_exists(os_signpost_interval_begin "os/signpost.h" macos_signposts_available)		check_symbol_exists(os_signpost_interval_begin "os/signpost.h" macos_signposts_available)
if(macos_signposts_available)		if(macos_signposts_available)
check_cxx_source_compiles(		check_cxx_source_compiles(
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines