Page MenuHomePhabricator

AMDGPU: Fix indirect tail calls
ClosedPublic

Authored by arsenm on Apr 20 2021, 11:49 AM.

Details

Summary

Fix a selection error on uniform callees, and use a regular call if
divergent.

Diff Detail

Event Timeline

arsenm created this revision.Apr 20 2021, 11:49 AM
arsenm requested review of this revision.Apr 20 2021, 11:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2021, 11:49 AM
Herald added a subscriber: wdng. · View Herald Transcript
This revision is now accepted and ready to land.Apr 20 2021, 12:38 PM
madhur13490 added inline comments.Apr 21 2021, 7:42 AM
llvm/test/CodeGen/AMDGPU/sibling-call.ll
282

Sorry for late comments. Nit - %c is unused. Do you need attribute on the signature?

301

Just wondering, why is this a divergent call? Because the pointer is incoming as a parameter?

arsenm added inline comments.Apr 21 2021, 8:02 AM
llvm/test/CodeGen/AMDGPU/sibling-call.ll
282

The attribute adds noinline in case we were ever using the force inline mode for some reason

301

Yes