[libcxx] [test] Convert a couple of LIBCXX-WINDOWS-FIXME into XFAIL: windows-dll for known bugs

[mstorsjo]

Summary

These are caused due to inconsistencies regarding always inline in
combination with dllimport. A bug report reference is added next to
each XFAIL line.

This depends on D100221 for adding the 'windows-dll' feature to check
for.

[curdeius]

LGTM. IIUC these tests will unexpectedly pass when this bug is fixed in clang, right? And then, we would be able to remove XFAIL annotations. If it's so, then it's good.

libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp

11–12

[mstorsjo]

In D100789#2700970, @curdeius wrote:

LGTM. IIUC these tests will unexpectedly pass when this bug is fixed in clang, right? And then, we would be able to remove XFAIL annotations. If it's so, then it's good.

Yep, that's correct.

libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp

11–12

Thanks, will apply that change.

[mstorsjo]

Updated urls to use the short https://llvm.org/PR41018 form.

[Mordante]

LGTM!

libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // REQUIRES: locale.en_US.UTF-8
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// https://llvm.org/PR41018
+// XFAIL: windows-dll
 
 // <locale>
 
 // template <class charT> class collate_byname
 
 // long hash(const charT* low, const charT* high) const;
 
 //   This test is not portable

libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
+// https://llvm.org/PR41018
+// XFAIL: windows-dll
+
 // <locale>
 
 // template <class charT> class collate;
 
 // int compare(const charT* low1, const charT* high1,
 //             const charT* low2, const charT* high2) const;
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <locale>
 #include <cassert>
 
 #include "test_macros.h"
 
 int main(int, char**)
 {
     std::locale l = std::locale::classic();

libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
+// https://llvm.org/PR41018
+// XFAIL: windows-dll
+
 // <locale>
 
 // template <class charT> class collate;
 
 // long hash(const charT* low, const charT* high) const;
 
 //   This test is not portable
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <locale>
 #include <string>
 #include <cassert>
 
 #include "test_macros.h"
 
 int main(int, char**)
 {

libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// https://llvm.org/PR41018
+// XFAIL: windows-dll
 
 // <locale>
 
 // template <class charT, class Traits, class Allocator>
 //   bool operator()(const basic_string<charT,Traits,Allocator>& s1,
 //                   const basic_string<charT,Traits,Allocator>& s2) const;
 
 #include <locale>