Page MenuHomePhabricator

Use SmallVector instead of std::vector to manage storage of llvm::BitVector
ClosedPublic

Authored by serge-sans-paille on Mon, Apr 19, 1:46 AM.

Details

Summary

This is a follow-up to https://reviews.llvm.org/D100387.
std::vector is not the best storage container here. My local benchmark (counting the number of instruction when compiling the sqlite3 amalgametion) yields the following:

  • std::vector<BitVector> -> 5,860,885,896
  • SmallVector<BitWord, 0> -> 5,858,991,997
  • `SmallVector<BitWord> -> 5,817,679,224

Diff Detail

Event Timeline

serge-sans-paille requested review of this revision.Mon, Apr 19, 1:46 AM
serge-sans-paille created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Apr 19, 1:46 AM
thakis accepted this revision.Tue, Apr 20, 8:38 AM

Thanks!

This revision is now accepted and ready to land.Tue, Apr 20, 8:38 AM