This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][doc] Use Phabricator links.
ClosedPublic

Authored by Mordante on Apr 17 2021, 9:16 AM.

Details

Reviewers
zoecarver
cjdb
Group Reviewers
Restricted Project
Commits
rG0c8fab9af7f9: [libcxx][doc] Use Phabricator links.
Summary

Use a link to the Phabricator review in the patch column.

Diff Detail

Event Timeline

Mordante requested review of this revision.Apr 17 2021, 9:16 AM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2021, 9:16 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
cjdb accepted this revision.Apr 17 2021, 12:13 PM

Should the commit message have NFC in it somewhere or does [doc] imply this?

IMO [doc] already implies [nfc].

zoecarver accepted this revision.Apr 19 2021, 9:45 AM

Thanks for doing this @Mordante. Sorry I didn't review more quickly.

(I assume you approve this yourself, so I'll give the libc++ approval as well.)

This revision is now accepted and ready to land.Apr 19 2021, 9:45 AM

Thanks for doing this @Mordante. Sorry I didn't review more quickly.

Thanks for the review. No problem, I can guess how much review e-mails you get ;-)

This revision was automatically updated to reflect the committed changes.

Just FYI, it's also possible to use just https://llvm.org/DXXXXX.

Just FYI, it's also possible to use just https://llvm.org/DXXXXX.

Thanks for the hint. I adjusted the links.