Page MenuHomePhabricator

[CUDA, FDO] Filter out profiling options from GPU-side compilations.
ClosedPublic

Authored by tra on Thu, Apr 15, 1:54 PM.

Diff Detail

Event Timeline

tra created this revision.Thu, Apr 15, 1:54 PM
tra requested review of this revision.Thu, Apr 15, 1:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Apr 15, 1:54 PM
tra added inline comments.Thu, Apr 15, 1:56 PM
clang/lib/Driver/ToolChains/Clang.cpp
5828–5848

@yaxunl Should I add isHipDevice here too? I don't think host-side profiling info is of much use for GPU compilation.

yaxunl added inline comments.Thu, Apr 15, 2:07 PM
clang/lib/Driver/ToolChains/Clang.cpp
5828–5848

Yes pls do the same for HIP. Thanks.

tra updated this revision to Diff 337896.Thu, Apr 15, 2:12 PM

filter the options for AMD GPUs too.

tra marked an inline comment as done.Thu, Apr 15, 2:13 PM
yaxunl accepted this revision.Thu, Apr 15, 2:32 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Thu, Apr 15, 2:32 PM