Page MenuHomePhabricator

Build and test project depends on project enabled in LibcxxAndAbiBuilder
ClosedPublic

Authored by Xiangling_L on Apr 14 2021, 11:27 AM.

Details

Summary

1.Build and test project depends on project enabled in LibcxxAndAbiBuilder
2.pass env to all steps

Diff Detail

Event Timeline

Xiangling_L requested review of this revision.Apr 14 2021, 11:27 AM
Xiangling_L created this revision.
ZarkoCA added inline comments.
zorg/buildbot/builders/LibcxxAndAbiBuilder.py
96–100

It looks like libcxxabi and libcxx are hard coded to be in depends_on_projects in line 28. Can something else remove them from the list?

It's not clear to me why we check whether they are in the list if they are hard coded.

Xiangling_L marked an inline comment as done.
Xiangling_L added inline comments.
zorg/buildbot/builders/LibcxxAndAbiBuilder.py
96–100

In line 13, we can see it's possible for us to pass in customized depends_on_projects. So it's not always equal to default values.

ZarkoCA accepted this revision.Apr 29 2021, 6:34 AM
ZarkoCA added inline comments.
zorg/buildbot/builders/LibcxxAndAbiBuilder.py
96–100

Ah, thanks. I missed that those are only set if it's value of depends_on_projects is None

This revision is now accepted and ready to land.Apr 29 2021, 6:34 AM
zorg/buildbot/builders/LibcxxAndAbiBuilder.py
105

jobs_flag here and in the similar places below could be referenced without being assigned a value above, depending on the exact list of projects in the depends_on_projects.

Xiangling_L marked an inline comment as done.Apr 29 2021, 12:58 PM
Xiangling_L added inline comments.
zorg/buildbot/builders/LibcxxAndAbiBuilder.py
105

I see. Thank you for providing a fix for this.