This is an archive of the discontinued LLVM Phabricator instance.

Differential D100468

[clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC.
ClosedPublic

Authored by mstorsjo on Apr 14 2021, 4:55 AM.

Details

Reviewers
rnk
efriedma
TomTan
maxim-kuvyrkov
Commits
rGee570e215353: [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 14 2021, 4:55 AM
Herald added subscribers: danielkiss, kristof.beyls. · View Herald TranscriptApr 14 2021, 4:55 AM
mstorsjo requested review of this revision.Apr 14 2021, 4:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2021, 4:55 AM
Harbormaster completed remote builds in B98671: Diff 337414.Apr 14 2021, 5:40 AM
rnk accepted this revision.Apr 14 2021, 11:44 AM

lgtm

This revision is now accepted and ready to land.Apr 14 2021, 11:44 AM
Closed by commit rGee570e215353: [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC. (authored by mstorsjo). · Explain WhyApr 15 2021, 1:02 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGee570e215353: [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC..

Revision Contents

PathSize
clang/
test/
CodeGen/
30 lines

Diff 337652

clang/test/CodeGen/ms_abi_aarch64.c

Show All 12 Lines
void f2(void); void f2(void);
void f3(void) { void f3(void) {
// LINUX-LABEL: define{{.*}} void @f3() // LINUX-LABEL: define{{.*}} void @f3()
// WIN64-LABEL: define dso_local void @f3() // WIN64-LABEL: define dso_local void @f3()
f1(); f1();
// LINUX: call win64cc void @f1() // LINUX: call win64cc void @f1()
// WIN64: call void @f1() // WIN64: call void @f1()
f2(); f2();
// LINUX: call void @f2() // COMMON: call void @f2()
// WIN64: call void @f2()
} }
// LINUX: declare win64cc void @f1() // LINUX: declare win64cc void @f1()
// LINUX: declare void @f2() // LINUX: declare void @f2()
// WIN64: declare dso_local void @f1() // WIN64: declare dso_local void @f1()
// WIN64: declare dso_local void @f2() // WIN64: declare dso_local void @f2()
// Win64 ABI varargs // Win64 ABI varargs
void __attribute__((ms_abi)) f4(int a, ...) { void __attribute__((ms_abi)) f4(int a, ...) {
// LINUX-LABEL: define{{.*}} win64cc void @f4 // LINUX-LABEL: define{{.*}} win64cc void @f4
// WIN64-LABEL: define dso_local void @f4 // WIN64-LABEL: define dso_local void @f4
__builtin_ms_va_list ap; __builtin_ms_va_list ap;
__builtin_ms_va_start(ap, a); __builtin_ms_va_start(ap, a);
// LINUX: %[[AP:.*]] = alloca i8* // COMMON: %[[AP:.*]] = alloca i8*
// LINUX: call void @llvm.va_start // COMMON: call void @llvm.va_start
// WIN64: %[[AP:.*]] = alloca i8*
// WIN64: call void @llvm.va_start
int b = __builtin_va_arg(ap, int); int b = __builtin_va_arg(ap, int);
// LINUX: %[[AP_CUR:.*]] = load i8*, i8** %[[AP]] // COMMON: %[[AP_CUR:.*]] = load i8*, i8** %[[AP]]
// LINUX-NEXT: %[[AP_NEXT:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR]], i64 8 // COMMON-NEXT: %[[AP_NEXT:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR]], i64 8
// LINUX-NEXT: store i8* %[[AP_NEXT]], i8** %[[AP]] // COMMON-NEXT: store i8* %[[AP_NEXT]], i8** %[[AP]]
// LINUX-NEXT: bitcast i8* %[[AP_CUR]] to i32* // COMMON-NEXT: bitcast i8* %[[AP_CUR]] to i32*
// WIN64: %[[AP_CUR:.*]] = load i8*, i8** %[[AP]]
// WIN64-NEXT: %[[AP_NEXT:.*]] = getelementptr inbounds i8, i8* %[[AP_CUR]], i64 8
// WIN64-NEXT: store i8* %[[AP_NEXT]], i8** %[[AP]]
// WIN64-NEXT: bitcast i8* %[[AP_CUR]] to i32*
__builtin_ms_va_list ap2; __builtin_ms_va_list ap2;
__builtin_ms_va_copy(ap2, ap); __builtin_ms_va_copy(ap2, ap);
// LINUX: %[[AP_VAL:.*]] = load i8*, i8** %[[AP]] // COMMON: %[[AP_VAL:.*]] = load i8*, i8** %[[AP]]
// LINUX-NEXT: store i8* %[[AP_VAL]], i8** %[[AP2:.*]] // COMMON-NEXT: store i8* %[[AP_VAL]], i8** %[[AP2:.*]]
// WIN64: %[[AP_VAL:.*]] = load i8*, i8** %[[AP]]
// WIN64-NEXT: store i8* %[[AP_VAL]], i8** %[[AP2:.*]]
__builtin_ms_va_end(ap); __builtin_ms_va_end(ap);
// LINUX: call void @llvm.va_end // COMMON: call void @llvm.va_end
// WIN64: call void @llvm.va_end
} }
void __attribute__((ms_abi)) f4_2(int a, ...) { void __attribute__((ms_abi)) f4_2(int a, ...) {
// LINUX-LABEL: define{{.*}} win64cc void @f4_2 // LINUX-LABEL: define{{.*}} win64cc void @f4_2
// WIN64-LABEL: define dso_local void @f4_2 // WIN64-LABEL: define dso_local void @f4_2
__builtin_ms_va_list ap; __builtin_ms_va_list ap;
__builtin_ms_va_start(ap, a); __builtin_ms_va_start(ap, a);
// COMMON: %[[AP:.*]] = alloca i8* // COMMON: %[[AP:.*]] = alloca i8*
Show All 32 Lines