Details
- Reviewers
cryptoad - Commits
- rG2a894b698c1a: [scudo] Restore zxtest compatibility
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
I manually patched that in, it compiles, but now I am hitting an early page fault so something else (not related to this) is likely wrong.
Investigating.
I assume D99766 should not be relevant because DefaultConfig is not tested on SCUDO_FUCHSIA ?
The roll hasn't happened in a while so I had to bisect the CLs.
I tracked it down to https://reviews.llvm.org/D96435, specifically the increase in the size class map of the default num cached from 8 to 10 (eg: the CL works with 8, but not with 10).
This boggles me a bit because I thought I tested that back then, and also I don't see immediately why the increase here ends up triggering an access violation on Fuchsia.
Still trying to debug it.
As far as I can tell this works.
With a few extra fixes:
[==========] 183 tests from 87 test cases ran (10944 ms total). [ PASSED ] 183 tests
This helped unearthed a few things that I have to address in a separate CL.
clang-tidy: error: 'gtest/gtest.h' file not found [clang-diagnostic-error]
not useful
clang-tidy: error: 'gtest/gtest.h' file not found [clang-diagnostic-error]
not useful
clang-tidy: error: 'gtest/gtest.h' file not found [clang-diagnostic-error]
not useful