Page MenuHomePhabricator

[scudo] Restore zxtest compatibility
ClosedPublic

Authored by vitalybuka on Apr 13 2021, 4:45 PM.

Diff Detail

Event Timeline

vitalybuka created this revision.Apr 13 2021, 4:45 PM
vitalybuka requested review of this revision.Apr 13 2021, 4:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2021, 4:45 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka retitled this revision from [scudo] Restore zxtest compartibility to [scudo] Restore zxtest compatibility.Apr 13 2021, 4:51 PM

I manually patched that in, it compiles, but now I am hitting an early page fault so something else (not related to this) is likely wrong.
Investigating.

I manually patched that in, it compiles, but now I am hitting an early page fault so something else (not related to this) is likely wrong.
Investigating.

I assume D99766 should not be relevant because DefaultConfig is not tested on SCUDO_FUCHSIA ?

cryptoad added a comment.EditedApr 14 2021, 12:37 PM

I assume D99766 should not be relevant because DefaultConfig is not tested on SCUDO_FUCHSIA ?

The roll hasn't happened in a while so I had to bisect the CLs.
I tracked it down to https://reviews.llvm.org/D96435, specifically the increase in the size class map of the default num cached from 8 to 10 (eg: the CL works with 8, but not with 10).
This boggles me a bit because I thought I tested that back then, and also I don't see immediately why the increase here ends up triggering an access violation on Fuchsia.
Still trying to debug it.

cryptoad accepted this revision.Apr 14 2021, 3:42 PM

As far as I can tell this works.
With a few extra fixes:

[==========] 183 tests from 87 test cases ran (10944 ms total).
[  PASSED  ] 183 tests

This helped unearthed a few things that I have to address in a separate CL.

This revision is now accepted and ready to land.Apr 14 2021, 3:42 PM
This revision was landed with ongoing or failed builds.Apr 14 2021, 10:21 PM
This revision was automatically updated to reflect the committed changes.