This is an archive of the discontinued LLVM Phabricator instance.

Differential D100354

[compiler-rt][aarch64] Add PAC-RET/BTI property to hwasan_interceptors_vfork.S
ClosedPublic

Authored by pirama on Apr 12 2021, 5:17 PM.

Details

Reviewers
eugenis
danielkiss
Commits
rG5d214238a15c: [compiler-rt][aarch64] Add PAC-RET/BTI property to hwasan_interceptors_vfork.S
Summary

D100143 added similar annotations but missed this file.

Diff Detail

Event Timeline

pirama created this revision.Apr 12 2021, 5:17 PM
Herald added subscribers: kristof.beyls, dberris. · View Herald TranscriptApr 12 2021, 5:17 PM
pirama requested review of this revision.Apr 12 2021, 5:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2021, 5:17 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
eugenis accepted this revision.Apr 12 2021, 5:21 PM

LGTM

This revision is now accepted and ready to land.Apr 12 2021, 5:21 PM
This revision was landed with ongoing or failed builds.Apr 12 2021, 5:35 PM
Closed by commit rG5d214238a15c: [compiler-rt][aarch64] Add PAC-RET/BTI property to hwasan_interceptors_vfork.S (authored by pirama). · Explain Why
This revision was automatically updated to reflect the committed changes.
pirama added a commit: rG5d214238a15c: [compiler-rt][aarch64] Add PAC-RET/BTI property to hwasan_interceptors_vfork.S.
Harbormaster completed remote builds in B98389: Diff 336999.Apr 12 2021, 5:49 PM

Revision Contents

PathSize
compiler-rt/
lib/
hwasan/
3 lines

Diff 337001

compiler-rt/lib/hwasan/hwasan_interceptors_vfork.S

#include "sanitizer_common/sanitizer_asm.h" #include "sanitizer_common/sanitizer_asm.h"
#include "builtins/assembly.h"
#if defined(__linux__) && HWASAN_WITH_INTERCEPTORS #if defined(__linux__) && HWASAN_WITH_INTERCEPTORS
#define COMMON_INTERCEPTOR_SPILL_AREA __hwasan_extra_spill_area #define COMMON_INTERCEPTOR_SPILL_AREA __hwasan_extra_spill_area
#define COMMON_INTERCEPTOR_HANDLE_VFORK __hwasan_handle_vfork #define COMMON_INTERCEPTOR_HANDLE_VFORK __hwasan_handle_vfork
#include "sanitizer_common/sanitizer_common_interceptors_vfork_aarch64.inc.S" #include "sanitizer_common/sanitizer_common_interceptors_vfork_aarch64.inc.S"
#include "sanitizer_common/sanitizer_common_interceptors_vfork_riscv64.inc.S" #include "sanitizer_common/sanitizer_common_interceptors_vfork_riscv64.inc.S"
#include "sanitizer_common/sanitizer_common_interceptors_vfork_x86_64.inc.S" #include "sanitizer_common/sanitizer_common_interceptors_vfork_x86_64.inc.S"
#endif #endif
NO_EXEC_STACK_DIRECTIVE NO_EXEC_STACK_DIRECTIVE
GNU_PROPERTY_BTI_PAC