[lldb] [Process/Linux] Report fork/vfork stop reason

[mgorny]

Summary

Enable reporting fork/vfork events to the server when supported.
At this moment, this is used only to test the server code, as real
client does not report fork-events and vfork-events as supported.

[mgorny]

This is the final piece for moving minimal fork/vfork support to gdb-remote protocol. However, for some reason (unlike the original code in D99864), it crashes on random assertions about m_enabled_extensions value — probably memory corruption somewhere. I'm debugging it.

[mgorny]

Ok, found the culprit. Now it's ready ;-).

[mgorny]

Copy software breakpoints to the forked process, to future-proof this patch for breakpoint support (I suppose there's no point in splitting it more).

Add GetSupportedExtensions() to actually enable the new code.

[mgorny]

Report vfork-done stop to the client as well.

[mgorny]

Rebase. Store mainloop arg of the original process, and pass it to the children to make them independent of the 'main' process.

[mgorny]

Now includes lldb-server tests.

@labath, please let me know if I should merge this with previous patches, or if it's fine to commit in split.

[labath]

This seems reasonable.

Why don't we have tests that detach from the parent process (and maybe continue the child)? Does that already work? (or in general, what is expected to work after this patch?)

lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

932

Store directly into unique_ptr<NativeProcessLinux> above.

938–940

I'd consider merging the two functions into SetStoppedByFork(is_vfork, child_pid)

lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp

401–402

duplicated

409–410

ditto

lldb/test/API/tools/lldb-server/main.cpp

322–327 ↗

(On Diff #339257)

I guess these would need to be ifdefed too.

[labath]

Note that you don't actually have to use/extend this particular inferior for these tests. Feel free to create special purpose inferiors, if that's a better fit for the test, just like we do with "normal" tests...

[mgorny]

In D100208#2705455, @labath wrote:

This seems reasonable.

Why don't we have tests that detach from the parent process (and maybe continue the child)? Does that already work? (or in general, what is expected to work after this patch?)

It doesn't, we need D100261 for that. Right now current_process will become nullptr if we detach the parent.

That said, technically we could test that after detaching the parent we get an error from other requests ;-).

[mgorny]

Implemented all the requests, modulo claim that PID and TID are duplicate ;-). Also found cases for bool() with Extension stuff.

[mgorny]

lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

932

Heh, I suppose it started working because we no longer pass-by-reference to NewSubprocess(). Cool!

lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp

401–402

Sure but that's only on Linux. FreeBSD and NetBSD use distinct thread IDs.

[labath]

In D100208#2705891, @mgorny wrote:

In D100208#2705455, @labath wrote:

This seems reasonable.

Why don't we have tests that detach from the parent process (and maybe continue the child)? Does that already work? (or in general, what is expected to work after this patch?)

It doesn't, we need D100261 for that. Right now current_process will become nullptr if we detach the parent.

That said, technically we could test that after detaching the parent we get an error from other requests ;-).

I think that's a good thing to test, though I suppose it could also be a part of the Hg patch.

lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp

402–403

Still duplicated. :)

[mgorny]

lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp

402–403

I'm confused. Maybe you're not noticing the tiny one-letter difference, i.e. pid vs tid? ;-) Linux is the only target where both are equal and the stop info needs to be generic, so that other platforms can assign distinct pid and tid.

[mgorny]

Add multiprocess to supported features.

Tests were moved to earlier commit. Now this commit only enables the relevant category.

lldb/packages/Python/lldbsuite/test/dotest.py

else:
             if configuration.verbose:
                 print(skip_msg%"lldb-server");
 
 
 def checkForkVForkSupport():
     from lldbsuite.test import lldbplatformutil
 
     platform = lldbplatformutil.getPlatform()
-    if platform not in []:
+    if platform not in ["linux"]:
         configuration.skip_categories.append("fork")
 
 
 def run_suite():
     # On MacOS X, check to make sure that domain for com.apple.DebugSymbols defaults
     # does not exist before proceeding to running the test suite.
     if sys.platform.startswith("darwin"):
         checkDsymForUUIDIsNotOn()

lldb/source/Plugins/Process/Linux/NativeProcessLinux.h

public:
   public:
     llvm::Expected<std::unique_ptr<NativeProcessProtocol>>
     Launch(ProcessLaunchInfo &launch_info, NativeDelegate &native_delegate,
            MainLoop &mainloop) const override;
 
     llvm::Expected<std::unique_ptr<NativeProcessProtocol>>
     Attach(lldb::pid_t pid, NativeDelegate &native_delegate,
            MainLoop &mainloop) const override;
+
+    Extension GetSupportedExtensions() const override;
   };
 
   // NativeProcessProtocol Interface
   Status Resume(const ResumeActionList &resume_actions) override;
 
   Status Halt() override;
 
   Status Detach() override;
protected:
   llvm::Expected<llvm::ArrayRef<uint8_t>>
   GetSoftwareBreakpointTrapOpcode(size_t size_hint) override;
 
   llvm::Expected<uint64_t> Syscall(llvm::ArrayRef<uint64_t> args);
 
 private:
   MainLoop::SignalHandleUP m_sigchld_handle;
   ArchSpec m_arch;
+  MainLoop& m_main_loop;
 
   LazyBool m_supports_mem_region = eLazyBoolCalculate;
   std::vector<std::pair<MemoryRegionInfo, FileSpec>> m_mem_region_cache;
 
   lldb::tid_t m_pending_notification_tid = LLDB_INVALID_THREAD_ID;
 
   /// Inferior memory (allocated by us) and its size.
   llvm::DenseMap<lldb::addr_t, lldb::addr_t> m_allocated_memory;

lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

NativeProcessLinux::Factory::Attach(
   auto tids_or = NativeProcessLinux::Attach(pid);
   if (!tids_or)
     return tids_or.takeError();
 
   return std::unique_ptr<NativeProcessLinux>(new NativeProcessLinux(
       pid, -1, native_delegate, Info.GetArchitecture(), mainloop, *tids_or));
 }
 
+NativeProcessLinux::Extension
+NativeProcessLinux::Factory::GetSupportedExtensions() const {
+  return Extension::multiprocess | Extension::fork | Extension::vfork;
+}
+
 // Public Instance Methods
 
 NativeProcessLinux::NativeProcessLinux(::pid_t pid, int terminal_fd,
                                        NativeDelegate &delegate,
                                        const ArchSpec &arch, MainLoop &mainloop,
                                        llvm::ArrayRef<::pid_t> tids)
     : NativeProcessELF(pid, terminal_fd, delegate), m_arch(arch),
-      m_intel_pt_manager(pid) {
+      m_main_loop(mainloop), m_intel_pt_manager(pid) {
   if (m_terminal_fd != -1) {
     Status status = EnsureFDFlags(m_terminal_fd, O_NONBLOCK);
     assert(status.Success());
   }
 
   Status status;
   m_sigchld_handle = mainloop.RegisterSignal(
       SIGCHLD, [this](MainLoopBase &) { SigchldHandler(); }, status);
if (!StateIsRunningState(state)) {
       state = eStateRunning;
     }
     ResumeThread(thread, state, LLDB_INVALID_SIGNAL_NUMBER);
 
     break;
   }
 
   case (SIGTRAP | (PTRACE_EVENT_VFORK_DONE << 8)): {
+    if (bool(m_enabled_extensions & Extension::vfork)) {
+      thread.SetStoppedByVForkDone();
+      StopRunningThreads(thread.GetID());
+    }
+    else
       ResumeThread(thread, thread.GetState(), LLDB_INVALID_SIGNAL_NUMBER);
     break;
   }
 
   case 0:
   case TRAP_TRACE:  // We receive this on single stepping.
   case TRAP_HWBKPT: // We receive this on watchpoint hit
   {
     // If a watchpoint was hit, report it
if (tgid_ret != child_pid) {
       ResumeThread(*parent_thread, parent_thread->GetState(),
                    LLDB_INVALID_SIGNAL_NUMBER);
       break;
     }
   }
     LLVM_FALLTHROUGH;
   case PTRACE_EVENT_FORK:
   case PTRACE_EVENT_VFORK: {
-    MainLoop unused_loop;
-    NativeProcessLinux child_process{static_cast<::pid_t>(child_pid),
-                                     m_terminal_fd,
-                                     m_delegate,
-                                     m_arch,
-                                     unused_loop,
-                                     {static_cast<::pid_t>(child_pid)}};
-    child_process.Detach();
+    bool is_vfork = clone_info->event == PTRACE_EVENT_VFORK;
+    std::unique_ptr<NativeProcessLinux> child_process{new NativeProcessLinux(
+        static_cast<::pid_t>(child_pid), m_terminal_fd, m_delegate, m_arch,
+        m_main_loop, {static_cast<::pid_t>(child_pid)})};
+    if (!is_vfork)
+      child_process->m_software_breakpoints = m_software_breakpoints;
+
+    Extension expected_ext = is_vfork ? Extension::vfork : Extension::fork;
+    if (bool(m_enabled_extensions & expected_ext)) {
+      m_delegate.NewSubprocess(this, std::move(child_process));
+      // NB: non-vfork clone() is reported as fork
+      parent_thread->SetStoppedByFork(is_vfork, child_pid);
+      StopRunningThreads(parent_thread->GetID());
+    } else {
+      child_process->Detach();
       ResumeThread(*parent_thread, parent_thread->GetState(),
                    LLDB_INVALID_SIGNAL_NUMBER);
+    }
     break;
   }
   default:
     llvm_unreachable("unknown clone_info.event");
   }
 
   return true;
 }

lldb/source/Plugins/Process/Linux/NativeThreadLinux.h

private:
   void SetStoppedByWatchpoint(uint32_t wp_index);
 
   bool IsStoppedAtBreakpoint();
 
   bool IsStoppedAtWatchpoint();
 
   void SetStoppedByTrace();
 
+  void SetStoppedByFork(bool is_vfork, lldb::pid_t child_pid);
+
+  void SetStoppedByVForkDone();
+
   void SetStoppedWithNoReason();
 
   void SetStoppedByProcessorTrace(llvm::StringRef description);
 
   void SetExited();
 
   Status RequestStop();
 

lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp

 
 void NativeThreadLinux::SetStoppedByTrace() {
   SetStopped();
 
   m_stop_info.reason = StopReason::eStopReasonTrace;
   m_stop_info.details.signal.signo = SIGTRAP;
 }
 
+void NativeThreadLinux::SetStoppedByFork(bool is_vfork, lldb::pid_t child_pid) {
+  SetStopped();
+
+  m_stop_info.reason =
+      is_vfork ? StopReason::eStopReasonVFork : StopReason::eStopReasonFork;
+  m_stop_info.details.fork.child_pid = child_pid;
+  m_stop_info.details.fork.child_tid = child_pid;
+}
+
+void NativeThreadLinux::SetStoppedByVForkDone() {
+  SetStopped();
+
+  m_stop_info.reason = StopReason::eStopReasonVForkDone;
+}
+
 void NativeThreadLinux::SetStoppedWithNoReason() {
   SetStopped();
 
   m_stop_info.reason = StopReason::eStopReasonNone;
   m_stop_info.details.signal.signo = 0;
 }
 
 void NativeThreadLinux::SetStoppedByProcessorTrace(