This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Require x86 for unwind no-return test
ClosedPublic

Authored by DavidSpickett on Apr 9 2021, 6:48 AM.

Details

Summary

The core file used is built for i386 so we
need the x86 backend to be able to load it.

Diff Detail

Event Timeline

DavidSpickett created this revision.Apr 9 2021, 6:48 AM
DavidSpickett requested review of this revision.Apr 9 2021, 6:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 9 2021, 6:48 AM

(apologies for the review spam, you're the author of the test in this case)

lldb in fact crashes when you try to load the core file. Would be nice to give a good failure message if we can but skipping this test makes sense anyway.

labath accepted this revision.Apr 12 2021, 11:45 PM

(apologies for the review spam, you're the author of the test in this case)

np

lldb in fact crashes when you try to load the core file. Would be nice to give a good failure message if we can but skipping this test makes sense anyway.

Agree completely.

This revision is now accepted and ready to land.Apr 12 2021, 11:45 PM
This revision was automatically updated to reflect the committed changes.