[lldb] Require x86 for various NativePDB, Breakpad and Minidump tests

[DavidSpickett]

Summary

These tests fail if you build without the x86 llvm backend.
Either because they use an x86 triple or try to backtrace which
requires some x86 knowledge to see all frames.

[DavidSpickett]

(not adding a reviewer for each file type since most are pretty straightforward I think)

[DavidSpickett]

lldb/test/Shell/SymbolFile/Breakpad/unwind-via-raSearch.test

45

Same thing happens here if you don't have x86 enabled, this last frame is missing.

lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml

13

@labath In this case, without the x86 backend we do get the first 3 frames just not the kernel32.dll frame.

(lldb) target symbols add ../llvm-project/lldb/test/Shell/SymbolFile/Breakpad/Inputs/unwind-via-raSearch.syms
symbol file '/home/david.spickett/llvm-project/lldb/test/Shell/SymbolFile/Breakpad/Inputs/unwind-via-raSearch.syms' has been added to '/home/david.spickett/build-llvm-aarch64/foo/foo.exe'
(lldb) thread backtrace
* thread #1
  * frame #0: 0x000b1092 foo.exe`many_pointer_args + 2
    frame #1: 0x000b1079 foo.exe`call_many + 105
    frame #2: 0x000b1085 foo.exe`main +

So my guess is that the last frame requires x86 specific knowledge to work out. If you think that's not the case or would prefer I investigate first I can remove it from this patch.

[labath]

lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml

13

Nah, that's fine. I'm pretty sure that is what's happening, and overall, I would actually say lldb should flat out refuse to open binaries/core files/etc. for which it does not have an appropriate back end....

lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpNew.py

def test_thread_info_in_minidump(self):
         # This process crashed due to a segmentation fault in its
         # one and only thread.
         self.assertEqual(self.process.GetNumThreads(), 1)
         thread = self.process.GetThreadAtIndex(0)
         self.assertEqual(thread.GetStopReason(), lldb.eStopReasonSignal)
         stop_description = thread.GetStopDescription(256)
         self.assertIn("SIGSEGV", stop_description)
 
+    @skipIfLLVMTargetMissing("X86")
     def test_stack_info_in_minidump(self):
         """Test that we can see a trivial stack in a breakpad-generated Minidump."""
         # target create linux-x86_64 -c linux-x86_64.dmp
         self.dbg.CreateTarget("linux-x86_64")
         self.target = self.dbg.GetSelectedTarget()
         self.process = self.target.LoadCore("linux-x86_64.dmp")
         self.check_state()
         self.assertEqual(self.process.GetNumThreads(), 1)
def do_change_pid_in_minidump(self, core, newcore, offset, oldpid, newpid):
             self.assertEqual(currentpid, oldpid)
 
             f.seek(offset)
             if len(newpid) < len(oldpid):
                 newpid += " " * (len(oldpid) - len(newpid))
             newpid += "\n"
             f.write(newpid.encode('utf-8'))
 
+    @skipIfLLVMTargetMissing("X86")
     def test_deeper_stack_in_minidump_with_same_pid_running(self):
         """Test that we read the information from the core correctly even if we
         have a running process with the same PID"""
         new_core = self.getBuildArtifact("linux-x86_64_not_crashed-pid.dmp")
         self.do_change_pid_in_minidump("linux-x86_64_not_crashed.dmp",
                                        new_core,
                                        self._linux_x86_64_not_crashed_pid_offset,
                                        str(self._linux_x86_64_not_crashed_pid),
                                        str(os.getpid()))
         self.do_test_deeper_stack("linux-x86_64_not_crashed", new_core, os.getpid())
 
+    @skipIfLLVMTargetMissing("X86")
     def test_two_cores_same_pid(self):
         """Test that we handle the situation if we have two core files with the same PID """
         new_core = self.getBuildArtifact("linux-x86_64_not_crashed-pid.dmp")
         self.do_change_pid_in_minidump("linux-x86_64_not_crashed.dmp",
                                        new_core,
                                        self._linux_x86_64_not_crashed_pid_offset,
                                        str(self._linux_x86_64_not_crashed_pid),
                                        str(self._linux_x86_64_pid))
         self.do_test_deeper_stack("linux-x86_64_not_crashed",
                                   new_core, self._linux_x86_64_pid)
         self.test_stack_info_in_minidump()
 
+    @skipIfLLVMTargetMissing("X86")
     def test_local_variables_in_minidump(self):
         """Test that we can examine local variables in a Minidump."""
         # Launch with the Minidump, and inspect a local variable.
         # target create linux-x86_64_not_crashed -c linux-x86_64_not_crashed.dmp
         self.target = self.dbg.CreateTarget("linux-x86_64_not_crashed")
         self.process = self.target.LoadCore("linux-x86_64_not_crashed.dmp")
         self.check_state()
         thread = self.process.GetThreadAtIndex(0)

lldb/test/Shell/Minidump/Windows/Sigsegv/sigsegv.test

+// REQUIRES: x86
+
 // RUN: cd %p/Inputs
 // RUN: env LLDB_USE_NATIVE_PDB_READER=1 \
 // RUN:   %lldb -c sigsegv.dmp -s sigsegv.lldbinit | FileCheck %s
 
 CHECK: * thread #1, stop reason = Exception 0xc0000005 encountered at address 0x7ff7a13110d9
 CHECK:   * frame #0: 0x00007ff7a13110d9 sigsegv.exe
 
 CHECK: ->  0x7ff7a13110d9: movl   $0x0, 0x0
 CHECK:     0x7ff7a13110e4: leaq   0x1f45(%rip), %rcx
 CHECK:     0x7ff7a13110eb: callq  0x7ff7a1311019
 CHECK:     0x7ff7a13110f0: addq   $0x28, %rsp
 CHECK:     0x7ff7a13110f4: retq
 CHECK:     0x7ff7a13110f5: int3

lldb/test/Shell/Minidump/disassemble-no-module.yaml

+# REQUIRES: x86
+
 # RUN: yaml2obj %s -o %t
 # RUN: %lldb -c %t -o bt -o disassemble 2>&1 | FileCheck %s
 
 # CHECK-LABEL: (lldb) bt
 # CHECK: frame #0: 0x0000000000400430
 # CHECK-LABEL: (lldb) disassemble
 # CHECK-NEXT: error: error reading data from section .module_image
 # CHECK-NEXT: error: Failed to disassemble memory at 0x00400430.

lldb/test/Shell/SymbolFile/Breakpad/unwind-via-raSearch.test

+# REQUIRES: x86
+
 # RUN: yaml2obj %S/Inputs/unwind-via-stack-win.yaml -o %t
 # RUN: %lldb -c %t \
 # RUN:   -o "target symbols add %S/Inputs/unwind-via-raSearch.syms" \
 # RUN:   -s %s -b | FileCheck %s
 
 # First check that unwind plan generation works correctly.
 # This function has a "typical" unwind rule.
 image show-unwind -n call_many

 
 # And finally, check that backtracing works as a whole by unwinding a simple
 # stack.
 thread backtrace
 # CHECK-LABEL: thread backtrace
 # CHECK: frame #0: 0x000b1092 unwind-via-stack-win.exe`many_pointer_args
 # CHECK: frame #1: 0x000b1079 unwind-via-stack-win.exe`call_many + 105
 # CHECK: frame #2: 0x000b1085 unwind-via-stack-win.exe`main + 5
 # CHECK: frame #3: 0x77278494 kernel32.dll
 # CHECK-NOT: frame

lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml

+# REQUIRES: x86
+
 # RUN: yaml2obj --docnum=1 %s -o %t.dmp
 # RUN: yaml2obj --docnum=2 %s -o %T/unwind-via-stack-win-no-memory-info.exe
 # RUN: %lldb -c %t.dmp %T/unwind-via-stack-win-no-memory-info.exe \
 # RUN:   -o "target symbols add %S/Inputs/unwind-via-raSearch.syms" \
 # RUN:   -o "thread backtrace" -b | FileCheck %s
 
 # CHECK-LABEL: thread backtrace
 # CHECK: frame #0: 0x000b1092 unwind-via-stack-win-no-memory-info.exe`many_pointer_args
 # CHECK: frame #1: 0x000b1079 unwind-via-stack-win-no-memory-info.exe`call_many + 105
 # CHECK: frame #2: 0x000b1085 unwind-via-stack-win-no-memory-info.exe`main + 5
 # CHECK: frame #3: 0x77278494 kernel32.dll
 # CHECK-NOT: frame
 
 --- !minidump
 Streams:
   - Type:            ThreadList
     Threads:
       - Thread Id:       0x0000290C
         Priority Class:  0x00000020

lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp

 // clang-format off
-// REQUIRES: lld
+// REQUIRES: lld, x86
 
 // Test that we can show disassembly and source.
 // RUN: %clang_cl --target=x86_64-windows-msvc -Od -Z7 -c /Fo%t.obj -- %s
 // RUN: lld-link -debug:full -nodefaultlib -entry:main %t.obj -out:%t.exe -pdb:%t.pdb
 // RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -s \
 // RUN:     %p/Inputs/disassembly.lldbinit | FileCheck %s
 
 // Some context lines before the function.

lldb/test/Shell/SymbolFile/NativePDB/function-types-calling-conv.cpp

 // clang-format off
-// REQUIRES: lld
+// REQUIRES: lld, x86
 
 // RUN: %clang_cl --target=i386-windows-msvc -Od -Z7 -c /Fo%t.obj -- %s
 // RUN: lld-link -debug:full -nodefaultlib -entry:main %t.obj -out:%t.exe -pdb:%t.pdb
 // RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -s \
 // RUN:     %p/Inputs/function-types-calling-conv.lldbinit | FileCheck %s
 
 
 void __stdcall StdcallFn() {}

lldb/test/Shell/SymbolFile/NativePDB/s_constant.cpp

 // clang-format off
-// REQUIRES: lld
+// REQUIRES: lld, x86
 
 // Test that we can display S_CONSTANT records.
 
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-win32 %p/Inputs/s_constant.s > %t.obj
 // RUN: %build --compiler=clang-cl --nodefaultlib --mode=link -o %t.exe -- %t.obj
 // RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -s \
 // RUN:     %p/Inputs/s_constant.lldbinit | FileCheck %s
 

lldb/test/Shell/SymbolFile/symbol-binding.test

+# REQUIRES: x86
+
 # Some targets do not have the .size directive.
 # RUN: %clang -target x86_64-unknown-unknown-elf %S/Inputs/symbol-binding.s -c -o %t.o
 # RUN: %lldb %t.o -s %s -o quit | FileCheck %s
 
 image lookup --address 4
 # CHECK: Summary: symbol-binding.test.tmp.o`case1_global
 image lookup --address 5
 # CHECK: Summary: symbol-binding.test.tmp.o`case2_weak