Refactor: Simplify boolean conditional return statements in llvm/lib/IR

[LegalizeAdulthood]

Summary

Use clang-tidy to simplify boolean conditional return statements

[craig.topper]

lib/IR/Instructions.cpp

1696

Push the negate through

2927

Push the negate through

lib/IR/Verifier.cpp

1520–1522

Operators should go on end of previous lines.

[LegalizeAdulthood]

lib/IR/Instructions.cpp

1696

Fixed.

2927

Fixed.

lib/IR/Verifier.cpp

1520–1522

Fixed.

[LegalizeAdulthood]

Update from comments, run clang-format

[LegalizeAdulthood]

Update from latest
I do not have commit access.

lib/IR/BasicBlock.cpp

 
 bool BasicBlock::canSplitPredecessors() const {
   const Instruction *FirstNonPHI = getFirstNonPHI();
   if (isa<LandingPadInst>(FirstNonPHI))
     return true;
   // This is perhaps a little conservative because constructs like
   // CleanupBlockInst are pretty easy to split.  However, SplitBlockPredecessors
   // cannot handle such things just yet.
-  if (FirstNonPHI->isEHPad())
-    return false;
-  return true;
+  return !FirstNonPHI->isEHPad();
 }
 
 /// This splits a basic block into two at the specified
 /// instruction.  Note that all instructions BEFORE the specified iterator stay
 /// as part of the original basic block, an unconditional branch is added to
 /// the new BB, and the rest of the instructions in the BB are moved to the new
 /// BB, including the old terminator.  This invalidates the iterator.
 ///

lib/IR/InlineAsm.cpp

bool InlineAsm::Verify(FunctionType *Ty, StringRef ConstStr) {
   case 1:
     if (Ty->getReturnType()->isStructTy()) return false;
     break;
   default:
     StructType *STy = dyn_cast<StructType>(Ty->getReturnType());
     if (!STy || STy->getNumElements() != NumOutputs)
       return false;
     break;
-  }      
-  
-  if (Ty->getNumParams() != NumInputs) return false;
-  return true;
+  }
+  return Ty->getNumParams() == NumInputs;
 }

lib/IR/Instructions.cpp

ExtractElementInst::ExtractElementInst(Value *Val, Value *Index,
 
   Op<0>() = Val;
   Op<1>() = Index;
   setName(Name);
 }
 
 
 bool ExtractElementInst::isValidOperands(const Value *Val, const Value *Index) {
-  if (!Val->getType()->isVectorTy() || !Index->getType()->isIntegerTy())
-    return false;
-  return true;
+  return Val->getType()->isVectorTy() && Index->getType()->isIntegerTy();
 }
 
 
 //===----------------------------------------------------------------------===//
 //                           InsertElementInst Implementation
 //===----------------------------------------------------------------------===//
 
 InsertElementInst::InsertElementInst(Value *Vec, Value *Elt, Value *Index,
if (SrcBits == 0 || DestBits == 0)
     return false;
 
   if (SrcBits != DestBits)
     return false;
 
   if (DestTy->isX86_MMXTy() || SrcTy->isX86_MMXTy())
     return false;
 
   return true;
 }
 
 bool CastInst::isBitOrNoopPointerCastable(Type *SrcTy, Type *DestTy,
                                           const DataLayout &DL) {
   if (auto *PtrTy = dyn_cast<PointerType>(SrcTy))
     if (auto *IntTy = dyn_cast<IntegerType>(DestTy))
       return IntTy->getBitWidth() == DL.getPointerTypeSizeInBits(PtrTy);
   if (auto *PtrTy = dyn_cast<PointerType>(DestTy))

lib/IR/Verifier.cpp

 }
 
 bool Verifier::VerifyAttributeCount(AttributeSet Attrs, unsigned Params) {
   if (Attrs.getNumSlots() == 0)
     return true;
 
   unsigned LastSlot = Attrs.getNumSlots() - 1;
   unsigned LastIndex = Attrs.getSlotIndex(LastSlot);
-  if (LastIndex <= Params
-      || (LastIndex == AttributeSet::FunctionIndex
-          && (LastSlot == 0 || Attrs.getSlotIndex(LastSlot - 1) <= Params)))
-    return true;
-
-  return false;
+  return LastIndex <= Params ||
+         (LastIndex == AttributeSet::FunctionIndex &&
+          (LastSlot == 0 || Attrs.getSlotIndex(LastSlot - 1) <= Params));
 }
 
 /// \brief Verify that statepoint intrinsic is well formed.
 void Verifier::VerifyStatepoint(ImmutableCallSite CS) {
   assert(CS.getCalledFunction() &&
          CS.getCalledFunction()->getIntrinsicID() ==
            Intrinsic::experimental_gc_statepoint);