Page MenuHomePhabricator

bkramer (Benjamin Kramer)
Senior ProcrastinatorAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (444 w, 4 d)
Roles
Administrator

d0k

Recent Activity

Dec 10 2020

bkramer committed rG60806e856a18: Remove Shapet assignment operator that's identical to the default. NFC. (authored by bkramer).
Remove Shapet assignment operator that's identical to the default. NFC.
Dec 10 2020, 1:59 AM
bkramer committed rGeeb713bbe242: [Hexagon] Fold single-use variables into assert. NFCI. (authored by bkramer).
[Hexagon] Fold single-use variables into assert. NFCI.
Dec 10 2020, 1:55 AM
bkramer committed rG1d00508c5bf0: [mlir][Shape] Make sure tensor_cast(constant_shape) folding uses the correct… (authored by bkramer).
[mlir][Shape] Make sure tensor_cast(constant_shape) folding uses the correct…
Dec 10 2020, 1:50 AM
bkramer closed D92927: [mlir][Shape] Make sure tensor_cast(constant_shape) folding uses the correct type.
Dec 10 2020, 1:50 AM · Restricted Project

Dec 9 2020

bkramer added inline comments to D92927: [mlir][Shape] Make sure tensor_cast(constant_shape) folding uses the correct type.
Dec 9 2020, 7:14 AM · Restricted Project
bkramer updated the diff for D92927: [mlir][Shape] Make sure tensor_cast(constant_shape) folding uses the correct type.
  • Rename argument from $ty to $arg
Dec 9 2020, 7:13 AM · Restricted Project
bkramer requested review of D92927: [mlir][Shape] Make sure tensor_cast(constant_shape) folding uses the correct type.
Dec 9 2020, 3:08 AM · Restricted Project

Dec 8 2020

bkramer committed rG5f18e2f31ecb: Move createScalarizeMaskedMemIntrinPass to Scalar.h (authored by bkramer).
Move createScalarizeMaskedMemIntrinPass to Scalar.h
Dec 8 2020, 10:08 AM
bkramer committed rG10987e30be77: Remove unused include. NFC. (authored by bkramer).
Remove unused include. NFC.
Dec 8 2020, 10:05 AM
bkramer committed rG5844bc540caf: [mlir][Shape] Canonicalize assume_all with one input and tensor_cast of… (authored by bkramer).
[mlir][Shape] Canonicalize assume_all with one input and tensor_cast of…
Dec 8 2020, 8:13 AM
bkramer closed D92843: [mlir][Shape] Canonicalize assume_all with one input and tensor_cast of constant_shape.
Dec 8 2020, 8:07 AM · Restricted Project
bkramer added inline comments to D92843: [mlir][Shape] Canonicalize assume_all with one input and tensor_cast of constant_shape.
Dec 8 2020, 7:17 AM · Restricted Project
bkramer updated the diff for D92843: [mlir][Shape] Canonicalize assume_all with one input and tensor_cast of constant_shape.
  • Address comments
Dec 8 2020, 7:17 AM · Restricted Project
bkramer requested review of D92843: [mlir][Shape] Canonicalize assume_all with one input and tensor_cast of constant_shape.
Dec 8 2020, 6:39 AM · Restricted Project

Dec 5 2020

bkramer committed rG2a136a7a9c68: [X86] Autodetect znver3 (authored by bkramer).
[X86] Autodetect znver3
Dec 5 2020, 10:10 AM

Dec 1 2020

bkramer committed rG107e92dff8ca: [DAG] Remove unused variable. NFC. (authored by bkramer).
[DAG] Remove unused variable. NFC.
Dec 1 2020, 7:29 AM

Nov 30 2020

bkramer accepted D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null.

While it would be nice for dereferenceable to not imply nonnull, the implementation currently assumes it does and will speculate loads based on that. See llvm::Value::getPointerDereferenceableBytes and its users.

Nov 30 2020, 4:35 AM · Restricted Project

Nov 26 2020

bkramer accepted D92184: [mlir][DialectConversion] Do not prematurely drop unused cast operations.

Let's land this now to unblock asan. It's breaking test/Transforms/test-legalizer.mlir though because there's a cast being left behind.

Nov 26 2020, 8:25 AM · Restricted Project
bkramer committed rG9549abcbb824: Remove stray debug-only from test (authored by bkramer).
Remove stray debug-only from test
Nov 26 2020, 6:38 AM
bkramer accepted D92173: [mlir][linalg] Mark linalg.yield as ReturnLike.

looks good

Nov 26 2020, 5:32 AM · Restricted Project

Nov 21 2020

bkramer added a comment to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

So, I have bad news: This causes OpenJDK to segfault. The relevant code is here:
https://github.com/openjdk/jdk/blob/master/src/hotspot/share/memory/arena.cpp#L311

void Arena::destruct_contents() {
  if (UseMallocOnly && _first != NULL) {
    char* end = _first->next() ? _first->top() : _hwm;
    free_malloced_objects(_first, _first->bottom(), end, _hwm);
  }
  // reset size before chop to avoid a rare racing condition
  // that can have total arena memory exceed total chunk memory
  set_size_in_bytes(0);
  _first->chop();
  reset();
}

I've also seen a segfault in Verilator that root-causes to this patch, though I haven't yet tracked that down to the source code.

I hate to say it, but is this a significant enough problem to call for a (temporary, I hope) rollback?

Nov 21 2020, 3:14 AM · Restricted Project, Restricted Project

Nov 18 2020

bkramer added a comment to D90445: [SLP] Make SLPVectorizer to use `llvm.masked.gather` intrinsic.

Saw some random miscompiles after this. Fixed by 4dbe12e86649ba6b5f03a9ba97e84d718727f7a7, can you check if I got it right?

Nov 18 2020, 4:02 AM · Restricted Project
bkramer committed rG4dbe12e86649: [SLP] Use the minimum alignment of the load bundle when forming a masked.gather (authored by bkramer).
[SLP] Use the minimum alignment of the load bundle when forming a masked.gather
Nov 18 2020, 3:55 AM

Nov 17 2020

bkramer committed rGc25e1edf61b9: [MLIR] Fix up integration tests after b7382ed3fea08da27530a6d6d53f168fc704e4c4 (authored by bkramer).
[MLIR] Fix up integration tests after b7382ed3fea08da27530a6d6d53f168fc704e4c4
Nov 17 2020, 6:44 AM

Nov 16 2020

bkramer committed rG2e7455f00a11: [LoopFlatten] Fold variable into assert. NFC. (authored by bkramer).
[LoopFlatten] Fold variable into assert. NFC.
Nov 16 2020, 2:52 AM

Nov 10 2020

bkramer committed rG92c61a045fb2: [ARM] Silence unused variable warning in Release builds. NFC. (authored by bkramer).
[ARM] Silence unused variable warning in Release builds. NFC.
Nov 10 2020, 11:35 AM

Nov 4 2020

bkramer accepted D90762: [mlir][Linalg] Add side effects interface for Linalg ops.

looks good

Nov 4 2020, 6:42 AM · Restricted Project
bkramer added inline comments to D90755: [mlir][std] Add DimOp folding for dim(tensor_load(m)) -> dim(m)..
Nov 4 2020, 4:27 AM · Restricted Project
bkramer accepted D90753: [MLIR] Support walks over regions and blocks.

Can you add a note to the commit description that this is a reland of D90379?

Nov 4 2020, 3:49 AM · Restricted Project
bkramer accepted D90745: [mlir][SCF] Add canonicalization pattern for scf::For to eliminate yields that just forward..
Nov 4 2020, 3:30 AM · Restricted Project

Nov 3 2020

bkramer added a comment to D90379: [MLIR] Support walks over regions and blocks.

Yes, I reverted it yesterday as it caused problems with the integrate. I will re-land this when I figure out how to install an old GCC version.

Nov 3 2020, 2:46 AM · Restricted Project

Nov 2 2020

bkramer added a comment to D90379: [MLIR] Support walks over regions and blocks.

Building with GCC7 is fixed by 5ece2115d85326e3b24336a7ccb4c191932ccb4a, but looks like this was reverted already.

Nov 2 2020, 2:35 PM · Restricted Project
bkramer added a comment to D90629: Revert "[MLIR] Support walks over regions and blocks".

Should be fixed as of 5ece2115d85326e3b24336a7ccb4c191932ccb4a

Nov 2 2020, 1:48 PM · Restricted Project
bkramer committed rG5ece2115d853: [MLIR] Work around an ICE in GCC 7. (authored by bkramer).
[MLIR] Work around an ICE in GCC 7.
Nov 2 2020, 1:48 PM
bkramer accepted D90593: [Clang] Add more fp128 math library function builtins .

looks good

Nov 2 2020, 4:13 AM · Restricted Project

Oct 28 2020

bkramer added a reverting change for rGa87d7b3d448a: [OpenMP] Add Passing in Original Declaration Names To Mapper API: rG207cf71fa9ce: Revert "[OpenMP] Add Passing in Original Declaration Names To Mapper API".
Oct 28 2020, 5:59 AM
bkramer added a reverting change for rGd981c7b7581e: [OpenMP] Add Support for Mapping Names in Libomptarget RTL: rG207cf71fa9ce: Revert "[OpenMP] Add Passing in Original Declaration Names To Mapper API".
Oct 28 2020, 5:59 AM
bkramer committed rG207cf71fa9ce: Revert "[OpenMP] Add Passing in Original Declaration Names To Mapper API" (authored by bkramer).
Revert "[OpenMP] Add Passing in Original Declaration Names To Mapper API"
Oct 28 2020, 5:59 AM
bkramer committed rG90a9f97cbda3: [openmp] Use front() instead of *begin() to not hide bugs when CurTypes is… (authored by bkramer).
[openmp] Use front() instead of *begin() to not hide bugs when CurTypes is…
Oct 28 2020, 5:59 AM
bkramer added a reverting change for D90172: [OpenMP] Add Support for Mapping Names in Libomptarget RTL: rG207cf71fa9ce: Revert "[OpenMP] Add Passing in Original Declaration Names To Mapper API".
Oct 28 2020, 5:59 AM · Restricted Project
bkramer added a reverting change for D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API: rG207cf71fa9ce: Revert "[OpenMP] Add Passing in Original Declaration Names To Mapper API".
Oct 28 2020, 5:59 AM · Restricted Project, Restricted Project, Restricted Project

Oct 27 2020

bkramer committed rG35f7cbf9dfec: [X86] Don't crash on CVTPS2PH with wide vector inputs. (authored by bkramer).
[X86] Don't crash on CVTPS2PH with wide vector inputs.
Oct 27 2020, 6:42 AM

Oct 26 2020

bkramer committed rG26750a1264b3: [clang-tidy] Silence unused variable warning in Release builds. NFCI. (authored by bkramer).
[clang-tidy] Silence unused variable warning in Release builds. NFCI.
Oct 26 2020, 12:21 PM
bkramer committed rGb777d3049652: [AMDGPU] Avoid unused variable warning in Release builds. NFC. (authored by bkramer).
[AMDGPU] Avoid unused variable warning in Release builds. NFC.
Oct 26 2020, 10:13 AM
bkramer committed rGdd7095f52bda: [clang][unittest] Don't hardcode the string "Assertion" (authored by bkramer).
[clang][unittest] Don't hardcode the string "Assertion"
Oct 26 2020, 10:13 AM
bkramer committed rG85e2af7ffeed: [lld][ELF] Don't write output to the test directory. NFC. (authored by bkramer).
[lld][ELF] Don't write output to the test directory. NFC.
Oct 26 2020, 10:13 AM

Oct 24 2020

bkramer committed rG39a0d6889dee: [X86] Add a stub for Intel's alderlake. (authored by bkramer).
[X86] Add a stub for Intel's alderlake.
Oct 24 2020, 10:03 AM
bkramer committed rGbd2cf96c098e: [X86] Add a stub for znver3 based on the little public information there is in… (authored by bkramer).
[X86] Add a stub for znver3 based on the little public information there is in…
Oct 24 2020, 10:03 AM
bkramer committed rGb8d2b6f6cf60: Unbreak the clang-interpreter example after… (authored by bkramer).
Unbreak the clang-interpreter example after…
Oct 24 2020, 10:03 AM

Oct 21 2020

bkramer accepted D89486: [ADT] Fix for ImmutableMapRef.

Thanks

Oct 21 2020, 1:36 AM · Restricted Project

Oct 20 2020

bkramer committed rGf2cca0b29149: Silence unused variable warning in Release builds. NFCI. (authored by bkramer).
Silence unused variable warning in Release builds. NFCI.
Oct 20 2020, 1:49 AM

Oct 19 2020

bkramer accepted D89708: Move clang/Tooling/Core/Lookup.h to clang/Tooling/Refactoring/Lookup.h.

thanks

Oct 19 2020, 3:28 PM · Restricted Project

Oct 16 2020

bkramer committed rGb740899c500b: [Indvars][NFCI] Simplify assertion. (authored by bkramer).
[Indvars][NFCI] Simplify assertion.
Oct 16 2020, 11:00 AM
bkramer added a comment to D89346: [SelectionDAG][X86] Enable SimplifySetCC CTPOP transforms for vector splats.

I have no memory of adding that transformation 9 years ago. dec + test should be better than popcnt + cmp even on modern x86, but with no data to back that up it might not matter at all.

Oct 16 2020, 3:55 AM · Restricted Project
bkramer accepted D89140: [globalopt] Teach to look through `addrspacecast`..

This should be safe. Looks good.

Oct 16 2020, 3:47 AM · Restricted Project

Oct 15 2020

bkramer added inline comments to rGc521e44defb5: [DebugInstrRef] Support recording of instruction reference substitutions.
Oct 15 2020, 4:00 AM
bkramer accepted D89454: Fix unused variable warning when compiling with asserts disabled..

The code now essentially says

Oct 15 2020, 3:53 AM · Restricted Project

Oct 14 2020

bkramer committed rG633f9fcb820b: Make header self-contained. NFC. (authored by bkramer).
Make header self-contained. NFC.
Oct 14 2020, 1:04 PM
bkramer accepted D89374: [mlir][Linalg] Make a Linalg CodegenStrategy available..

looking good

Oct 14 2020, 4:05 AM · Restricted Project

Oct 13 2020

bkramer committed rG97e48aadbd79: [mlir-cuda-runner] Unbreak the build (authored by bkramer).
[mlir-cuda-runner] Unbreak the build
Oct 13 2020, 1:40 PM

Oct 10 2020

bkramer committed rG0db08e59c9d2: [clangd] Map bits/stdint-intn.h and bits/stdint-uintn.h to cstdint. (authored by bkramer).
[clangd] Map bits/stdint-intn.h and bits/stdint-uintn.h to cstdint.
Oct 10 2020, 5:16 AM

Oct 5 2020

bkramer committed rG6bcaf6ff69e9: [mlir][Linalg] Remove unused variable. NFCI. (authored by bkramer).
[mlir][Linalg] Remove unused variable. NFCI.
Oct 5 2020, 9:59 AM
bkramer committed rG6e2b267d1c85: Promote transpose from linalg to standard dialect (authored by bkramer).
Promote transpose from linalg to standard dialect
Oct 5 2020, 2:13 AM
bkramer closed D88651: Promote transpose from linalg to standard dialect.
Oct 5 2020, 2:13 AM · Restricted Project

Oct 4 2020

bkramer added inline comments to D88651: Promote transpose from linalg to standard dialect.
Oct 4 2020, 4:02 PM · Restricted Project
bkramer updated the diff for D88651: Promote transpose from linalg to standard dialect.
  • Don't print "std." prefix on tranpose
Oct 4 2020, 4:02 PM · Restricted Project

Oct 2 2020

bkramer added inline comments to D88651: Promote transpose from linalg to standard dialect.
Oct 2 2020, 4:44 AM · Restricted Project
bkramer updated the diff for D88651: Promote transpose from linalg to standard dialect.
  • Address a round of review comments
Oct 2 2020, 4:44 AM · Restricted Project

Oct 1 2020

bkramer requested review of D88651: Promote transpose from linalg to standard dialect.
Oct 1 2020, 6:39 AM · Restricted Project

Sep 30 2020

bkramer committed rG2c394bd4071d: [PowerPC] Avoid unused variable warning in Release builds (authored by bkramer).
[PowerPC] Avoid unused variable warning in Release builds
Sep 30 2020, 8:04 AM
bkramer committed rGf33f8a2b3032: Move AffineMapAttr into BaseOps.td (authored by bkramer).
Move AffineMapAttr into BaseOps.td
Sep 30 2020, 7:24 AM
bkramer closed D88555: Move AffineMapAttr into BaseOps.td.
Sep 30 2020, 7:24 AM · Restricted Project
bkramer requested review of D88555: Move AffineMapAttr into BaseOps.td.
Sep 30 2020, 4:32 AM · Restricted Project

Sep 28 2020

bkramer accepted D88442: [mlir] [VectorOps] Relaxed restrictions on vector.reduction types even more.

looks good

Sep 28 2020, 1:16 PM · Restricted Project
bkramer committed rGb59dff4b164c: [wasm] Move WasmTraits.h to BinaryFormat (authored by bkramer).
[wasm] Move WasmTraits.h to BinaryFormat
Sep 28 2020, 1:08 PM
bkramer accepted D88436: [mlir] [VectorOps] changes to printing support for integers.

Thanks

Sep 28 2020, 11:23 AM · Restricted Project
bkramer committed rG7e5a356d2bd2: [Coroutines] Remove unused includes. NFC. (authored by bkramer).
[Coroutines] Remove unused includes. NFC.
Sep 28 2020, 1:28 AM

Sep 27 2020

bkramer committed rG7b782062b4d5: [InstCombine] Simplify code. NFCI. (authored by bkramer).
[InstCombine] Simplify code. NFCI.
Sep 27 2020, 10:12 AM

Sep 25 2020

bkramer committed rG6a1bca8798c6: [Analyzer] Fix unused variable warning in Release builds (authored by bkramer).
[Analyzer] Fix unused variable warning in Release builds
Sep 25 2020, 5:10 AM
bkramer added a comment to D88290: [mlir] [VectorOps] generalize printing support for integers.

Can we promote everything to 64 bits to simplify the logic a bit? Otherwise looking good.

Sep 25 2020, 4:52 AM · Restricted Project

Sep 22 2020

bkramer added a reverting change for rG385c3f43fceb: Implement a new kind of Pass: dynamic pass pipeline: rG0356a413a443: Revert "Implement a new kind of Pass: dynamic pass pipeline".
Sep 22 2020, 3:04 AM
bkramer committed rG0356a413a443: Revert "Implement a new kind of Pass: dynamic pass pipeline" (authored by tjoerg).
Revert "Implement a new kind of Pass: dynamic pass pipeline"
Sep 22 2020, 3:04 AM
bkramer added a reverting change for D86392: Implement a new kind of Pass: dynamic pass pipeline: rG0356a413a443: Revert "Implement a new kind of Pass: dynamic pass pipeline".
Sep 22 2020, 3:04 AM · Restricted Project
bkramer closed D88079: Revert "Implement a new kind of Pass: dynamic pass pipeline".
Sep 22 2020, 3:04 AM · Restricted Project
bkramer accepted D88079: Revert "Implement a new kind of Pass: dynamic pass pipeline".

Reproduces for me. Let's roll this back for now.

Sep 22 2020, 2:57 AM · Restricted Project

Sep 21 2020

bkramer accepted D88018: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit".

Ok, let's revert this for now. It's annoying to have a dependency on something that's not used by the in-tree backends, so we need to figure out how to remove it.

Sep 21 2020, 4:29 AM · Restricted Project
bkramer committed rG2d76274b99f2: [mlir][VectorOps] Loosen restrictions on vector.reduction types (authored by bkramer).
[mlir][VectorOps] Loosen restrictions on vector.reduction types
Sep 21 2020, 3:46 AM
bkramer closed D88010: [mlir][VectorOps] Loosen restrictions on vector.reduction types.
Sep 21 2020, 3:46 AM · Restricted Project
bkramer requested review of D88010: [mlir][VectorOps] Loosen restrictions on vector.reduction types.
Sep 21 2020, 3:08 AM · Restricted Project

Sep 17 2020

bkramer committed rG7d593d0d6905: [amdgpu] Compilation fix for Release (authored by bgraur).
[amdgpu] Compilation fix for Release
Sep 17 2020, 9:05 AM
bkramer closed D87838: [amdgpu] Compilation fix for Release.
Sep 17 2020, 9:05 AM · Restricted Project
bkramer accepted D87838: [amdgpu] Compilation fix for Release.

looks good

Sep 17 2020, 9:04 AM · Restricted Project

Sep 16 2020

bkramer committed rGf0546173fa4b: [ASTMatchers] Add missing definition for decompositionDecl (authored by bkramer).
[ASTMatchers] Add missing definition for decompositionDecl
Sep 16 2020, 8:33 AM

Sep 15 2020

bkramer added a reverting change for rGcfff88c03cf9: [InstCombine] Simplify select operand based on equality condition: rGb768546fe0cc: Revert "[InstCombine] Simplify select operand based on equality condition".
Sep 15 2020, 3:26 AM
bkramer committed rGb768546fe0cc: Revert "[InstCombine] Simplify select operand based on equality condition" (authored by bkramer).
Revert "[InstCombine] Simplify select operand based on equality condition"
Sep 15 2020, 3:26 AM
bkramer added a reverting change for D87480: [InstCombine] Simplify select operand based on equality condition: rGb768546fe0cc: Revert "[InstCombine] Simplify select operand based on equality condition".
Sep 15 2020, 3:26 AM · Restricted Project

Sep 11 2020

bkramer committed rG5405ee553a63: [CodeGenPrepare] Simplify code. NFCI. (authored by bkramer).
[CodeGenPrepare] Simplify code. NFCI.
Sep 11 2020, 2:25 AM
bkramer committed rGa0e0d30a2984: [mlir][Linalg] Print both types for linalg.transpose (authored by bkramer).
[mlir][Linalg] Print both types for linalg.transpose
Sep 11 2020, 2:18 AM
bkramer closed D87462: [mlir][Linalg] Print both types for linalg.transpose.
Sep 11 2020, 2:18 AM · Restricted Project
bkramer accepted D87434: [CodeGenPrepare] Fix zapping dead operands of assume.

Thanks, I prefer simplicity over efficiency here.

Sep 11 2020, 2:15 AM · Restricted Project