Page MenuHomePhabricator

bkramer (Benjamin Kramer)
Senior ProcrastinatorAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (422 w, 3 d)
Roles
Administrator

d0k

Recent Activity

Tue, Aug 11

bkramer committed rGd287a5a33f63: [GlobalISel] Remove unused variable. NFC. (authored by bkramer).
[GlobalISel] Remove unused variable. NFC.
Tue, Aug 11, 7:57 AM
bkramer committed rG8134c2c7ffed: [AutoUpgrade] Simplify code (authored by bkramer).
[AutoUpgrade] Simplify code
Tue, Aug 11, 4:23 AM
bkramer committed rG1de173c04984: [X86][FPEnv] Fix a use after free (authored by bkramer).
[X86][FPEnv] Fix a use after free
Tue, Aug 11, 4:02 AM

Sun, Aug 9

People empowered bkramer as an administrator.
Sun, Aug 9, 5:06 AM

Sat, Aug 8

bkramer committed rG38537307e502: lib/CodeGen doesn't depend on lib/Passes. (authored by bkramer).
lib/CodeGen doesn't depend on lib/Passes.
Sat, Aug 8, 4:41 AM

Thu, Aug 6

bkramer accepted D85482: [mlir] [VectorOps] Improve lowering of extract_strided_slice (and friends like shape_cast).

lg

Thu, Aug 6, 4:48 PM · Restricted Project
bkramer accepted D85428: [mlir][Vector] Add 2-D vector contract lowering to ReduceOp.

lg

Thu, Aug 6, 7:40 AM · Restricted Project
bkramer added inline comments to D85428: [mlir][Vector] Add 2-D vector contract lowering to ReduceOp.
Thu, Aug 6, 6:17 AM · Restricted Project
bkramer accepted D85421: [mlir][Vector] NFC - Use matchAndRewrite in ContractionOp lowering patterns.

lgtm

Thu, Aug 6, 4:08 AM · Restricted Project
bkramer accepted D85413: [mlir][Linalg] Introduce canonicalization to remove dead LinalgOps.

lg, some nits inline.

Thu, Aug 6, 2:25 AM · Restricted Project

Wed, Aug 5

bkramer accepted D85357: [mlir] [VectorOps] Add masked load/store operations to Vector dialect.

lg

Wed, Aug 5, 2:07 PM · Restricted Project, Restricted Project
bkramer committed rGc558c22cab9a: [llvm-symbolizer] Add legacy aliases -demangle=true and -demangle=false. (authored by bkramer).
[llvm-symbolizer] Add legacy aliases -demangle=true and -demangle=false.
Wed, Aug 5, 3:08 AM
bkramer committed rGba0e71432a60: Do not map read-only data memory sections with EXECUTE flags. (authored by digit).
Do not map read-only data memory sections with EXECUTE flags.
Wed, Aug 5, 1:56 AM
bkramer closed D78574: Do not map read-only data memory sections with EXECUTE flags..
Wed, Aug 5, 1:55 AM · Restricted Project

Tue, Aug 4

bkramer requested review of D85211: Use more efficient "e2" machine types.
Tue, Aug 4, 7:36 AM

Sun, Aug 2

bkramer added a comment to D84050: YAML: Don't assume an arbitrary StringRef is null terminated.

The parser used to rely on the \0 being present. Was that fixed?

Sun, Aug 2, 2:12 AM · Restricted Project

Sat, Aug 1

bkramer committed rGeb41f9edde10: [mlir][Vector] Simplify code a bit. NFCI. (authored by bkramer).
[mlir][Vector] Simplify code a bit. NFCI.
Sat, Aug 1, 5:49 AM

Fri, Jul 31

bkramer committed rGc6f08b14d489: Hide some internal symbols. NFC. (authored by bkramer).
Hide some internal symbols. NFC.
Fri, Jul 31, 9:03 AM

Tue, Jul 28

bkramer accepted D84753: [mlir][Vector] Drop declarative transforms.

lg

Tue, Jul 28, 7:04 AM · Restricted Project

Mon, Jul 27

bkramer accepted D81865: [clang] Use string tables for static diagnostic descriptions.

Nice, those relocations have annoyed me for years. I'm worried about whether the way you're accessing StaticDiagInfoDescriptionStringTable might be undefined behavior. I won't block this change on that though.

Mon, Jul 27, 8:18 AM · Restricted Project

Wed, Jul 22

bkramer committed rGbf561dd2eb13: [mlir][Vector] Vectorize integer matmuls (authored by bkramer).
[mlir][Vector] Vectorize integer matmuls
Wed, Jul 22, 10:45 AM
bkramer closed D84335: [mlir][Vector] Vectorize integer matmuls.
Wed, Jul 22, 10:45 AM · Restricted Project
Herald added a project to D84335: [mlir][Vector] Vectorize integer matmuls: Restricted Project.
Wed, Jul 22, 9:23 AM · Restricted Project
bkramer accepted D84293: Add an assertion in SmallVector::push_back().

Thanks!

Wed, Jul 22, 1:57 AM · Restricted Project

Mon, Jul 20

bkramer committed rG177e5acbe4b9: [Sema] Promote SmallSet of enum to bitset (authored by bkramer).
[Sema] Promote SmallSet of enum to bitset
Mon, Jul 20, 8:38 AM
bkramer committed rGf3f1ce4fa9f4: [Driver] Promote SmallSet of enum to a bitset. NFCI. (authored by bkramer).
[Driver] Promote SmallSet of enum to a bitset. NFCI.
Mon, Jul 20, 7:58 AM
bkramer committed rG33c9d0320e96: Upgrade SmallSets of pointer-like types to SmallPtrSet (authored by bkramer).
Upgrade SmallSets of pointer-like types to SmallPtrSet
Mon, Jul 20, 7:58 AM
bkramer committed rGe88b6ed74868: [LLE] std::inserter doesn't work with SmallSet, so don't use it. (authored by bkramer).
[LLE] std::inserter doesn't work with SmallSet, so don't use it.
Mon, Jul 20, 6:48 AM
bkramer committed rG44ab60f74d60: [LoopSimplify] Use SmallPtrSet and range for loops more. NFCI. (authored by bkramer).
[LoopSimplify] Use SmallPtrSet and range for loops more. NFCI.
Mon, Jul 20, 6:01 AM

Fri, Jul 17

bkramer committed rG9a0689e072da: Make helpers static. NFC. (authored by bkramer).
Make helpers static. NFC.
Fri, Jul 17, 4:50 AM

Thu, Jul 16

bkramer accepted D83971: [X86] Move integer hadd/hsub formation into a helper function shared by combineAdd and combineSub..

This fixes the miscompile I was seeing. Thanks!

Thu, Jul 16, 11:27 AM · Restricted Project

Jul 14 2020

bkramer accepted D83782: [mlir][Vector] Degrade masking information when forwarding linalg.copy to vector.transfer.

lgtm

Jul 14 2020, 8:47 AM · Restricted Project

Jul 13 2020

bkramer committed rG724afa5a3313: [analyzer] Inline StringSet that's defined in a header (authored by bkramer).
[analyzer] Inline StringSet that's defined in a header
Jul 13 2020, 2:51 PM
bkramer accepted D83684: [mlir] Add alignment attribute to LLVM memory ops and use in vector.transfer.

looks good!

Jul 13 2020, 8:06 AM · Restricted Project
bkramer committed rG3bffe6022cc9: [mlir][VectorOps] Lower vector.fma to llvm.fmuladd instead of llvm.fma (authored by bkramer).
[mlir][VectorOps] Lower vector.fma to llvm.fmuladd instead of llvm.fma
Jul 13 2020, 3:37 AM
bkramer closed D83666: [mlir][VectorOps] Lower vector.fma to llvm.fmuladd instead of llvm.fma.
Jul 13 2020, 3:37 AM · Restricted Project
bkramer added a comment to D83666: [mlir][VectorOps] Lower vector.fma to llvm.fmuladd instead of llvm.fma.

Great, is this the root cause of the issue we were seeing on older HW ?

Jul 13 2020, 3:35 AM · Restricted Project
Herald added a project to D83666: [mlir][VectorOps] Lower vector.fma to llvm.fmuladd instead of llvm.fma: Restricted Project.
Jul 13 2020, 3:26 AM · Restricted Project

Jul 10 2020

bkramer committed rGb887da81cc17: [CGProfile] Fix layering, IPO depends in Instrumentation. (authored by bkramer).
[CGProfile] Fix layering, IPO depends in Instrumentation.
Jul 10 2020, 10:15 AM

Jul 9 2020

bkramer committed rGd36b8414bdde: [DebugInfo] Fix pessimizing move. NFC. (authored by bkramer).
[DebugInfo] Fix pessimizing move. NFC.
Jul 9 2020, 5:25 AM
bkramer committed rGb44470547e2e: Make helpers static. NFC. (authored by bkramer).
Make helpers static. NFC.
Jul 9 2020, 4:52 AM

Jul 7 2020

bkramer accepted D83328: [mlir] [VectorOps] [integration-test] Add i64 typed outer product.

lg

Jul 7 2020, 11:50 AM · Restricted Project
bkramer committed rGcca4ac523e18: [mlir][VectorOps] Lower vector.outerproduct of int vectors (authored by bkramer).
[mlir][VectorOps] Lower vector.outerproduct of int vectors
Jul 7 2020, 5:42 AM
bkramer closed D83292: [mlir][VectorOps] Lower vector.outerproduct of int vectors.
Jul 7 2020, 5:42 AM · Restricted Project
Herald added a project to D83292: [mlir][VectorOps] Lower vector.outerproduct of int vectors: Restricted Project.
Jul 7 2020, 3:53 AM · Restricted Project

Jul 5 2020

bkramer committed rGedba2864a7a8: [clangd] Fix stack-use-after-scope (authored by bkramer).
[clangd] Fix stack-use-after-scope
Jul 5 2020, 8:30 AM

Jul 1 2020

bkramer accepted D82959: [mlir][Linalg] Add an option to use Alloca instead of malloc/free pairs..

Thanks

Jul 1 2020, 7:00 AM · Restricted Project

Jun 27 2020

bkramer committed rG85b53598a984: [RISCV] Silence unused variable warning in Release builds. NFC. (authored by bkramer).
[RISCV] Silence unused variable warning in Release builds. NFC.
Jun 27 2020, 11:27 PM

Jun 17 2020

bkramer committed rGc76edaabddea: [clang-tidy] Prune dead code. NFC. (authored by bkramer).
[clang-tidy] Prune dead code. NFC.
Jun 17 2020, 12:25 PM
bkramer accepted D81957: [mlir] [VectorOps] Add create mask integration tests.

I'm a bit worried that we now call a function taking an int with an i1 argument. This probably works because the x86 ABI passes it in a big register anyways, but it's technically undefined behavior. Can we make this int32 and call it with i32? This is fine for a followup.

Jun 17 2020, 10:13 AM · Restricted Project
bkramer accepted D82013: [MLIR] Fix parallel loop tiling..

looks good.

Jun 17 2020, 9:08 AM · Restricted Project
bkramer committed rGdf9a51dab351: Remove global std::strings. NFCI. (authored by bkramer).
Remove global std::strings. NFCI.
Jun 17 2020, 5:54 AM
bkramer committed rG547b6da73cc2: [CallPrinter] Remove static constructor. (authored by bkramer).
[CallPrinter] Remove static constructor.
Jun 17 2020, 4:17 AM
bkramer accepted D81996: [IR] Don't copy profile metadata in createCallMatchingInvoke().

looks good

Jun 17 2020, 2:07 AM · Restricted Project

Jun 7 2020

bkramer committed rG3badd17b6989: SmallPtrSet::find -> SmallPtrSet::count (authored by bkramer).
SmallPtrSet::find -> SmallPtrSet::count
Jun 7 2020, 1:51 PM
bkramer committed rG02e35832c301: [Driver] Simplify code. NFCI. (authored by bkramer).
[Driver] Simplify code. NFCI.
Jun 7 2020, 11:42 AM
bkramer accepted D81342: [Support] FoldingSetNodeID::AddString(): reserve memory.

lg

Jun 7 2020, 10:06 AM · Restricted Project
bkramer committed rG27e0077dcf0a: Try to make msvc crash less (authored by bkramer).
Try to make msvc crash less
Jun 7 2020, 9:34 AM
bkramer committed rG98626f78ae79: Unbreak the build (authored by bkramer).
Unbreak the build
Jun 7 2020, 9:34 AM
bkramer committed rGc0c6a1277546: Put back definitions. We're still not C++17 :/ (authored by bkramer).
Put back definitions. We're still not C++17 :/
Jun 7 2020, 9:02 AM
bkramer added inline comments to D81335: [IR] AttrBuilder: change TargetDepAttrs to StringMap<SmallString<16>>.
Jun 7 2020, 9:01 AM · Restricted Project
bkramer added inline comments to D81342: [Support] FoldingSetNodeID::AddString(): reserve memory.
Jun 7 2020, 9:01 AM · Restricted Project
bkramer committed rG0c3df70fad83: Remove global std::string. StringRef is sufficient. NFC. (authored by bkramer).
Remove global std::string. StringRef is sufficient. NFC.
Jun 7 2020, 8:29 AM
bkramer committed rG5a098086f996: Put compilation phases from Types.def into a bit set (authored by bkramer).
Put compilation phases from Types.def into a bit set
Jun 7 2020, 8:29 AM

May 29 2020

bkramer committed rGb9bb3ad3ed3b: Unbreak the build of mlir-cuda-runner (authored by bkramer).
Unbreak the build of mlir-cuda-runner
May 29 2020, 3:45 AM
bkramer accepted D80708: Improve SmallPtrSetImpl::count implementation.

lg

May 29 2020, 3:45 AM · Restricted Project

May 25 2020

bkramer committed rG2b8d6fa0acac: Revert "[PGO] Fix computation of function Hash" (authored by bkramer).
Revert "[PGO] Fix computation of function Hash"
May 25 2020, 11:15 AM
bkramer added a reverting change for rG7c298c104bfe: [PGO] Fix computation of function Hash: rG2b8d6fa0acac: Revert "[PGO] Fix computation of function Hash".
May 25 2020, 11:15 AM
bkramer committed rGa9b5edc5e2c4: Make mlir::Value's bool conversion operator explicit (authored by bkramer).
Make mlir::Value's bool conversion operator explicit
May 25 2020, 9:38 AM
bkramer closed D80497: Make mlir::Value's bool conversion operator explicit.
May 25 2020, 9:38 AM · Restricted Project
bkramer committed rG82bee922afd6: Make FEATURE_AVX512VP2INTERSECT match between compiler-rt and LLVM (authored by bkramer).
Make FEATURE_AVX512VP2INTERSECT match between compiler-rt and LLVM
May 25 2020, 6:24 AM

May 24 2020

bkramer created D80497: Make mlir::Value's bool conversion operator explicit.
May 24 2020, 2:24 PM · Restricted Project
bkramer updated the diff for D80497: Make mlir::Value's bool conversion operator explicit.

Put back sort

May 24 2020, 2:24 PM · Restricted Project

May 21 2020

bkramer committed rG753a21928413: [ImmutableSet] Use IntrusiveRefCntPtr to eliminate some manual refcounting (authored by bkramer).
[ImmutableSet] Use IntrusiveRefCntPtr to eliminate some manual refcounting
May 21 2020, 10:16 AM
bkramer committed rG8f9d3b937ca7: [StringRef] Use some trickery to avoid initializing the std::string returned by… (authored by bkramer).
[StringRef] Use some trickery to avoid initializing the std::string returned by…
May 21 2020, 7:31 AM
bkramer committed rGc476abfd37c0: [BitcodeReader] Simplify code. NFCI. (authored by bkramer).
[BitcodeReader] Simplify code. NFCI.
May 21 2020, 7:31 AM
bkramer committed rG5b0d1f04bf8d: Fix a layering violation by not depending from Transforms/Utils on… (authored by bkramer).
Fix a layering violation by not depending from Transforms/Utils on…
May 21 2020, 1:04 AM

May 20 2020

bkramer committed rG1219221f9ca1: [gold-plugin] Unbreak the build after d9b9ce6c04764275a23cd0cf1856a35aae921af7 (authored by bkramer).
[gold-plugin] Unbreak the build after d9b9ce6c04764275a23cd0cf1856a35aae921af7
May 20 2020, 3:13 AM

May 19 2020

bkramer committed rG350dadaa8ab3: Give helpers internal linkage. NFC. (authored by bkramer).
Give helpers internal linkage. NFC.
May 19 2020, 1:46 PM

May 14 2020

bkramer committed rG3a11ca7bed03: [MLIR] Add symbol map to mlir ExecutionEngine (authored by ezhulenev).
[MLIR] Add symbol map to mlir ExecutionEngine
May 14 2020, 1:38 PM
bkramer closed D79812: [MLIR] Add symbol map to mlir ExecutionEngine.
May 14 2020, 1:38 PM · Restricted Project
bkramer committed rG77346daaa54e: [StringSet] Simplify code a bit. NFC. (authored by bkramer).
[StringSet] Simplify code a bit. NFC.
May 14 2020, 11:58 AM
bkramer committed rG29560a89ddca: [Support] Make UniqueStringSaver wrap a StringSet (authored by bkramer).
[Support] Make UniqueStringSaver wrap a StringSet
May 14 2020, 8:38 AM

May 13 2020

bkramer committed rGa8bf2deae4f1: [CodeGenPrepare] Remove a superflouos variable. NFC. (authored by bkramer).
[CodeGenPrepare] Remove a superflouos variable. NFC.
May 13 2020, 9:45 AM

May 12 2020

bkramer committed rGf242950fdf7c: Fold single-use variables into assert (authored by bkramer).
Fold single-use variables into assert
May 12 2020, 6:57 AM

May 8 2020

bkramer committed rGf936457f80bb: Revert "Recommit "[LV] Induction Variable does not remain scalar under tail… (authored by bkramer).
Revert "Recommit "[LV] Induction Variable does not remain scalar under tail…
May 8 2020, 5:52 AM
bkramer added a reverting change for rGae45b4dbe73f: Recommit "[LV] Induction Variable does not remain scalar under tail-folding.": rGf936457f80bb: Revert "Recommit "[LV] Induction Variable does not remain scalar under tail….
May 8 2020, 5:52 AM

May 6 2020

bkramer committed rGd5ea89f8914f: Quiet some -Wdocumentation warnings. (authored by bkramer).
Quiet some -Wdocumentation warnings.
May 6 2020, 2:39 AM

May 3 2020

bkramer committed rG7a529ad2c142: [Support] Don't initialize buffer allocated by zlib::uncompress (authored by bkramer).
[Support] Don't initialize buffer allocated by zlib::uncompress
May 3 2020, 6:22 AM

May 2 2020

bkramer committed rG4597e3bd475b: [libclang]: visit BindingDecl in DecompositionDecl (authored by milianw).
[libclang]: visit BindingDecl in DecompositionDecl
May 2 2020, 1:46 PM
bkramer committed rG08e181264318: [libclang]: visit C++17 if init statements (authored by milianw).
[libclang]: visit C++17 if init statements
May 2 2020, 1:46 PM
bkramer closed D78214: [libclang]: visit C++17 if init statements.
May 2 2020, 1:46 PM · Restricted Project
bkramer closed D78213: [libclang]: visit BindingDecl in DecompositionDecl.
May 2 2020, 1:46 PM · Restricted Project
bkramer accepted D78214: [libclang]: visit C++17 if init statements.

looks good

May 2 2020, 1:46 PM · Restricted Project
bkramer accepted D78213: [libclang]: visit BindingDecl in DecompositionDecl.

looks good

May 2 2020, 1:46 PM · Restricted Project
bkramer committed rG97f92261df08: [MBP] tuple->pair. NFC. (authored by bkramer).
[MBP] tuple->pair. NFC.
May 2 2020, 11:39 AM
bkramer committed rGf7bf28b2c02a: [SmallVector] Weaken the predicate for the memcpy optimization (authored by bkramer).
[SmallVector] Weaken the predicate for the memcpy optimization
May 2 2020, 11:07 AM
bkramer committed rGc0f210d63630: Don't stash types that aren't copyable or moveable into a SmallVector (authored by bkramer).
Don't stash types that aren't copyable or moveable into a SmallVector
May 2 2020, 11:07 AM
bkramer committed rGcc1c51655854: Use realloc for NestedNameSpecifierLocBuilder (authored by bkramer).
Use realloc for NestedNameSpecifierLocBuilder
May 2 2020, 8:27 AM
bkramer committed rGd3bc86c2ed57: [Allocator] Make Deallocate() pass alignment and make it use (de)allocate_buffer (authored by bkramer).
[Allocator] Make Deallocate() pass alignment and make it use (de)allocate_buffer
May 2 2020, 7:24 AM