Page MenuHomePhabricator

bkramer (Benjamin Kramer)
Senior ProcrastinatorAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (497 w, 2 d)
Roles
Administrator

d0k

Recent Activity

Today

bkramer accepted D117772: [mlir][memref] Add better support for identity layouts in memref.collapse_shape canonicalizer.

looks good, thanks

Thu, Jan 20, 6:21 AM · Restricted Project

Yesterday

bkramer updated the diff for D117219: [LSV] Vectorize loads of vectors by turning it into a larger vector.

Adjust offset in test

Wed, Jan 19, 7:12 AM · Restricted Project
bkramer added inline comments to D117219: [LSV] Vectorize loads of vectors by turning it into a larger vector.
Wed, Jan 19, 7:09 AM · Restricted Project
bkramer updated the diff for D117219: [LSV] Vectorize loads of vectors by turning it into a larger vector.

Add negative tests for non-pow2 vectors and vectors of pointers

Wed, Jan 19, 7:08 AM · Restricted Project
bkramer committed rG579c4921c010: [bazel] Fix the python bindings for 7ceffae18c43 (authored by bkramer).
[bazel] Fix the python bindings for 7ceffae18c43
Wed, Jan 19, 5:22 AM
bkramer committed rG73cc8dd2d7d3: [bazel] Port 7ceffae18c43 (authored by bkramer).
[bazel] Port 7ceffae18c43
Wed, Jan 19, 5:16 AM

Tue, Jan 18

bkramer committed rG355acf2bef0e: [bazel] Port 755dc07d69ed (authored by bkramer).
[bazel] Port 755dc07d69ed
Tue, Jan 18, 3:57 PM
bkramer committed rGff5de8a9e0e5: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape (authored by bkramer).
[linalg][fusion] Disallow fusion when it would create an invalid expand_shape
Tue, Jan 18, 2:45 PM
bkramer committed rGf100bedb0362: [mlir][linalg] Insert a cast for identity linalg.generics when the types don't… (authored by bkramer).
[mlir][linalg] Insert a cast for identity linalg.generics when the types don't…
Tue, Jan 18, 2:45 PM
bkramer closed D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.
Tue, Jan 18, 2:44 PM · Restricted Project
bkramer closed D117498: [mlir][linalg] Insert a cast for identity linalg.generics when the types don't match.
Tue, Jan 18, 2:44 PM · Restricted Project

Mon, Jan 17

bkramer committed rG964dc368e7c7: [AsyncToLLVM] aligned_alloc requires the size to be a multiple of aignment, so… (authored by bkramer).
[AsyncToLLVM] aligned_alloc requires the size to be a multiple of aignment, so…
Mon, Jan 17, 12:50 PM
bkramer committed rG5acd6e052215: [AsyncToLLVM] Align frames to 64 bytes (authored by bkramer).
[AsyncToLLVM] Align frames to 64 bytes
Mon, Jan 17, 9:52 AM
bkramer closed D117501: [AsyncToLLVM] Align frames to 64 bytes.
Mon, Jan 17, 9:52 AM · Restricted Project
bkramer added a comment to D115443: [ADT] Weaken the initialization condition in SmallVector::resize_for_overwrite.

My concern would be the variations in the result of std::is_trivially_copyable across different c++ standards. It's possible that you could have a class considered non-trivially copyable in one compiler and trivially copyable in another. This means that it becomes unclear whether you can populate the buffer with std::uninitialized_copy or you should call std::copy (for example).

Mon, Jan 17, 9:47 AM · Restricted Project
bkramer requested review of D117501: [AsyncToLLVM] Align frames to 64 bytes.
Mon, Jan 17, 9:28 AM · Restricted Project
bkramer retitled D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape from [linalg][fusion] Cast reshape inputs to a known good type to [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.
Mon, Jan 17, 8:43 AM · Restricted Project
bkramer requested review of D117498: [mlir][linalg] Insert a cast for identity linalg.generics when the types don't match.
Mon, Jan 17, 8:40 AM · Restricted Project
bkramer updated the diff for D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.
  • Expose the shape verification logic (interface is still a bit ugly)
  • Use shared logic to stop fusion when the expand_shape would be invalid
  • Remove now redundant checking in elemental fusion
Mon, Jan 17, 8:14 AM · Restricted Project

Fri, Jan 14

bkramer committed rG765dd8b8a44c: [CGBuiltin] Simplify code. NFCI. (authored by bkramer).
[CGBuiltin] Simplify code. NFCI.
Fri, Jan 14, 7:03 AM

Thu, Jan 13

bkramer accepted D117204: [NVPTX] Add fmin/fmax.NaN lowering for sm_80+..

Nice

Thu, Jan 13, 9:31 AM · Restricted Project
bkramer accepted D117198: [NVPTX] Add version test for sm_75, sm_80, sm_86..

looks good

Thu, Jan 13, 9:29 AM · Restricted Project
bkramer added inline comments to D117219: [LSV] Vectorize loads of vectors by turning it into a larger vector.
Thu, Jan 13, 7:24 AM · Restricted Project
bkramer updated the diff for D117219: [LSV] Vectorize loads of vectors by turning it into a larger vector.

Address review comments

Thu, Jan 13, 7:24 AM · Restricted Project
bkramer requested review of D117219: [LSV] Vectorize loads of vectors by turning it into a larger vector.
Thu, Jan 13, 6:00 AM · Restricted Project

Wed, Jan 12

bkramer accepted D117122: [NVPTX] Lower fp16 fminnum, fmaxnum to native on sm_80..
Wed, Jan 12, 12:28 PM · Restricted Project

Tue, Jan 11

bkramer committed rG7f47005dcc6a: [mlir][linalg] Use cast instead of dyn_cast that's always dereferenced (authored by bkramer).
[mlir][linalg] Use cast instead of dyn_cast that's always dereferenced
Tue, Jan 11, 6:08 AM

Fri, Jan 7

bkramer committed rGae29d5a48420: [mlir] Provide a home for mlir::LLVM::GEPOp::kDynamicIndex (authored by bkramer).
[mlir] Provide a home for mlir::LLVM::GEPOp::kDynamicIndex
Fri, Jan 7, 3:06 AM

Wed, Jan 5

bkramer committed rGafc14a0d1767: Retire llvm::make_reverse_iterator in favor of std::make_reverse_iterator (authored by bkramer).
Retire llvm::make_reverse_iterator in favor of std::make_reverse_iterator
Wed, Jan 5, 5:08 AM
bkramer added a reverting change for rG29b6e967f3e9: Revert "[InferAttrs] Add writeonly to all the math functions": rG5f0a34973830: Revert "Revert "[InferAttrs] Add writeonly to all the math functions"".
Wed, Jan 5, 3:19 AM
bkramer committed rG5f0a34973830: Revert "Revert "[InferAttrs] Add writeonly to all the math functions"" (authored by bkramer).
Revert "Revert "[InferAttrs] Add writeonly to all the math functions""
Wed, Jan 5, 3:19 AM
bkramer committed rGc8ffc73350db: [PartiallyInlineLibCalls] Don't crash when there's a writeonly attribute on the… (authored by bkramer).
[PartiallyInlineLibCalls] Don't crash when there's a writeonly attribute on the…
Wed, Jan 5, 3:19 AM

Tue, Jan 4

bkramer added inline comments to D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.
Tue, Jan 4, 1:27 PM · Restricted Project
bkramer committed rG32c920875026: [flang][openacc] Remove unused variable. NFC. (authored by bkramer).
[flang][openacc] Remove unused variable. NFC.
Tue, Jan 4, 12:49 PM
bkramer committed rG41760a6b40c1: [mlir] Make Value's constructor constexpr. NFCI. (authored by bkramer).
[mlir] Make Value's constructor constexpr. NFCI.
Tue, Jan 4, 12:09 PM
bkramer requested review of D116609: [EarlyCSE] Allow elimination of redundant writeonly calls.
Tue, Jan 4, 11:11 AM · Restricted Project
bkramer updated the diff for D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.

Reduce test case more.

Tue, Jan 4, 10:54 AM · Restricted Project
bkramer added inline comments to D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.
Tue, Jan 4, 10:54 AM · Restricted Project
bkramer requested review of D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.
Tue, Jan 4, 8:10 AM · Restricted Project
bkramer added a comment to D116426: [InferAttrs] Add writeonly to all the math functions.

+ same for math intrinsics? (possible followup?)

Tue, Jan 4, 8:03 AM · Restricted Project
bkramer committed rGea75be3d9df4: [InferAttrs] Add writeonly to all the math functions (authored by bkramer).
[InferAttrs] Add writeonly to all the math functions
Tue, Jan 4, 7:59 AM
bkramer closed D116426: [InferAttrs] Add writeonly to all the math functions.
Tue, Jan 4, 7:58 AM · Restricted Project

Thu, Dec 30

bkramer requested review of D116426: [InferAttrs] Add writeonly to all the math functions.
Thu, Dec 30, 3:07 PM · Restricted Project
bkramer committed rG4683ce2cd899: [InferAttrs] Give strnlen the same attributes as strlen (authored by bkramer).
[InferAttrs] Give strnlen the same attributes as strlen
Thu, Dec 30, 11:45 AM

Dec 20 2021

bkramer committed rGcff192739bb6: [clang-include-fixer] Fix incorrect ranking because of dangling references (authored by danlark).
[clang-include-fixer] Fix incorrect ranking because of dangling references
Dec 20 2021, 7:05 AM
bkramer closed D116037: [clang-include-fixer] Fix incorrect ranking because of dangling references.
Dec 20 2021, 7:04 AM · Restricted Project
bkramer accepted D116037: [clang-include-fixer] Fix incorrect ranking because of dangling references.

Thanks

Dec 20 2021, 6:56 AM · Restricted Project

Dec 17 2021

bkramer committed rG12873d1a670b: Silence unused variable warning in release builds (authored by bkramer).
Silence unused variable warning in release builds
Dec 17 2021, 7:08 AM

Dec 14 2021

bkramer committed rG12d42653b3ad: [bazel] Port debuginfod rules (authored by bkramer).
[bazel] Port debuginfod rules
Dec 14 2021, 4:15 AM

Dec 9 2021

bkramer committed rG4c7de4fbda03: Thread safety analysis: Remove unused variable. NFC. (authored by bkramer).
Thread safety analysis: Remove unused variable. NFC.
Dec 9 2021, 9:58 AM
bkramer accepted D115436: [mlir] AsyncParallelFor: align block size to be a multiple of inner loops iterations.

lg

Dec 9 2021, 6:44 AM · Restricted Project
bkramer accepted D115263: [mlir] AsyncParallelFor: sink constants into the parallel compute function.

looks good

Dec 9 2021, 6:42 AM · Restricted Project
bkramer requested review of D115443: [ADT] Weaken the initialization condition in SmallVector::resize_for_overwrite.
Dec 9 2021, 6:12 AM · Restricted Project

Dec 8 2021

bkramer committed rG81f4874cbf35: Silence format string warning harder. (authored by bkramer).
Silence format string warning harder.
Dec 8 2021, 10:38 AM

Dec 6 2021

bkramer committed rGc94eb0f9ef55: Fix compilation of Google Test in C++20 mode (authored by Godin).
Fix compilation of Google Test in C++20 mode
Dec 6 2021, 9:08 AM
bkramer closed D115163: Fix compilation of Google Test in C++20 mode.
Dec 6 2021, 9:08 AM · Restricted Project
bkramer accepted D115163: Fix compilation of Google Test in C++20 mode.

Thanks

Dec 6 2021, 9:05 AM · Restricted Project

Nov 30 2021

bkramer committed rGfd1d8e45f488: [clang][dataflow] Make header parse (authored by bkramer).
[clang][dataflow] Make header parse
Nov 30 2021, 8:54 AM

Nov 29 2021

bkramer committed rG8d474f1d1575: [mlir] Handle an edge case when folding reshapes with multiple trailing 1… (authored by bkramer).
[mlir] Handle an edge case when folding reshapes with multiple trailing 1…
Nov 29 2021, 9:32 AM
bkramer closed D114711: [mlir] Handle an edge case when folding reshapes with multiple trailing 1 dimensions.
Nov 29 2021, 9:32 AM · Restricted Project
bkramer added a reviewer for D114711: [mlir] Handle an edge case when folding reshapes with multiple trailing 1 dimensions: pifon2a.
Nov 29 2021, 7:56 AM · Restricted Project
bkramer requested review of D114711: [mlir] Handle an edge case when folding reshapes with multiple trailing 1 dimensions.
Nov 29 2021, 7:55 AM · Restricted Project
bkramer accepted D114702: [mlir][memref] Fix bug in verification of memref.collapse_shape.

thanks

Nov 29 2021, 6:38 AM · Restricted Project

Nov 26 2021

bkramer committed rG8521850f20db: Provide a definition for OperationPosition::kDown (authored by bkramer).
Provide a definition for OperationPosition::kDown
Nov 26 2021, 5:13 AM
bkramer committed rG1b0312d28097: [PDL] fix unused variable warning in Release builds (authored by bkramer).
[PDL] fix unused variable warning in Release builds
Nov 26 2021, 5:12 AM
bkramer committed rG0e099a64be70: [tsan] Relax atexit5.cpp a bit more so it's not as dependent on the standard… (authored by bkramer).
[tsan] Relax atexit5.cpp a bit more so it's not as dependent on the standard…
Nov 26 2021, 5:02 AM

Nov 24 2021

bkramer added a reverting change for rG3cf4a2c6203b: [DAG] SimplifyDemandedBits - simplify rotl/rotr to shl/srl: rGd32787230d52: Revert "[DAG] SimplifyDemandedBits - simplify rotl/rotr to shl/srl".
Nov 24 2021, 5:45 AM
bkramer committed rGd32787230d52: Revert "[DAG] SimplifyDemandedBits - simplify rotl/rotr to shl/srl" (authored by bkramer).
Revert "[DAG] SimplifyDemandedBits - simplify rotl/rotr to shl/srl"
Nov 24 2021, 5:45 AM
bkramer added a reverting change for D114354: [DAG] SimplifyDemandedBits - simplify rotl/rotr to shl/srl: rGd32787230d52: Revert "[DAG] SimplifyDemandedBits - simplify rotl/rotr to shl/srl".
Nov 24 2021, 5:45 AM · Restricted Project

Nov 22 2021

bkramer committed rG966b72098363: [mlir][memref] Fix expanded shape ops memref.cast folding with changed type (authored by bkramer).
[mlir][memref] Fix expanded shape ops memref.cast folding with changed type
Nov 22 2021, 1:56 PM
bkramer closed D114391: [mlir][memref] Fix expanded shape ops memref.cast folding with changed type.
Nov 22 2021, 1:56 PM · Restricted Project
bkramer requested review of D114391: [mlir][memref] Fix expanded shape ops memref.cast folding with changed type.
Nov 22 2021, 1:14 PM · Restricted Project

Nov 16 2021

bkramer committed rG8b8e8704cebe: [PowerPC] Fix a nullptr dereference (authored by bkramer).
[PowerPC] Fix a nullptr dereference
Nov 16 2021, 2:58 PM

Nov 11 2021

bkramer committed rG98f80d248d9c: [Driver] Fix unused variable warning in release builds. NFC. (authored by bkramer).
[Driver] Fix unused variable warning in release builds. NFC.
Nov 11 2021, 3:21 PM
bkramer committed rGf04a1237bada: [mlir][X86Vector] Fix unused variable warning (authored by bkramer).
[mlir][X86Vector] Fix unused variable warning
Nov 11 2021, 4:19 AM

Nov 9 2021

bkramer committed rG194897eccfdd: [ARM] Fix unused variable warning in Release builds (authored by bkramer).
[ARM] Fix unused variable warning in Release builds
Nov 9 2021, 9:57 AM

Nov 8 2021

bkramer committed rGd398e8f170fa: [ASTMatcher] Provide a definition for the lambdaCapture matcher (authored by bkramer).
[ASTMatcher] Provide a definition for the lambdaCapture matcher
Nov 8 2021, 11:28 AM

Nov 7 2021

bkramer committed rG2e20ff8c1ab4: [AVR] Remove a global initializer. NFCI. (authored by bkramer).
[AVR] Remove a global initializer. NFCI.
Nov 7 2021, 7:42 AM
bkramer committed rG9b8b16457c23: Put implementation details into anonymous namespaces. NFCI. (authored by bkramer).
Put implementation details into anonymous namespaces. NFCI.
Nov 7 2021, 6:19 AM
bkramer committed rG8adb6d6de29b: [clang] Use llvm::reverse. NFCI. (authored by bkramer).
[clang] Use llvm::reverse. NFCI.
Nov 7 2021, 5:32 AM

Nov 2 2021

bkramer committed rG48677f58b06c: [lldb] Unbreak the macOS build after dfd499a61c45778b7f01458d50ccc384343f53d5 (authored by bkramer).
[lldb] Unbreak the macOS build after dfd499a61c45778b7f01458d50ccc384343f53d5
Nov 2 2021, 1:49 AM

Oct 26 2021

bkramer accepted D112566: [mlir] Allow polynomial approximations for N-d vectors..

looks good

Oct 26 2021, 11:46 AM · Restricted Project

Oct 21 2021

bkramer committed rG39724158d387: [lldb] Silence -Wpessimizing-move warning (authored by bkramer).
[lldb] Silence -Wpessimizing-move warning
Oct 21 2021, 3:59 AM
bkramer committed rG898e80964c95: [mlir] Fix a crash when creating a 1d zero element LLVM constant (authored by bkramer).
[mlir] Fix a crash when creating a 1d zero element LLVM constant
Oct 21 2021, 3:56 AM
bkramer closed D112208: [mlir] Fix a crash when creating a 1d zero element LLVM constant.
Oct 21 2021, 3:56 AM · Restricted Project
bkramer requested review of D112208: [mlir] Fix a crash when creating a 1d zero element LLVM constant.
Oct 21 2021, 2:58 AM · Restricted Project

Oct 12 2021

bkramer committed rGf67d57c95f50: [mlir][Shape] Add a pattern to turn extract from shape_of into tensor.dim (authored by bkramer).
[mlir][Shape] Add a pattern to turn extract from shape_of into tensor.dim
Oct 12 2021, 10:09 AM
bkramer closed D111651: [mlir][Shape] Add a pattern to turn extract from shape_of into tensor.dim.
Oct 12 2021, 10:09 AM · Restricted Project
bkramer added a comment to D111651: [mlir][Shape] Add a pattern to turn extract from shape_of into tensor.dim.

Do we need to limit this to where $arg is a Tensor?

Oct 12 2021, 9:59 AM · Restricted Project
bkramer updated the diff for D111651: [mlir][Shape] Add a pattern to turn extract from shape_of into tensor.dim.

Address review comments

Oct 12 2021, 9:59 AM · Restricted Project
bkramer requested review of D111651: [mlir][Shape] Add a pattern to turn extract from shape_of into tensor.dim.
Oct 12 2021, 9:05 AM · Restricted Project

Oct 8 2021

bkramer accepted D111364: [mlir] Add alignment option to constant tensor bufferization pass.

looks good

Oct 8 2021, 2:21 AM · Restricted Project

Sep 23 2021

bkramer accepted D110283: [ADT] Add trailing comma on TYPED_TEST_SUITE.
Sep 23 2021, 2:11 AM · Restricted Project

Sep 21 2021

bkramer accepted D109865: [NFC] `goto fail` has failed us in the past....

Looks good, thanks

Sep 21 2021, 3:21 AM · Restricted Project

Sep 13 2021

bkramer committed rG2d75cfdeb740: [mlir] Update bazel build for 802bf02a738e091d5bf22c03e83204a38d2c7950 (authored by bkramer).
[mlir] Update bazel build for 802bf02a738e091d5bf22c03e83204a38d2c7950
Sep 13 2021, 1:52 AM

Sep 8 2021

bkramer committed rG373b7622c1e1: [IROutliner] Remove unused variable. NFC. (authored by bkramer).
[IROutliner] Remove unused variable. NFC.
Sep 8 2021, 9:34 AM

Sep 6 2021

bkramer committed rG4a0ba4180b36: [lldb] Fix pessimizing move warning (authored by bkramer).
[lldb] Fix pessimizing move warning
Sep 6 2021, 12:18 PM
bkramer committed rGac312a9d7c03: [lldb] Silence compiler warnings from 37cbd817d3e2b8c673862e2eb262cad6dd3dd244 (authored by bkramer).
[lldb] Silence compiler warnings from 37cbd817d3e2b8c673862e2eb262cad6dd3dd244
Sep 6 2021, 4:08 AM
bkramer committed rG7fa6b9f61058: [lldb] Silence compiler warning after fae0dfa6421ea6c02f86ba7292fa782e1e2b69d1 (authored by bkramer).
[lldb] Silence compiler warning after fae0dfa6421ea6c02f86ba7292fa782e1e2b69d1
Sep 6 2021, 3:31 AM

Sep 5 2021

bkramer committed rG1a88bd68c176: [Bazel] Add missing dependency after 650bbc56203c947bb85176c40ca9c7c7a91c3c57 (authored by bkramer).
[Bazel] Add missing dependency after 650bbc56203c947bb85176c40ca9c7c7a91c3c57
Sep 5 2021, 12:15 PM