Page MenuHomePhabricator
Differential D99684

[mlir] Emit errors when creating unregistered attributes/types when not allowed
ClosedPublic
Actions

Authored by rriddle on Wed, Mar 31, 1:58 PM.

Details

Reviewers
mehdi_amini
bollu
Commits
rG109305e1046e: [mlir] Emit errors when creating unregistered attributes/types when not allowed
Summary

This was missed when verification for creating unregistered operations was added.

Diff Detail

Event Timeline

rriddle created this revision.Wed, Mar 31, 1:58 PM
Herald added a reviewer: bollu. · View Herald TranscriptWed, Mar 31, 1:58 PM
Herald added subscribers: dcaballe, cota, teijeong and 15 others. · View Herald Transcript
rriddle requested review of this revision.Wed, Mar 31, 1:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 31, 1:58 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mehdi_amini accepted this revision.Wed, Mar 31, 1:58 PM
This revision is now accepted and ready to land.Wed, Mar 31, 1:58 PM
Harbormaster completed remote builds in B96586: Diff 334526.Wed, Mar 31, 2:35 PM
Closed by commit rG109305e1046e: [mlir] Emit errors when creating unregistered attributes/types when not allowed (authored by rriddle). · Explain WhyFri, Apr 2, 12:58 PM
This revision was automatically updated to reflect the committed changes.
rriddle added a commit: rG109305e1046e: [mlir] Emit errors when creating unregistered attributes/types when not allowed.

Revision Contents
Changeset List

PathSize
mlir/
lib/
IR/
13 lines
13 lines
test/
IR/
2 lines
14 lines
unittests/
IR/
2 lines

Diff 335017

View Options

mlir/lib/IR/BuiltinAttributes.cpp

Loading...
View Options

mlir/lib/IR/BuiltinTypes.cpp

Loading...
View Options

mlir/test/IR/attribute.mlir

Loading...
View Options

mlir/test/IR/invalid-unregistered.mlir

Loading...
View Options

mlir/unittests/IR/AttributeTest.cpp

Loading...