This is an archive of the discontinued LLVM Phabricator instance.

Differential D96675

[Test][AArch64] Test SADDO/SSUBO narrowing legalization
ClosedPublic

Authored by porglezomp on Feb 14 2021, 3:42 PM.

Details

Reviewers
aemerson
paquette
arsenm
Commits
rG2ddd25fd0d6f: [Test][AArch64] Test SADDO/SSUBO narrowing legalization

Diff Detail

Unit TestsFailed

TimeTest
290 msx64 debian > LLVM.CodeGen/AArch64/GlobalISel::legalize-saddo.mir
290 msx64 debian > LLVM.CodeGen/AArch64/GlobalISel::legalize-ssubo.mir
140 msx64 windows > LLVM.CodeGen/AArch64/GlobalISel::legalize-saddo.mir
140 msx64 windows > LLVM.CodeGen/AArch64/GlobalISel::legalize-ssubo.mir

Event Timeline

porglezomp created this revision.Feb 14 2021, 3:42 PM
Herald added subscribers: danielkiss, kristof.beyls. · View Herald TranscriptFeb 14 2021, 3:42 PM
porglezomp requested review of this revision.Feb 14 2021, 3:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2021, 3:42 PM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
porglezomp added a parent revision: D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.Feb 14 2021, 3:42 PM
Harbormaster completed remote builds in B89172: Diff 323642.Feb 14 2021, 4:21 PM
porglezomp added a parent revision: D96674: [AArch64][GlobalISel] Make overflow legalization use clampScalar.Feb 14 2021, 4:32 PM
aemerson accepted this revision.Feb 23 2021, 11:05 PM

LGTM.

This revision is now accepted and ready to land.Feb 23 2021, 11:05 PM
This revision was landed with ongoing or failed builds.Feb 23 2021, 11:41 PM
Closed by commit rG2ddd25fd0d6f: [Test][AArch64] Test SADDO/SSUBO narrowing legalization (authored by porglezomp). · Explain Why
This revision was automatically updated to reflect the committed changes.
porglezomp added a commit: rG2ddd25fd0d6f: [Test][AArch64] Test SADDO/SSUBO narrowing legalization.

Revision Contents

PathSize
llvm/
test/
CodeGen/
AArch64/
GlobalISel/
61 lines
61 lines

Diff 323642

llvm/test/CodeGen/AArch64/GlobalISel/legalize-saddo.mir

# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -mtriple aarch64 -verify-machineinstrs -run-pass=legalizer -debugify-and-strip-all-safe %s -o - | FileCheck %s # RUN: llc -mtriple aarch64 -verify-machineinstrs -run-pass=legalizer -debugify-and-strip-all-safe %s -o - | FileCheck %s
--- ---
name: narrow_scalar_saddo_s128
body: |
bb.0.entry:
; CHECK-LABEL: name: narrow_scalar_saddo_s128
; CHECK: [[COPY:%[0-9]+]]:_(s64) = COPY $x0
; CHECK: [[COPY1:%[0-9]+]]:_(s64) = COPY $x1
; CHECK: [[COPY2:%[0-9]+]]:_(s64) = COPY $x2
; CHECK: [[COPY3:%[0-9]+]]:_(s64) = COPY $x3
; CHECK: [[UADDO:%[0-9]+]]:_(s64), [[UADDO1:%[0-9]+]]:_(s1) = G_UADDO [[COPY]], [[COPY2]]
; CHECK: %17:_(s64), %carry_out:_(s1) = G_SADDE [[COPY1]], [[COPY3]], [[UADDO1]]
; CHECK: %carry_out_ext:_(s64) = G_ANYEXT %carry_out(s1)
; CHECK: $x0 = COPY [[UADDO]](s64)
; CHECK: $x1 = COPY %17(s64)
; CHECK: $x2 = COPY %carry_out_ext(s64)
%0:_(s64) = COPY $x0
%1:_(s64) = COPY $x1
%2:_(s64) = COPY $x2
%3:_(s64) = COPY $x3
%lhs:_(s128) = G_MERGE_VALUES %0, %1
%rhs:_(s128) = G_MERGE_VALUES %2, %3
%add:_(s128), %carry_out:_(s1) = G_SADDO %lhs, %rhs
%add0:_(s64), %add1:_(s64) = G_UNMERGE_VALUES %add
%carry_out_ext:_(s64) = G_ANYEXT %carry_out
$x0 = COPY %add0
$x1 = COPY %add1
$x2 = COPY %carry_out_ext
...
---
name: narrow_scalar_saddo_big_nonpow2
body: |
bb.0.entry:
; CHECK-LABEL: name: narrow_scalar_saddo_big_nonpow2
; CHECK: [[COPY:%[0-9]+]]:_(s64) = COPY $x0
; CHECK: [[COPY1:%[0-9]+]]:_(s64) = COPY $x1
; CHECK: [[COPY2:%[0-9]+]]:_(s64) = COPY $x2
; CHECK: [[COPY3:%[0-9]+]]:_(s64) = COPY $x3
; CHECK: [[UADDO:%[0-9]+]]:_(s64), [[UADDO1:%[0-9]+]]:_(s1) = G_UADDO [[COPY]], [[COPY1]]
; CHECK: [[UADDE:%[0-9]+]]:_(s64), [[UADDE1:%[0-9]+]]:_(s1) = G_UADDE [[COPY1]], [[COPY2]], [[UADDO1]]
; CHECK: %22:_(s64), %carry_out:_(s1) = G_SADDE [[COPY2]], [[COPY3]], [[UADDE1]]
; CHECK: %carry_out_ext:_(s64) = G_ANYEXT %carry_out(s1)
; CHECK: $x0 = COPY [[UADDO]](s64)
; CHECK: $x1 = COPY [[UADDE]](s64)
; CHECK: $x2 = COPY %22(s64)
; CHECK: $x3 = COPY %carry_out_ext(s64)
%0:_(s64) = COPY $x0
%1:_(s64) = COPY $x1
%2:_(s64) = COPY $x2
%3:_(s64) = COPY $x3
%lhs:_(s192) = G_MERGE_VALUES %0, %1, %2
%rhs:_(s192) = G_MERGE_VALUES %1, %2, %3
%add:_(s192), %carry_out:_(s1) = G_SADDO %lhs, %rhs
%add0:_(s64), %add1:_(s64), %add2:_(s64) = G_UNMERGE_VALUES %add
%carry_out_ext:_(s64) = G_ANYEXT %carry_out
$x0 = COPY %add0
$x1 = COPY %add1
$x2 = COPY %add2
$x3 = COPY %carry_out_ext
...
---
name: test_scalar_saddo_small name: test_scalar_saddo_small
body: | body: |
bb.0.entry: bb.0.entry:
; CHECK-LABEL: name: test_scalar_saddo_small ; CHECK-LABEL: name: test_scalar_saddo_small
; CHECK: [[COPY:%[0-9]+]]:_(s64) = COPY $x0 ; CHECK: [[COPY:%[0-9]+]]:_(s64) = COPY $x0
; CHECK: [[COPY1:%[0-9]+]]:_(s64) = COPY $x1 ; CHECK: [[COPY1:%[0-9]+]]:_(s64) = COPY $x1
; CHECK: [[TRUNC:%[0-9]+]]:_(s32) = G_TRUNC [[COPY]](s64) ; CHECK: [[TRUNC:%[0-9]+]]:_(s32) = G_TRUNC [[COPY]](s64)
; CHECK: [[SEXT_INREG:%[0-9]+]]:_(s32) = G_SEXT_INREG [[TRUNC]], 8 ; CHECK: [[SEXT_INREG:%[0-9]+]]:_(s32) = G_SEXT_INREG [[TRUNC]], 8
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines

llvm/test/CodeGen/AArch64/GlobalISel/legalize-ssubo.mir

# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -mtriple aarch64 -verify-machineinstrs -run-pass=legalizer -debugify-and-strip-all-safe %s -o - | FileCheck %s # RUN: llc -mtriple aarch64 -verify-machineinstrs -run-pass=legalizer -debugify-and-strip-all-safe %s -o - | FileCheck %s
--- ---
name: narrow_scalar_ssubo_s128
body: |
bb.0.entry:
; CHECK-LABEL: name: narrow_scalar_ssubo_s128
; CHECK: [[COPY:%[0-9]+]]:_(s64) = COPY $x0
; CHECK: [[COPY1:%[0-9]+]]:_(s64) = COPY $x1
; CHECK: [[COPY2:%[0-9]+]]:_(s64) = COPY $x2
; CHECK: [[COPY3:%[0-9]+]]:_(s64) = COPY $x3
; CHECK: [[USUBO:%[0-9]+]]:_(s64), [[USUBO1:%[0-9]+]]:_(s1) = G_USUBO [[COPY]], [[COPY2]]
; CHECK: %17:_(s64), %carry_out:_(s1) = G_SSUBE [[COPY1]], [[COPY3]], [[USUBO1]]
; CHECK: %carry_out_ext:_(s64) = G_ANYEXT %carry_out(s1)
; CHECK: $x0 = COPY [[USUBO]](s64)
; CHECK: $x1 = COPY %17(s64)
; CHECK: $x2 = COPY %carry_out_ext(s64)
%0:_(s64) = COPY $x0
%1:_(s64) = COPY $x1
%2:_(s64) = COPY $x2
%3:_(s64) = COPY $x3
%lhs:_(s128) = G_MERGE_VALUES %0, %1
%rhs:_(s128) = G_MERGE_VALUES %2, %3
%sub:_(s128), %carry_out:_(s1) = G_SSUBO %lhs, %rhs
%sub0:_(s64), %sub1:_(s64) = G_UNMERGE_VALUES %sub
%carry_out_ext:_(s64) = G_ANYEXT %carry_out
$x0 = COPY %sub0
$x1 = COPY %sub1
$x2 = COPY %carry_out_ext
...
---
name: narrow_scalar_ssubo_big_nonpow2
body: |
bb.0.entry:
; CHECK-LABEL: name: narrow_scalar_ssubo_big_nonpow2
; CHECK: [[COPY:%[0-9]+]]:_(s64) = COPY $x0
; CHECK: [[COPY1:%[0-9]+]]:_(s64) = COPY $x1
; CHECK: [[COPY2:%[0-9]+]]:_(s64) = COPY $x2
; CHECK: [[COPY3:%[0-9]+]]:_(s64) = COPY $x3
; CHECK: [[USUBO:%[0-9]+]]:_(s64), [[USUBO1:%[0-9]+]]:_(s1) = G_USUBO [[COPY]], [[COPY1]]
; CHECK: [[USUBE:%[0-9]+]]:_(s64), [[USUBE1:%[0-9]+]]:_(s1) = G_USUBE [[COPY1]], [[COPY2]], [[USUBO1]]
; CHECK: %22:_(s64), %carry_out:_(s1) = G_SSUBE [[COPY2]], [[COPY3]], [[USUBE1]]
; CHECK: %carry_out_ext:_(s64) = G_ANYEXT %carry_out(s1)
; CHECK: $x0 = COPY [[USUBO]](s64)
; CHECK: $x1 = COPY [[USUBE]](s64)
; CHECK: $x2 = COPY %22(s64)
; CHECK: $x3 = COPY %carry_out_ext(s64)
%0:_(s64) = COPY $x0
%1:_(s64) = COPY $x1
%2:_(s64) = COPY $x2
%3:_(s64) = COPY $x3
%lhs:_(s192) = G_MERGE_VALUES %0, %1, %2
%rhs:_(s192) = G_MERGE_VALUES %1, %2, %3
%sub:_(s192), %carry_out:_(s1) = G_SSUBO %lhs, %rhs
%sub0:_(s64), %sub1:_(s64), %sub2:_(s64) = G_UNMERGE_VALUES %sub
%carry_out_ext:_(s64) = G_ANYEXT %carry_out
$x0 = COPY %sub0
$x1 = COPY %sub1
$x2 = COPY %sub2
$x3 = COPY %carry_out_ext
...
---
name: test_scalar_ssubo_small name: test_scalar_ssubo_small
body: | body: |
bb.0.entry: bb.0.entry:
; CHECK-LABEL: name: test_scalar_ssubo_small ; CHECK-LABEL: name: test_scalar_ssubo_small
; CHECK: [[COPY:%[0-9]+]]:_(s64) = COPY $x0 ; CHECK: [[COPY:%[0-9]+]]:_(s64) = COPY $x0
; CHECK: [[COPY1:%[0-9]+]]:_(s64) = COPY $x1 ; CHECK: [[COPY1:%[0-9]+]]:_(s64) = COPY $x1
; CHECK: [[TRUNC:%[0-9]+]]:_(s32) = G_TRUNC [[COPY]](s64) ; CHECK: [[TRUNC:%[0-9]+]]:_(s32) = G_TRUNC [[COPY]](s64)
; CHECK: [[SEXT_INREG:%[0-9]+]]:_(s32) = G_SEXT_INREG [[TRUNC]], 8 ; CHECK: [[SEXT_INREG:%[0-9]+]]:_(s32) = G_SEXT_INREG [[TRUNC]], 8
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines