Page MenuHomePhabricator

danielkiss (Daniel Kiss)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2019, 7:48 AM (58 w, 5 d)

Recent Activity

Dec 17 2020

danielkiss added a comment to D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti.

Thanks Daniel for the explanation.

No problem at all.

Dec 17 2020, 1:45 PM · Restricted Project
danielkiss added a comment to D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti.

Is there a reason why assembly files have a different flag (i.e. -mmark-bti-property) to create the .note.gnu.property with the BTI entry?

Dec 17 2020, 10:11 AM · Restricted Project
danielkiss added a comment to D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti.

The .note.gnu.property is already generated when C/C++ files are compiled with -mbranch-protection=bti.
-mmark-bti-property is only for assembly file where the .note.gnu.property should be added manually otherwise.

Dec 17 2020, 3:52 AM · Restricted Project

Dec 16 2020

danielkiss added a comment to D89570: [Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..

@manojgupta Thanks for the feedback, let me know if you have updates.

Dec 16 2020, 8:39 AM
danielkiss retitled D89570: [Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI. from [WIP][Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI. to [Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..
Dec 16 2020, 8:31 AM

Dec 10 2020

danielkiss added inline comments to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Dec 10 2020, 1:48 AM · Restricted Project, Restricted Project

Dec 3 2020

danielkiss accepted D90898: [libunwind] Unwind through aarch64/Linux sigreturn frame.

unwind_leaffunction.pass.cpp could be enable too for aarch64.

Dec 3 2020, 9:29 AM · Restricted Project, Restricted Project
danielkiss accepted D92549: [compiler-rt] Fix building the aarch64 out-of-line atomics assembly for non-ELF platforms.

LGTM

Dec 3 2020, 3:47 AM · Restricted Project

Dec 2 2020

danielkiss accepted D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

LGTM, Thanks.

Dec 2 2020, 5:27 AM · Restricted Project

Nov 17 2020

danielkiss added inline comments to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Nov 17 2020, 8:56 AM · Restricted Project

Nov 11 2020

danielkiss added inline comments to D90868: [IR] Define @llvm.ptrauth intrinsics..
Nov 11 2020, 4:49 PM · Restricted Project
danielkiss committed rGe7b8d3776f36: [libunwind] LIBUNWIND_REMEMBER_HEAP_ALLOC to cmake. (authored by danielkiss).
[libunwind] LIBUNWIND_REMEMBER_HEAP_ALLOC to cmake.
Nov 11 2020, 2:21 AM
danielkiss closed D91182: [libunwind] LIBUNWIND_REMEMBER_HEAP_ALLOC to cmake..
Nov 11 2020, 2:21 AM · Restricted Project, Restricted Project

Nov 10 2020

danielkiss added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

Done see: D91182

Nov 10 2020, 9:03 AM · Restricted Project, Restricted Project
danielkiss requested review of D91182: [libunwind] LIBUNWIND_REMEMBER_HEAP_ALLOC to cmake..
Nov 10 2020, 9:02 AM · Restricted Project, Restricted Project
danielkiss added inline comments to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Nov 10 2020, 8:41 AM · Restricted Project

Nov 9 2020

danielkiss added inline comments to D91087: [AArch64] Select PAC/PACGA for ptrauth.sign/sign_generic..
Nov 9 2020, 11:04 AM · Restricted Project
danielkiss added inline comments to D90898: [libunwind] Unwind through aarch64/Linux sigreturn frame.
Nov 9 2020, 7:26 AM · Restricted Project, Restricted Project

Nov 5 2020

danielkiss added inline comments to D89483: [ARM][MachineOutliner] Emit more CFI instructions.
Nov 5 2020, 3:00 PM · Restricted Project

Nov 2 2020

danielkiss accepted D90615: [libunwind] Add missing #include <alloca.h>.

LGTM, Thanks!

Nov 2 2020, 7:56 AM · Restricted Project, Restricted Project

Oct 30 2020

danielkiss added inline comments to D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage.
Oct 30 2020, 11:30 AM · Restricted Project, Restricted Project
danielkiss committed rG1d7786d45f48: [libunwind] Support DW_CFA_remember/restore_state without heap allocation. (authored by danielkiss).
[libunwind] Support DW_CFA_remember/restore_state without heap allocation.
Oct 30 2020, 9:45 AM
danielkiss closed D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Oct 30 2020, 9:45 AM · Restricted Project, Restricted Project

Oct 29 2020

danielkiss committed rGfd1c064845e5: [libcxx] Add targets to available features. (authored by danielkiss).
[libcxx] Add targets to available features.
Oct 29 2020, 6:04 AM
danielkiss closed D88027: [libcxx] Add targets to available features..
Oct 29 2020, 6:04 AM · Restricted Project
danielkiss committed rG05598e3d3047: [libunwind] Fix linker flag handling in the tests. (authored by danielkiss).
[libunwind] Fix linker flag handling in the tests.
Oct 29 2020, 6:03 AM
danielkiss closed D90202: [libunwind] Fix linker flag handling in the tests..
Oct 29 2020, 6:02 AM · Restricted Project, Restricted Project
danielkiss added a comment to D89570: [Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..

https://bugs.llvm.org/show_bug.cgi?id=47142 this effects this. the missing unwind info make forceunwind fragile.

Oct 29 2020, 5:59 AM

Oct 26 2020

danielkiss added a comment to D90202: [libunwind] Fix linker flag handling in the tests..

self.cxx has a function to test compiler flags addFlagIfSupported but there is no support for linker flag (yet).

Oct 26 2020, 5:44 PM · Restricted Project, Restricted Project
danielkiss added inline comments to D83573: [libunwind] Support for leaf function unwinding..
Oct 26 2020, 5:40 PM · Restricted Project, Restricted Project
danielkiss requested review of D90202: [libunwind] Fix linker flag handling in the tests..
Oct 26 2020, 5:39 PM · Restricted Project, Restricted Project
danielkiss updated the diff for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

rebase, add MINGW32

Oct 26 2020, 3:01 PM · Restricted Project, Restricted Project

Oct 19 2020

danielkiss added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

ping

Oct 19 2020, 7:53 AM · Restricted Project, Restricted Project

Oct 17 2020

danielkiss updated the diff for D89570: [Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..
Oct 17 2020, 4:11 PM
danielkiss updated the diff for D89570: [Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..

Add a simple test and fixes.
This version passes on arm32 - armv7l-unknown-linux-gnueabihf -

Oct 17 2020, 4:07 PM
danielkiss planned changes to D89570: [Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..
Oct 17 2020, 1:54 PM

Oct 16 2020

danielkiss updated the diff for D89570: [Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..

_Unwind_Stop_Fn shall not have different signature for EHABI.

Oct 16 2020, 12:53 PM
danielkiss changed the visibility for D89570: [Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..
Oct 16 2020, 11:05 AM
danielkiss requested review of D89570: [Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..
Oct 16 2020, 11:04 AM

Oct 15 2020

danielkiss added a comment to D72365: [MTE] Pin the tagged base pointer to one of the stack slots..

Those are gone from the view, so ignore what I said.

Oct 15 2020, 9:49 AM · Restricted Project

Oct 12 2020

danielkiss accepted D72365: [MTE] Pin the tagged base pointer to one of the stack slots..

LGTM, just please fix the lint issues in the llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h

Oct 12 2020, 6:49 AM · Restricted Project
danielkiss accepted D72366: [AArch64] Stack frame reordering..

LGTM

Oct 12 2020, 4:05 AM · Restricted Project
danielkiss added a comment to D88027: [libcxx] Add targets to available features..

The system-* and native are used in clang and lldb only, so dropped.
I only added them for consistency across llvm components.

Oct 12 2020, 4:03 AM · Restricted Project
danielkiss updated the diff for D88027: [libcxx] Add targets to available features..
Oct 12 2020, 3:58 AM · Restricted Project

Sep 29 2020

danielkiss committed rGf34ae1b9de68: [AArch64] Add v8.5 Branch Target Identification support. (authored by danielkiss).
[AArch64] Add v8.5 Branch Target Identification support.
Sep 29 2020, 6:51 AM
danielkiss closed D77786: [AArch64] Add v8.5 Branch Target Identification support..
Sep 29 2020, 6:51 AM · Restricted Project, Restricted Project
danielkiss committed rGc5a4900e1a00: [AArch64] Add BTI to CFI jumptables. (authored by danielkiss).
[AArch64] Add BTI to CFI jumptables.
Sep 29 2020, 4:50 AM
danielkiss closed D81251: [AArch64] Add BTI to CFI jumptables..
Sep 29 2020, 4:50 AM · Restricted Project
danielkiss added inline comments to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Sep 29 2020, 3:32 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Sep 29 2020, 3:31 AM · Restricted Project, Restricted Project
danielkiss added a comment to D88027: [libcxx] Add targets to available features..

some test never runs due to these features are missing. I realised this when tried to run this one: https://github.com/llvm/llvm-project/blob/master/libunwind/test/remember_state_leak.pass.sh.s#L1

Sep 29 2020, 3:14 AM · Restricted Project
danielkiss added reviewers for D88027: [libcxx] Add targets to available features.: jgorbe, lhames.
Sep 29 2020, 3:13 AM · Restricted Project

Sep 28 2020

danielkiss added inline comments to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Sep 28 2020, 8:50 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Sep 28 2020, 8:49 AM · Restricted Project, Restricted Project
danielkiss committed rGa48f6079f288: [AArch64] Generate .note.gnu.property based on module flags. (authored by danielkiss).
[AArch64] Generate .note.gnu.property based on module flags.
Sep 28 2020, 5:14 AM
danielkiss closed D80791: [AArch64] Generate .note.gnu.property based on module flags..
Sep 28 2020, 5:14 AM · Restricted Project, Restricted Project

Sep 25 2020

danielkiss updated the diff for D81251: [AArch64] Add BTI to CFI jumptables..

update module flag handling due to the change is merged in: D85649.

Sep 25 2020, 8:42 AM · Restricted Project
danielkiss updated the diff for D80791: [AArch64] Generate .note.gnu.property based on module flags..
Sep 25 2020, 5:09 AM · Restricted Project, Restricted Project

Sep 24 2020

danielkiss added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

Thanks for the review. It looks like I still need someone from the libunwind group to accept it.

Sep 24 2020, 2:29 PM · Restricted Project, Restricted Project
danielkiss committed rG2a96f47c5ffc: [AArch64] __builtin_return_address for PAuth. (authored by danielkiss).
[AArch64] __builtin_return_address for PAuth.
Sep 24 2020, 2:24 PM
danielkiss closed D75044: [AArch64] __builtin_return_address for PAuth..
Sep 24 2020, 2:24 PM · Restricted Project, Restricted Project
danielkiss added inline comments to D86972: [IRSim] Adding a basic similarity identifier..
Sep 24 2020, 7:43 AM · Restricted Project
danielkiss accepted D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

@nickdesaulniers

one kernel image that runs on hardware both with and without BTI ISA extensions?

In case of BTI one image could run on both HW due to BTI is in the no-op space.

Sep 24 2020, 6:32 AM · Restricted Project, Restricted Project
danielkiss added a comment to D75044: [AArch64] __builtin_return_address for PAuth..

@chill ping.

Sep 24 2020, 4:30 AM · Restricted Project, Restricted Project

Sep 21 2020

danielkiss added inline comments to D77786: [AArch64] Add v8.5 Branch Target Identification support..
Sep 21 2020, 2:20 PM · Restricted Project, Restricted Project
danielkiss requested review of D88027: [libcxx] Add targets to available features..
Sep 21 2020, 8:43 AM · Restricted Project
danielkiss accepted D87880: [libunwind] Combine dl_iterate_phdr codepaths for DWARF and EHABI.

LGTM, refactor looks correct. in case of _LIBUNWIND_ARM_EHABI the director of the iteration over the phdrs changed but that is fine.

Sep 21 2020, 2:15 AM · Restricted Project, Restricted Project

Sep 18 2020

danielkiss added a comment to D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

I think error is fine because realistically linking modules with different BTI settings will result probably a binary that crash runtime anyway if BTI is on.
otherwise turning BTI on just of a subset of object is useless.

Sep 18 2020, 9:43 AM · Restricted Project, Restricted Project
danielkiss committed rG22b615a96593: [libunwind] Support for leaf function unwinding. (authored by danielkiss).
[libunwind] Support for leaf function unwinding.
Sep 18 2020, 6:12 AM
danielkiss updated subscribers of D83573: [libunwind] Support for leaf function unwinding..

Sorry for the trouble for now the patch is reverted.
I you agre I will resubmit it with ; REQUIRES: x86_64-linux and then figure out the rest of the targets later.

Sep 18 2020, 3:20 AM · Restricted Project, Restricted Project
danielkiss added a reverting change for rG23bef7ee9923: [libunwind] Support for leaf function unwinding.: rG5831adb8c38f: Revert "[libunwind] Support for leaf function unwinding.".
Sep 18 2020, 2:38 AM
danielkiss committed rG5831adb8c38f: Revert "[libunwind] Support for leaf function unwinding." (authored by danielkiss).
Revert "[libunwind] Support for leaf function unwinding."
Sep 18 2020, 2:38 AM
danielkiss added a reverting change for D83573: [libunwind] Support for leaf function unwinding.: rG5831adb8c38f: Revert "[libunwind] Support for leaf function unwinding.".
Sep 18 2020, 2:38 AM · Restricted Project, Restricted Project

Sep 17 2020

danielkiss added inline comments to D77786: [AArch64] Add v8.5 Branch Target Identification support..
Sep 17 2020, 1:59 AM · Restricted Project, Restricted Project

Sep 16 2020

danielkiss committed rGf70baaf71f62: [AArch64] Add -mmark-bti-property flag. (authored by danielkiss).
[AArch64] Add -mmark-bti-property flag.
Sep 16 2020, 4:21 PM
danielkiss added a reverting change for rG95e43f84b7b9: [AArch64] Add -mmark-bti-property flag.: rG60e244f82c1f: Revert "[AArch64] Add -mmark-bti-property flag.".
Sep 16 2020, 4:21 PM
danielkiss committed rG60e244f82c1f: Revert "[AArch64] Add -mmark-bti-property flag." (authored by danielkiss).
Revert "[AArch64] Add -mmark-bti-property flag."
Sep 16 2020, 4:21 PM
danielkiss added a reverting change for D81930: [AArch64] Add -mmark-bti-property flag.: rG60e244f82c1f: Revert "[AArch64] Add -mmark-bti-property flag.".
Sep 16 2020, 4:21 PM · Restricted Project, Restricted Project
danielkiss committed rG95e43f84b7b9: [AArch64] Add -mmark-bti-property flag. (authored by danielkiss).
[AArch64] Add -mmark-bti-property flag.
Sep 16 2020, 3:24 PM
danielkiss closed D81930: [AArch64] Add -mmark-bti-property flag..
Sep 16 2020, 3:24 PM · Restricted Project, Restricted Project
danielkiss committed rG23bef7ee9923: [libunwind] Support for leaf function unwinding. (authored by danielkiss).
[libunwind] Support for leaf function unwinding.
Sep 16 2020, 2:54 PM
danielkiss closed D83573: [libunwind] Support for leaf function unwinding..
Sep 16 2020, 2:53 PM · Restricted Project, Restricted Project
danielkiss updated the diff for D81251: [AArch64] Add BTI to CFI jumptables..

rebasing to the new patch series.

Sep 16 2020, 1:56 PM · Restricted Project
danielkiss added inline comments to D81251: [AArch64] Add BTI to CFI jumptables..
Sep 16 2020, 1:52 PM · Restricted Project
danielkiss updated the diff for D80791: [AArch64] Generate .note.gnu.property based on module flags..

Rebased top of D85649.

Sep 16 2020, 9:18 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

adding an option _LIBUNWIND_REMEMBER_HEAP to store the state on the heap.
I kept the default on the stack because it should be fine for most cases.

Sep 16 2020, 7:58 AM · Restricted Project, Restricted Project
danielkiss accepted D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

LGTM

Sep 16 2020, 3:51 AM · Restricted Project, Restricted Project

Sep 15 2020

danielkiss added a comment to D81930: [AArch64] Add -mmark-bti-property flag..

@nickdesaulniers Thanks for the review, comments are addressed.

Sep 15 2020, 7:49 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D81930: [AArch64] Add -mmark-bti-property flag..
Sep 15 2020, 7:46 AM · Restricted Project, Restricted Project
danielkiss added inline comments to D83573: [libunwind] Support for leaf function unwinding..
Sep 15 2020, 3:27 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D83573: [libunwind] Support for leaf function unwinding..
Sep 15 2020, 3:26 AM · Restricted Project, Restricted Project

Sep 11 2020

danielkiss planned changes to D77565: [AArch64] Remove implicit landing pads..

I'll update this after other PAC/BTI patches got merged.

Sep 11 2020, 8:53 AM · Restricted Project
danielkiss added reviewers for D81930: [AArch64] Add -mmark-bti-property flag.: nickdesaulniers, srhines, enh, rprichard.
Sep 11 2020, 7:14 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D83573: [libunwind] Support for leaf function unwinding..
Sep 11 2020, 7:10 AM · Restricted Project, Restricted Project
danielkiss added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

ping

Sep 11 2020, 5:04 AM · Restricted Project, Restricted Project
danielkiss added reviewers for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation.: phosek, mstorsjo, steven_wu.
Sep 11 2020, 5:03 AM · Restricted Project, Restricted Project

Sep 4 2020

danielkiss added a comment to D75044: [AArch64] __builtin_return_address for PAuth..

@chill Could you check the latest update? I think it should be submitted with D84502 together.

Sep 4 2020, 4:33 AM · Restricted Project, Restricted Project

Sep 1 2020

danielkiss added inline comments to D81251: [AArch64] Add BTI to CFI jumptables..
Sep 1 2020, 4:59 AM · Restricted Project
danielkiss added a comment to D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

I support the idea, once I proposed back then ( see D75181 )

Sep 1 2020, 4:58 AM · Restricted Project, Restricted Project

Aug 29 2020

danielkiss planned changes to D81251: [AArch64] Add BTI to CFI jumptables..

I need to update it due to changes in the dependent patches.

Aug 29 2020, 6:37 AM · Restricted Project