Page MenuHomePhabricator

[RISCV] refactor VPatBinary (NFC)
ClosedPublic

Authored by arcbbb on Jan 19 2021, 12:34 AM.

Details

Summary

Make it easier to reuse for intrinsic vrgatherei16.

Diff Detail

Event Timeline

arcbbb created this revision.Jan 19 2021, 12:34 AM
arcbbb requested review of this revision.Jan 19 2021, 12:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2021, 12:34 AM

I'm not sure I understand what's special about vrgathere16 that needs this refactor. Can you provide an explanation?

I'm not sure I understand what's special about vrgathere16 that needs this refactor. Can you provide an explanation?

VPatBinary helps encode LMUL in the instruction name,
but for vrgatherei16 it needs to encode both LMUL & EMUL in the instruction name,
like PseudoVRGATHEREI16_VV_M1_M1, and PseudoVRGATHEREI16_VV_M1_M2.
Here is my patch for vrgatherei16 based on the NFC patch https://reviews.llvm.org/D95014

I'm not sure I understand what's special about vrgathere16 that needs this refactor. Can you provide an explanation?

VPatBinary helps encode LMUL in the instruction name,
but for vrgatherei16 it needs to encode both LMUL & EMUL in the instruction name,
like PseudoVRGATHEREI16_VV_M1_M1, and PseudoVRGATHEREI16_VV_M1_M2.
Here is my patch for vrgatherei16 based on the NFC patch https://reviews.llvm.org/D95014

ok that makes sense. thanks.

This revision is now accepted and ready to land.Jan 19 2021, 6:57 PM
This revision was automatically updated to reflect the committed changes.