This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Use AST-based signals in CodeCompletion.
ClosedPublic

Authored by usaxena95 on Jan 12 2021, 1:25 AM.

Diff Detail

Event Timeline

usaxena95 created this revision.Jan 12 2021, 1:25 AM
usaxena95 requested review of this revision.Jan 12 2021, 1:25 AM
usaxena95 updated this revision to Diff 316071.Jan 12 2021, 6:01 AM

Edge cases fix.

adamcz added inline comments.Jan 15 2021, 5:17 AM
clang-tools-extra/clangd/Quality.cpp
362

Maybe it's just me, but using a lambda like this seems quite confusing. I don't think it improves readability. Maybe just make it a separate method? Or inline here, but without lambda?

usaxena95 updated this revision to Diff 317307.Jan 18 2021, 2:42 AM
usaxena95 marked an inline comment as done.

Addressed comments.

adamcz accepted this revision.Jan 18 2021, 8:30 AM
This revision is now accepted and ready to land.Jan 18 2021, 8:30 AM
This revision was automatically updated to reflect the committed changes.