Page MenuHomePhabricator

[ArgPromotion] Copy !range metadata for loads.
Needs ReviewPublic

Authored by wecing on Tue, Dec 29, 5:06 PM.

Details

Reviewers
fhahn
Summary

Current ArgPromotion implementation does not copy it: https://godbolt.org/z/zzTKof

Diff Detail

Event Timeline

wecing created this revision.Tue, Dec 29, 5:06 PM
wecing requested review of this revision.Tue, Dec 29, 5:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Dec 29, 5:06 PM
fhahn added a comment.Thu, Jan 7, 6:12 AM

This looks reasonable to me. The load gets only moved, exactly the same value should get loaded. What about other metadata on loads?

wecing updated this revision to Diff 315275.Thu, Jan 7, 4:38 PM

Copy all metadata.

ping -- @fhahn , does the new change look reasonable to you?