Page MenuHomePhabricator

tejohnson (Teresa Johnson)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 27 2015, 11:17 AM (351 w, 1 d)

Recent Activity

Yesterday

tejohnson added inline comments to D117244: [llvm-dis] Add an option `dump-thinlto-index-only` in llvm-dis to read ThinLTO minimized code only..
Tue, Jan 18, 5:56 PM · Restricted Project
tejohnson accepted D117067: [Bitcode] Mention that a multi-module bitcode is valid, each module has exactly one MODULE_BLOCK block.

lgtm

Tue, Jan 18, 5:39 PM · Restricted Project

Sun, Jan 16

tejohnson added inline comments to D116784: [ProfileData] Read and symbolize raw memprof profiles..
Sun, Jan 16, 7:11 AM · Restricted Project

Sat, Jan 15

tejohnson accepted D116783: [memprof] Print out the summary in YAML format..

lgtm

Sat, Jan 15, 12:59 PM · Restricted Project
tejohnson added a comment to D117256: [memprof] Introduce a wrapper around MemInfoBlock..

lgtm but I think it would be nice to split into 2 patches, i.e. first the rename, which unfortunately does cause a little bit of extra churn on your end. But then it makes the new wrapper and inc file changes a little cleaner.

Sat, Jan 15, 12:54 PM · Restricted Project, Restricted Project

Fri, Jan 14

tejohnson added inline comments to D117244: [llvm-dis] Add an option `dump-thinlto-index-only` in llvm-dis to read ThinLTO minimized code only..
Fri, Jan 14, 4:12 PM · Restricted Project
tejohnson added a comment to D117067: [Bitcode] Mention that a multi-module bitcode is valid, each module has exactly one MODULE_BLOCK block.

lgtm on the documentation change but that should be submitted separately as it is unrelated to the code fix.
The other change lgtm but if it is feasible to add a test that would be ideal.

Fri, Jan 14, 3:35 PM · Restricted Project

Tue, Jan 11

tejohnson added a comment to D116995: [gold] Ignore bitcode from sections inside object files.

A few comments and questions.

Tue, Jan 11, 9:40 AM · Restricted Project

Mon, Jan 10

tejohnson added inline comments to D116784: [ProfileData] Read and symbolize raw memprof profiles..
Mon, Jan 10, 10:41 AM · Restricted Project

Fri, Jan 7

tejohnson added a comment to D116783: [memprof] Print out the summary in YAML format..

PTAL, thanks!

I would really like to have a test to ensure that the YAML we generate is valid but it seems hard to implement without defining a document type to parse into as a unittest (see https://llvm.org/docs/YamlIO.html#input). Alternatively, I could also extend the lit based test to check if YAML is available like this usage in MLIR (https://git.io/J9ORA). Any suggestions?

Fri, Jan 7, 3:06 PM · Restricted Project
tejohnson added inline comments to D116783: [memprof] Print out the summary in YAML format..
Fri, Jan 7, 8:38 AM · Restricted Project
tejohnson accepted D116781: [DebugInfo] Move the SymbolizableObjectFile header to include/llvm..

lgtm

Fri, Jan 7, 8:29 AM · Restricted Project

Thu, Dec 30

tejohnson accepted D116390: [ELF][LTO] Cache symbol table of lazy BitcodeFile.

Reduced memory usage of the large app I looked at by 64M (0.6%)

Thu, Dec 30, 9:03 AM · Restricted Project

Wed, Dec 29

tejohnson accepted D116367: [ELF][LTO] Call madvise(MADV_DONTNEED) on MemoryBuffer instances.

LGTM with a couple of comment suggestions below.

Wed, Dec 29, 2:21 PM · Restricted Project
tejohnson added a comment to D116367: [ELF][LTO] Call madvise(MADV_DONTNEED) on MemoryBuffer instances.

This can be used by in-process LTO. I haven't tested it yet.

Would it be better to try unconditionally marking all/only the bitcode file memory buffers as MADV_DONTNEED?

(Uploaded the previous diff before seeing your comment.)

Agree. Bitcode files can be completely MADV_DONTNEED even in non --thinlto-index-only mode.
For ELFFileBase files, their section and symbol names are used in non --thinlto-index-only mode and nearly unused in --thinlto-index-only mode.

For the large thin link this change is very close to the same peak RSS reduction as with my change to destroy the buffer objects completely:
Head: 10.7G
Destroy: 8.9G
Don'tNeed: 9.1G

However, when I tried my earlier version which unconditionally freed all the memory buffers, I found that the memory buffer name is used when creating the output indices, which I fixed by saving the name in the InputFile object. Would not doing so with this change cause a time degradation because we will need to pull all these pages back in to get the name from the buffers?

The MemoryBuffer identifier is stored separated from the buffer content, so technically there should be no issue. In my coarse estimate yesterday, I haven't found any time degradation.

I will benchmark this by running more times.

Wed, Dec 29, 1:22 PM · Restricted Project
tejohnson added a comment to D116367: [ELF][LTO] Call madvise(MADV_DONTNEED) on MemoryBuffer instances.

This can be used by in-process LTO. I haven't tested it yet.

Wed, Dec 29, 9:39 AM · Restricted Project

Tue, Dec 21

tejohnson accepted D116056: [LTO][WPD] Ignore unreachable function by analyzing IR..

lgtm

Tue, Dec 21, 6:28 AM · Restricted Project
tejohnson accepted D116071: Simplify WPD test case for hybrid LTO and thinTLO..

lgtm with another possible cleanup noted below.

Tue, Dec 21, 5:50 AM · Restricted Project

Mon, Dec 20

tejohnson added inline comments to D116056: [LTO][WPD] Ignore unreachable function by analyzing IR..
Mon, Dec 20, 3:28 PM · Restricted Project
tejohnson added inline comments to D116054: Avoid duplicating uniqueness in ThinLTO when unique internal linkage names are used.
Mon, Dec 20, 2:28 PM · Restricted Project

Dec 15 2021

tejohnson updated subscribers of D115780: [LTO][WPD] Simplify mustBeUnreachableFunction and test after D115492.

Thanks for the simplifications. This lgtm but please wait for @luna to confirm that the simplified test case fails without the original fix.

Dec 15 2021, 7:33 AM · Restricted Project

Dec 14 2021

tejohnson added inline comments to D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO.
Dec 14 2021, 7:22 PM · Restricted Project, Restricted Project
tejohnson added inline comments to D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO.
Dec 14 2021, 6:14 PM · Restricted Project, Restricted Project
tejohnson accepted D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO.

lgtm with one more test simplification below.

Dec 14 2021, 6:05 PM · Restricted Project, Restricted Project
tejohnson added inline comments to D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO.
Dec 14 2021, 4:26 PM · Restricted Project, Restricted Project
tejohnson accepted D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO.

lgtm after adding a description to test as noted below.

Dec 14 2021, 9:26 AM · Restricted Project, Restricted Project

Dec 13 2021

tejohnson accepted D115417: [LTO] Fix incomplete optimization remarks for dead functions when PreOptModuleHook or PostInternalizeModuleHook is defined.

lgtm

Dec 13 2021, 7:03 PM · Restricted Project
tejohnson added inline comments to D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO.
Dec 13 2021, 6:43 PM · Restricted Project, Restricted Project
tejohnson accepted D115574: [ThinLTO] Fix nondeterministic exit on error..

lgtm with one minor suggestion below.

Dec 13 2021, 9:34 AM · Restricted Project
tejohnson added inline comments to D115574: [ThinLTO] Fix nondeterministic exit on error..
Dec 13 2021, 9:13 AM · Restricted Project

Dec 10 2021

tejohnson added a comment to D115417: [LTO] Fix incomplete optimization remarks for dead functions when PreOptModuleHook or PostInternalizeModuleHook is defined.

In https://reviews.llvm.org/D46376, we add support for optimization remarks to ThinLTO Backend, we call finalizeOptimizationRemarks() when PreOptModuleHook, PostPromoteModuleHook, PostInternalizeModuleHook, PostImportModuleHook is defined.

This patch call finalizeOptimizationRemarks() when PreOptModuleHook or PostInternalizeModuleHook is defined for Regular LTO Backend.

Cause llvm-lto2 does not have an option to define PreOptModuleHook or PreOptModuleHook for Regular LTO Backend, it's hard to write a testcase.

Ah, that would be a good thing to add support for testing in llvm-lto2, but not needed for this patch I think, see below.

I'm glad to send another patch to add an option that defines PreOptModuleHook or PreOptModuleHook for testing in llvm-lto2 :)

Dec 10 2021, 6:20 PM · Restricted Project
tejohnson added a comment to D115417: [LTO] Fix incomplete optimization remarks for dead functions when PreOptModuleHook or PostInternalizeModuleHook is defined.

In https://reviews.llvm.org/D46376, we add support for optimization remarks to ThinLTO Backend, we call finalizeOptimizationRemarks() when PreOptModuleHook, PostPromoteModuleHook, PostInternalizeModuleHook, PostImportModuleHook is defined.

This patch call finalizeOptimizationRemarks() when PreOptModuleHook or PostInternalizeModuleHook is defined for Regular LTO Backend.

Cause llvm-lto2 does not have an option to define PreOptModuleHook or PreOptModuleHook for Regular LTO Backend, it's hard to write a testcase.

Dec 10 2021, 8:37 AM · Restricted Project

Dec 8 2021

tejohnson accepted D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum..

lgtm

Dec 8 2021, 9:48 PM · Restricted Project, Restricted Project
tejohnson added a comment to D115417: [LTO] Fix incomplete optimization remarks for dead functions when PreOptModuleHook or PostInternalizeModuleHook is defined.

This lgtm (looks like ThinLTO already has these calls for each of its hooks). Can you add a test?

Dec 8 2021, 9:27 PM · Restricted Project
tejohnson added inline comments to D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum..
Dec 8 2021, 1:50 PM · Restricted Project, Restricted Project

Dec 3 2021

tejohnson committed rG46282fad060f: [Sanitizer] Use CreateDirectoryA for report dirs (authored by tunz).
[Sanitizer] Use CreateDirectoryA for report dirs
Dec 3 2021, 12:34 PM
tejohnson closed D114760: [Sanitizer] Use CreateDirectoryA for report dirs.
Dec 3 2021, 12:34 PM · Restricted Project
tejohnson added a comment to D114760: [Sanitizer] Use CreateDirectoryA for report dirs.

Kindly ping. Can you commit this to main branch?

Dec 3 2021, 11:34 AM · Restricted Project

Nov 30 2021

tejohnson added inline comments to D114826: [memprof] Align each rawprofile section to 8b..
Nov 30 2021, 4:27 PM · Restricted Project, Restricted Project
tejohnson accepted D114760: [Sanitizer] Use CreateDirectoryA for report dirs.

I see CreateDirectoryA is also used in the Windows fuzzer support.

Nov 30 2021, 10:56 AM · Restricted Project

Nov 29 2021

tejohnson added a comment to D114764: Use `thin` that starts with lowercase letter. - `Thin` gives an error when following https://clang.llvm.org/docs/ThinLTO.html#clang-bootstrap, and `thin` works..

There are some other docs that also use "Thin" (and "Full", etc). I see my own script uses "THIN" for this cmake variable. Looks like we convert to uppercase so I wouldn't think it should matter:
See llvm/cmake/modules/HandleLLVMOptions.cmake:30

Can you clarify what problem you are encountering? I'm not sure I understand the reference to WholeProgramDevirt.cpp in the title.

Thanks for pointing this out! The title should be https://clang.llvm.org/docs/ThinLTO.html#clang-bootstrap (WholeProgramDevirt should be from stale paste board).

I made a mistake in the command; re-run the command works for me [1]; previously I remember seeing flto 'Thin' in the terminal, so must have mixed the clang cmmand and cmake command.

Nov 29 2021, 7:04 PM · Restricted Project
tejohnson added a comment to D114764: Use `thin` that starts with lowercase letter. - `Thin` gives an error when following https://clang.llvm.org/docs/ThinLTO.html#clang-bootstrap, and `thin` works..

There are some other docs that also use "Thin" (and "Full", etc). I see my own script uses "THIN" for this cmake variable. Looks like we convert to uppercase so I wouldn't think it should matter:
See llvm/cmake/modules/HandleLLVMOptions.cmake:30

Nov 29 2021, 6:20 PM · Restricted Project
tejohnson accepted D114286: [memprof] Extend llvm-profdata to display MemProf profile summaries..

lgtm

Nov 29 2021, 5:20 PM · Restricted Project, Restricted Project

Nov 25 2021

tejohnson accepted D114286: [memprof] Extend llvm-profdata to display MemProf profile summaries..

lgtm with a couple of minor comments below (please ignore until after the holiday weekend, forgot to finalize these comments yesterday).

Nov 25 2021, 7:45 AM · Restricted Project, Restricted Project

Nov 19 2021

tejohnson accepted D114285: [memprof] Fix the text format print for live on exit blocks..

lgtm, sorry for the confusion!

Nov 19 2021, 3:58 PM · Restricted Project
tejohnson added inline comments to D114285: [memprof] Fix the text format print for live on exit blocks..
Nov 19 2021, 3:33 PM · Restricted Project
tejohnson added inline comments to D114229: [clang][driver] Always add LTO options when using GNU toolchain.
Nov 19 2021, 7:50 AM · Restricted Project

Nov 11 2021

tejohnson accepted D113617: [memprof] Make the raw binary format the default..

lgtm

Nov 11 2021, 9:59 AM · Restricted Project
tejohnson added inline comments to D113617: [memprof] Make the raw binary format the default..
Nov 11 2021, 9:54 AM · Restricted Project
tejohnson added a comment to D113617: [memprof] Make the raw binary format the default..

Half of the tests (9/18) fail if the default is set to the binary format.

Failed Tests (9):

MemProfiler-x86_64-linux :: TestCases/dump_process_map.cpp
MemProfiler-x86_64-linux :: TestCases/log_path_test.cpp
MemProfiler-x86_64-linux :: TestCases/memprof_merge_mib.cpp
MemProfiler-x86_64-linux :: TestCases/memprof_profile_dump.cpp
MemProfiler-x86_64-linux :: TestCases/test_malloc_load_store.c
MemProfiler-x86_64-linux :: TestCases/test_memintrin.cpp
MemProfiler-x86_64-linux :: TestCases/test_new_load_store.cpp
MemProfiler-x86_64-linux :: TestCases/test_terse.cpp
MemProfiler-x86_64-linux :: TestCases/unaligned_loads_and_stores.cpp
Nov 11 2021, 9:39 AM · Restricted Project
tejohnson added a comment to D113617: [memprof] Make the raw binary format the default..

How many tests would be affected by switching the default?

Nov 11 2021, 6:58 AM · Restricted Project

Nov 10 2021

tejohnson accepted D113317: [memprof] Add a raw binary format to serialize memprof profiles..

lgtm with small fix noted below. Wait to see if @davidxl has more comments too

Nov 10 2021, 3:33 PM · Restricted Project

Nov 9 2021

tejohnson added inline comments to D113317: [memprof] Add a raw binary format to serialize memprof profiles..
Nov 9 2021, 12:52 PM · Restricted Project

Nov 8 2021

tejohnson added inline comments to D113317: [memprof] Add a raw binary format to serialize memprof profiles..
Nov 8 2021, 10:54 AM · Restricted Project

Nov 5 2021

tejohnson accepted D111676: [memprof] Replace the block cache with a hashmap..

lgtm

Nov 5 2021, 2:17 PM · Restricted Project, Restricted Project

Nov 4 2021

tejohnson added a comment to D111676: [memprof] Replace the block cache with a hashmap..

LGTM but looking through the tests I added it looks like I was remiss in adding one that will result in a merge - could you add one with this change?

Nov 4 2021, 1:58 PM · Restricted Project, Restricted Project

Oct 28 2021

tejohnson accepted D112595: [IRSymTab] Mark __stack_chk_guard used.

lgtm

Oct 28 2021, 7:37 AM · Restricted Project

Oct 27 2021

tejohnson added a comment to D112595: [IRSymTab] Mark __stack_chk_guard used.

__stack_chk_guard is a user-defined variable

Can be more accurate. For some architectures glibc define the variable (https://sourceware.org/bugzilla/show_bug.cgi?id=26817)

Yes, I've updated the summary.

There are a couple other symbols handled specially in Internalize.cpp (stack_chk_fail, and ssp_canary_word for AIX), should the all be handled uniformly?

Echo this request. Would'be great to make the logic centralized, but may not be in this patch if you think not fit.

Hmm, I think the only place that needs this logic is IRSymTab; "RuntimeLibcalls.def" and Internalizer cover the rest of the use cases (ThinLTO, legacy LTO API).

Oct 27 2021, 9:16 PM · Restricted Project
tejohnson accepted D112684: [Internalize] Preserve __stack_chk_fail in Internalizer correctly.

lgtm

Oct 27 2021, 8:23 PM · Restricted Project
tejohnson added a comment to D112595: [IRSymTab] Mark __stack_chk_guard used.

Can __stack_chk_fail be removed from llvm/lib/Transforms/IPO/Internalize.cpp?

It would not be removed there. Internalize.cpp preserves both __stack_chk_fail and the guard symbol.

Oct 27 2021, 8:36 AM · Restricted Project

Oct 25 2021

tejohnson accepted D107934: [LowerTypeTests] Emit cfi_jt aliases regardless of function export.

lgtm

Oct 25 2021, 11:24 AM · Restricted Project, Restricted Project
tejohnson added inline comments to D107934: [LowerTypeTests] Emit cfi_jt aliases regardless of function export.
Oct 25 2021, 11:17 AM · Restricted Project, Restricted Project
tejohnson added inline comments to D107934: [LowerTypeTests] Emit cfi_jt aliases regardless of function export.
Oct 25 2021, 10:45 AM · Restricted Project, Restricted Project
tejohnson added inline comments to D107934: [LowerTypeTests] Emit cfi_jt aliases regardless of function export.
Oct 25 2021, 10:42 AM · Restricted Project, Restricted Project

Oct 22 2021

tejohnson added a comment to D112297: [LTO] Fix assertion failed when flushing bitcode incrementally for LTO output..

On default, command line option FlushThreshold is 512(M) defined in llvm/lib/Bitcode/Writer/BitcodeWriter.cpp

static cl::opt<uint32_t> FlushThreshold(
    "bitcode-flush-threshold", cl::Hidden, cl::init(512),
    cl::desc("The threshold (unit M) for flushing LLVM bitcode."));

and AFAIK, there is no command line option for lld to modify FlushThreshold value.

Oct 22 2021, 7:58 AM · Restricted Project
tejohnson added a comment to D112297: [LTO] Fix assertion failed when flushing bitcode incrementally for LTO output..

Can you add a test?

Oct 22 2021, 6:35 AM · Restricted Project

Oct 20 2021

tejohnson accepted D112177: [clang] Do not duplicate "EnableSplitLTOUnit" module flag.

lgtm

Oct 20 2021, 1:29 PM · Restricted Project, Restricted Project

Oct 14 2021

tejohnson added a comment to D111676: [memprof] Replace the block cache with a hashmap..

I would recommend you to keep it simple, which is TwoLevelMap.
It requires trivial change to this patch, and you always can recover ForEach if needed. Very likely evolution of memprof will lead you to unexpected places where neither solution is good enough.

I agree that the evolution of memprof will likely outgrow the current choice. I am still in favour of the AddrHashMap extension since it allows us to be not rely on the sequential context id. I will defer to Teresa for making the decision.

Oct 14 2021, 9:10 PM · Restricted Project, Restricted Project
tejohnson accepted D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

lgtm

Oct 14 2021, 1:36 PM · Restricted Project, Restricted Project, Restricted Project

Oct 11 2021

tejohnson accepted D111600: [NFC][LangRef] Update description for FuncFlags.

lgtm, thanks

Oct 11 2021, 9:56 PM · Restricted Project

Oct 9 2021

tejohnson accepted D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

lgtm

Oct 9 2021, 9:06 PM · Restricted Project
tejohnson added inline comments to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.
Oct 9 2021, 7:32 PM · Restricted Project
tejohnson added inline comments to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.
Oct 9 2021, 2:02 PM · Restricted Project

Oct 8 2021

tejohnson added inline comments to D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..
Oct 8 2021, 11:06 PM · Restricted Project, Restricted Project, Restricted Project
tejohnson added a comment to D108438: [Bitstream] Improve the dumpability of bitstream/bitcode headers [NFC].

I don't see any particular issue with refactoring this way, but I'm wondering why you need to be able to dump the AST in order to track changes to the file and values?

Oct 8 2021, 10:31 PM · Restricted Project
tejohnson added inline comments to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.
Oct 8 2021, 9:49 PM · Restricted Project
tejohnson added inline comments to D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..
Oct 8 2021, 10:57 AM · Restricted Project, Restricted Project, Restricted Project
tejohnson added a comment to D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

This lgtm but I agree with @phosek 's suggestion to configure the file prefix and keep it as "Thin" for ThinLTO.

Oct 8 2021, 9:01 AM · Restricted Project, Restricted Project, Restricted Project

Oct 6 2021

tejohnson accepted D111192: [compiler-rt][memprof] Disambiguate checks for __tls_get_addr in output.

lgtm, but I like @MaskRay 's suggested change. I ran it locally and don't see any stack traces that involve __libc_memalign, so perhaps that is only used in some environments. I looked at some documentation and it appears to be dependent on the version of libc used. So that could explain why it is only showing up in some cases.

Oct 6 2021, 12:37 PM · Restricted Project

Sep 30 2021

tejohnson committed rGd047368149dc: [MemProf] Loosen matching of profile data to avoid bot flakes (authored by tejohnson).
[MemProf] Loosen matching of profile data to avoid bot flakes
Sep 30 2021, 9:23 PM
tejohnson committed rG0d8bdc17862e: [MemProf] Record accesses for all words touched in mem intrinsic (authored by tejohnson).
[MemProf] Record accesses for all words touched in mem intrinsic
Sep 30 2021, 3:08 PM
tejohnson closed D110799: [MemProf] Record accesses for all words touched in mem intrinsic.
Sep 30 2021, 3:08 PM · Restricted Project
tejohnson updated the diff for D110799: [MemProf] Record accesses for all words touched in mem intrinsic.

Update comments

Sep 30 2021, 3:08 PM · Restricted Project
tejohnson added inline comments to D110799: [MemProf] Record accesses for all words touched in mem intrinsic.
Sep 30 2021, 3:05 PM · Restricted Project

Sep 29 2021

tejohnson added inline comments to D110799: [MemProf] Record accesses for all words touched in mem intrinsic.
Sep 29 2021, 8:01 PM · Restricted Project
tejohnson requested review of D110799: [MemProf] Record accesses for all words touched in mem intrinsic.
Sep 29 2021, 8:00 PM · Restricted Project
tejohnson added a comment to D110276: Clean up large copies of binaries copied into temp directories in tests.

It's my personal bot. It doesn't send email. IMHO the problem of how to make bots send emails hasn't been solved (they either send too much or too little), so I'm not pretending that it has been ;)

Sadly the test is still failing after the -f change: http://45.33.8.238/win/46139/step_7.txt

Maybe tacking on an || true helps?

Sep 29 2021, 7:25 PM · Restricted Project
tejohnson committed rGb55a964197bd: Second attempt to fix Windows failures from test changes (authored by tejohnson).
Second attempt to fix Windows failures from test changes
Sep 29 2021, 7:25 PM
tejohnson added a comment to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Please add a test. Maybe in llvm/test/tools/llvm-bcanalyzer/ ?

Sep 29 2021, 12:01 PM · Restricted Project
tejohnson accepted D110750: [clang] Fix sentence in the usage section of ThinLTO docs..

lgtm thanks!

Sep 29 2021, 11:57 AM · Restricted Project
tejohnson added a comment to D110276: Clean up large copies of binaries copied into temp directories in tests.

Softlinks don't work on Windows, that's why these tests use copies.

clang_f_opts.c sadly started flaking almost immediately after this went in: http://45.33.8.238/win/46115/step_7.txt

So I fear the Windows file system can't handle this patch as-is.

Maybe we can use rm -f and maybe that way the error isn't fatal even when deleting the file doesn't work, not sure.

I can try submitting a change to make it use rm -f. Is this failure on a bot? I didn't get any bot failure notifications.

Sep 29 2021, 8:03 AM · Restricted Project
tejohnson committed rG2f1b99ca67da: Use rm -f to fix Windows failures from test changes (authored by tejohnson).
Use rm -f to fix Windows failures from test changes
Sep 29 2021, 8:02 AM
tejohnson added a comment to D110276: Clean up large copies of binaries copied into temp directories in tests.

Softlinks don't work on Windows, that's why these tests use copies.

clang_f_opts.c sadly started flaking almost immediately after this went in: http://45.33.8.238/win/46115/step_7.txt

So I fear the Windows file system can't handle this patch as-is.

Maybe we can use rm -f and maybe that way the error isn't fatal even when deleting the file doesn't work, not sure.

Sep 29 2021, 7:56 AM · Restricted Project

Sep 28 2021

tejohnson committed rGd87bdc272ba4: Clean up large copies of binaries copied into temp directories in tests (authored by tejohnson).
Clean up large copies of binaries copied into temp directories in tests
Sep 28 2021, 5:04 PM
tejohnson closed D110276: Clean up large copies of binaries copied into temp directories in tests.
Sep 28 2021, 5:04 PM · Restricted Project
tejohnson added a comment to D110276: Clean up large copies of binaries copied into temp directories in tests.

Is it possible to use soft links instead of copies? It would still be good to clean up afterwards, but if the host won't allow that cleanup in some cases at least we aren't leaving a big file around.

Sep 28 2021, 10:22 AM · Restricted Project

Sep 24 2021

tejohnson committed rGb5bfbb4da252: Fix bot failure by adding needed dependence (authored by tejohnson).
Fix bot failure by adding needed dependence
Sep 24 2021, 12:43 PM
tejohnson committed rG96cb97c4533a: [ThinLTO] Update combined index for SamplePGO indirect calls to locals (authored by tejohnson).
[ThinLTO] Update combined index for SamplePGO indirect calls to locals
Sep 24 2021, 12:30 PM
tejohnson closed D110374: [ThinLTO] Update combined index for SamplePGO indirect calls to locals.
Sep 24 2021, 12:30 PM · Restricted Project
tejohnson updated the diff for D110374: [ThinLTO] Update combined index for SamplePGO indirect calls to locals.

Fix coding style issue

Sep 24 2021, 8:34 AM · Restricted Project