Page MenuHomePhabricator

wecing (Chenguang Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2014, 6:10 PM (319 w, 6 d)

Recent Activity

Fri, Jan 15

wecing added a comment to D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

Sorry about the commit spam.

Fri, Jan 15, 9:43 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

update comment

Fri, Jan 15, 9:37 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

remove unused cast

Fri, Jan 15, 9:34 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

remove unused include

Fri, Jan 15, 8:03 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

include all commits.

Fri, Jan 15, 5:24 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

Include more commits.

Fri, Jan 15, 5:23 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

Update implementation to use local cache and add unit tests.

Fri, Jan 15, 5:20 PM · Restricted Project
wecing updated the summary of D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Fri, Jan 15, 5:20 PM · Restricted Project

Thu, Jan 14

wecing added reviewers for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint: spatel, jdoerfert.
Thu, Jan 14, 5:05 PM · Restricted Project
wecing added a comment to D93927: [ArgPromotion] Copy !range metadata for loads..

ping -- @fhahn , does the new change look reasonable to you?

Thu, Jan 14, 5:00 PM · Restricted Project

Thu, Jan 7

wecing updated the diff for D93927: [ArgPromotion] Copy !range metadata for loads..

Copy all metadata.

Thu, Jan 7, 4:38 PM · Restricted Project
wecing abandoned D94276: copy all metadata.
Thu, Jan 7, 4:37 PM · Restricted Project
wecing requested review of D94276: copy all metadata.
Thu, Jan 7, 4:36 PM · Restricted Project

Wed, Jan 6

wecing added a comment to D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

Ping.

Wed, Jan 6, 4:36 PM · Restricted Project
wecing added a comment to D93927: [ArgPromotion] Copy !range metadata for loads..

Ping.

Wed, Jan 6, 4:35 PM · Restricted Project
wecing added a comment to D93888: [GVN] If zext X == N or sext X == N, then X == trunc N..

For NewGVN and IPSCCP PredicateInfo would have to handle it, and I'm pretty sure we want to avoid that.

@nikic Would you mind explaining why? If there is a good reason we cannot do this in NewGVN then D93850 might be the best we could do.

Wed, Jan 6, 4:30 PM · Restricted Project

Tue, Dec 29

wecing requested review of D93927: [ArgPromotion] Copy !range metadata for loads..
Tue, Dec 29, 5:06 PM · Restricted Project

Mon, Dec 28

wecing added a comment to D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..

@lebedev.ri , I made another patch by changing only GVN -- please take a look at D93888. If it could be approved, I will close this PR ("diff"?).

Mon, Dec 28, 11:33 PM · Restricted Project
wecing added a comment to D93888: [GVN] If zext X == N or sext X == N, then X == trunc N..

I am very confused why NewGVN doesn't seem to propagate switch condition values: https://godbolt.org/z/9a9P51. Some guidance on porting this to NewGVN would be appreciated!

Mon, Dec 28, 11:30 PM · Restricted Project
wecing requested review of D93888: [GVN] If zext X == N or sext X == N, then X == trunc N..
Mon, Dec 28, 11:26 PM · Restricted Project
wecing added a reviewer for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint: courbet.
Mon, Dec 28, 3:22 PM · Restricted Project
wecing updated the summary of D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Mon, Dec 28, 2:57 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Mon, Dec 28, 2:48 PM · Restricted Project
wecing added a comment to D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..

@lebedev.ri , here is what GVN does for the current output, and this is the new behavior. Note that the first one does

Mon, Dec 28, 1:47 PM · Restricted Project
wecing added a comment to D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..

@lebedev.ri , which "hook" did you mean?

Mon, Dec 28, 11:57 AM · Restricted Project
wecing added inline comments to D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..
Mon, Dec 28, 11:32 AM · Restricted Project

Sun, Dec 27

wecing added a comment to D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..

Here is a longer example showing the improvements of this change:

Sun, Dec 27, 10:21 PM · Restricted Project
wecing added a reviewer for D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X).: spatel.
Sun, Dec 27, 9:55 PM · Restricted Project
wecing requested review of D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..
Sun, Dec 27, 9:53 PM · Restricted Project

Dec 10 2014

wecing retitled D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint from to Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Dec 10 2014, 3:44 PM · Restricted Project