Page MenuHomePhabricator
People ormris

ormris (Matthew Voss)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2017, 10:06 AM (167 w, 1 d)

Recent Activity
View All

Aug 19 2020

ormris accepted D86240: [llvm] Add default constructor of `llvm::ElementCount`..

LGTM

Aug 19 2020, 2:14 PM · Restricted Project
ormris added a comment to D86240: [llvm] Add default constructor of `llvm::ElementCount`..

This builds on Windows. Do the comments need to be updated?

Aug 19 2020, 1:29 PM · Restricted Project

May 25 2020

ormris added a comment to D79961: [PGO] Fix computation of fuction Hash.

There's a few test failures related to this change on the PS4 bot. Could you take a look?

May 25 2020, 10:42 AM · Restricted Project, Restricted Project

Jan 14 2020

ormris added a comment to D72405: Allow /D flags absent during PCH creation under msvc-compat.

Hi Zach,

Jan 14 2020, 6:29 PM · Restricted Project

Dec 13 2019

ormris added a comment to D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO.

Ping @tejohnson

Dec 13 2019, 2:32 PM · Restricted Project, Restricted Project

Dec 5 2019

ormris added a comment to D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO.

I've done testing with the following global parameters.

Dec 5 2019, 4:42 PM · Restricted Project, Restricted Project

Nov 14 2019

ormris committed rGe69a7364f233: [llvm-dis] Fix the disable-output flag (authored by ormris).
[llvm-dis] Fix the disable-output flag
Nov 14 2019, 1:38 PM
ormris committed rG141bb5f308fa: Add support for multi-module bitcode files to llvm-dis (authored by ormris).
Add support for multi-module bitcode files to llvm-dis
Nov 14 2019, 10:43 AM
ormris closed D70153: Add support for multi-module bitcode files to llvm-dis.
Nov 14 2019, 10:43 AM · Restricted Project
ormris added inline comments to D70153: Add support for multi-module bitcode files to llvm-dis.
Nov 14 2019, 10:34 AM · Restricted Project
ormris added a comment to D70153: Add support for multi-module bitcode files to llvm-dis.

Thanks for the review! I'll go ahead and commit this.

Nov 14 2019, 10:15 AM · Restricted Project

Nov 12 2019

ormris created D70153: Add support for multi-module bitcode files to llvm-dis.
Nov 12 2019, 5:40 PM · Restricted Project

Sep 23 2019

ormris committed rL372659: Request commit access for ormris.
Request commit access for ormris
Sep 23 2019, 1:50 PM

Sep 6 2019

ormris committed rGc1779194097f: Update lld tests dynamic-list.s and symbol-override.s to use llvm-nm (authored by ormris).
Update lld tests dynamic-list.s and symbol-override.s to use llvm-nm
Sep 6 2019, 3:52 PM
ormris committed rL371267: Update lld tests dynamic-list.s and symbol-override.s to use llvm-nm.
Update lld tests dynamic-list.s and symbol-override.s to use llvm-nm
Sep 6 2019, 3:52 PM

Aug 21 2019

ormris added a comment to D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
Aug 21 2019, 1:14 PM · Restricted Project

Jul 19 2019

ormris committed rG407e8375402f: Revert "Fix asan infinite loop on undefined symbol" (authored by ormris).
Revert "Fix asan infinite loop on undefined symbol"
Jul 19 2019, 2:44 PM
ormris added a reverting change for rG8e46275488ca: Fix asan infinite loop on undefined symbol: rG407e8375402f: Revert "Fix asan infinite loop on undefined symbol".
Jul 19 2019, 2:44 PM
ormris committed rL366618: Revert "Fix asan infinite loop on undefined symbol".
Revert "Fix asan infinite loop on undefined symbol"
Jul 19 2019, 2:41 PM

Jul 18 2019

ormris committed rG892758a52651: [compiler-rt] Complete revert of r366413 (authored by ormris).
[compiler-rt] Complete revert of r366413
Jul 18 2019, 11:43 AM
ormris committed rL366482: [compiler-rt] Complete revert of r366413.
[compiler-rt] Complete revert of r366413
Jul 18 2019, 11:40 AM
ormris committed rG3e93131dd292: Revert "Fix asan infinite loop on undefined symbol" (authored by ormris).
Revert "Fix asan infinite loop on undefined symbol"
Jul 18 2019, 10:45 AM
ormris added a reverting change for rG63719119c78c: Fix asan infinite loop on undefined symbol: rG3e93131dd292: Revert "Fix asan infinite loop on undefined symbol".
Jul 18 2019, 10:44 AM
ormris committed rL366472: Revert "Fix asan infinite loop on undefined symbol".
Revert "Fix asan infinite loop on undefined symbol"
Jul 18 2019, 10:43 AM

Jul 10 2019

ormris committed rG6d1a64e489ec: Revert "[clangd] Filter out non-governed files from broadcast" (authored by ormris).
Revert "[clangd] Filter out non-governed files from broadcast"
Jul 10 2019, 11:18 AM
ormris added a reverting change for rGd5214dfa7b56: [clangd] Filter out non-governed files from broadcast: rG6d1a64e489ec: Revert "[clangd] Filter out non-governed files from broadcast".
Jul 10 2019, 11:18 AM
ormris committed rL365678: Revert "[clangd] Filter out non-governed files from broadcast".
Revert "[clangd] Filter out non-governed files from broadcast"
Jul 10 2019, 11:17 AM

Apr 18 2019

ormris added inline comments to D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path.
Apr 18 2019, 1:21 PM · Restricted Project, Restricted Project
ormris added inline comments to D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path.
Apr 18 2019, 11:41 AM · Restricted Project, Restricted Project

Apr 4 2019

ormris added inline comments to D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database.
Apr 4 2019, 10:47 AM · Restricted Project, Restricted Project

Apr 1 2019

ormris committed rG3c023420d1d0: [NFC][LLD] Specify namespaces explicity to fix build failure on GCC 5 after… (authored by ormris).
[NFC][LLD] Specify namespaces explicity to fix build failure on GCC 5 after…
Apr 1 2019, 12:23 PM
ormris committed rL357421: [NFC][LLD] Specify namespaces explicity to fix build failure on GCC 5 after….
[NFC][LLD] Specify namespaces explicity to fix build failure on GCC 5 after…
Apr 1 2019, 12:23 PM
ormris committed rLLD357421: [NFC][LLD] Specify namespaces explicity to fix build failure on GCC 5 after….
[NFC][LLD] Specify namespaces explicity to fix build failure on GCC 5 after…
Apr 1 2019, 12:23 PM

Mar 20 2019

ormris added inline comments to D59571: [Remarks] Emit a section containing remark diagnostics metadata.
Mar 20 2019, 11:36 AM · Restricted Project
ormris added inline comments to D59571: [Remarks] Emit a section containing remark diagnostics metadata.
Mar 20 2019, 10:26 AM · Restricted Project
ormris added inline comments to D59571: [Remarks] Emit a section containing remark diagnostics metadata.
Mar 20 2019, 9:42 AM · Restricted Project

Mar 8 2019

ormris committed rG1262e52e1623: Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/" (authored by ormris).
Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/"
Mar 8 2019, 12:34 PM
ormris added a reverting change for rG28302c66d258: [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/: rG1262e52e1623: Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/".
Mar 8 2019, 12:34 PM
ormris committed rCXX355725: Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/".
Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/"
Mar 8 2019, 12:34 PM
ormris committed rC355725: Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/".
Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/"
Mar 8 2019, 12:33 PM
ormris committed rCXXA355725: Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/".
Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/"
Mar 8 2019, 12:33 PM
ormris committed rUNW355725: Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/".
Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/"
Mar 8 2019, 12:33 PM
ormris committed rL355725: Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/".
Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/"
Mar 8 2019, 12:33 PM

Feb 26 2019

ormris accepted D58589: [ConstantHoisting] Call cleanup() in ConstantHoistingPass::runImpl to avoid dangling elements in ConstIntInfoVec for new PM.

LGTM. I would wait for one other review before committing.

Feb 26 2019, 9:21 AM · Restricted Project

Feb 25 2019

ormris added inline comments to D58589: [ConstantHoisting] Call cleanup() in ConstantHoistingPass::runImpl to avoid dangling elements in ConstIntInfoVec for new PM.
Feb 25 2019, 10:45 AM · Restricted Project
ormris added inline comments to D58589: [ConstantHoisting] Call cleanup() in ConstantHoistingPass::runImpl to avoid dangling elements in ConstIntInfoVec for new PM.
Feb 25 2019, 10:44 AM · Restricted Project

Feb 19 2019

ormris committed rG0f4367714be7: Revert "Revert "[llvm-objdump] Allow short options without arguments to be… (authored by ormris).
Revert "Revert "[llvm-objdump] Allow short options without arguments to be…
Feb 19 2019, 11:46 AM
ormris committed rL354375: Revert "Revert "[llvm-objdump] Allow short options without arguments to be….
Revert "Revert "[llvm-objdump] Allow short options without arguments to be…
Feb 19 2019, 11:45 AM
ormris closed D57904: [llvm-objdump] Allow short options to be grouped.
Feb 19 2019, 11:45 AM · Restricted Project
ormris added a comment to D57904: [llvm-objdump] Allow short options to be grouped.

Sounds good. Relanding.

Feb 19 2019, 9:24 AM · Restricted Project

Feb 15 2019

ormris added a comment to D57904: [llvm-objdump] Allow short options to be grouped.

Sounds good. Thanks again for the review!

Feb 15 2019, 1:20 PM · Restricted Project
ormris updated the diff for D57904: [llvm-objdump] Allow short options to be grouped.
  • Add grouped cases to tests that use more than one short switch.
Feb 15 2019, 9:24 AM · Restricted Project

Feb 14 2019

ormris added a comment to D57904: [llvm-objdump] Allow short options to be grouped.

Good point. I'll take a look.

Feb 14 2019, 3:00 PM · Restricted Project
ormris requested review of D57904: [llvm-objdump] Allow short options to be grouped.
Feb 14 2019, 11:52 AM · Restricted Project
ormris updated the diff for D57904: [llvm-objdump] Allow short options to be grouped.
  • Limit test to options that are more broadly supported
Feb 14 2019, 11:51 AM · Restricted Project
ormris reopened D57904: [llvm-objdump] Allow short options to be grouped.

Reopening to fix bot failures.

Feb 14 2019, 11:49 AM · Restricted Project

Feb 13 2019

ormris committed rG9cb76856d8a5: Revert "[llvm-objdump] Allow short options without arguments to be grouped" (authored by ormris).
Revert "[llvm-objdump] Allow short options without arguments to be grouped"
Feb 13 2019, 5:42 PM
ormris added a reverting change for rG77e1f27476c8: [llvm-objdump] Allow short options without arguments to be grouped: rG9cb76856d8a5: Revert "[llvm-objdump] Allow short options without arguments to be grouped".
Feb 13 2019, 5:42 PM
ormris committed rL354002: Revert "[llvm-objdump] Allow short options without arguments to be grouped".
Revert "[llvm-objdump] Allow short options without arguments to be grouped"
Feb 13 2019, 5:39 PM
ormris committed rG77e1f27476c8: [llvm-objdump] Allow short options without arguments to be grouped (authored by ormris).
[llvm-objdump] Allow short options without arguments to be grouped
Feb 13 2019, 4:42 PM
ormris committed rL353998: [llvm-objdump] Allow short options without arguments to be grouped.
[llvm-objdump] Allow short options without arguments to be grouped
Feb 13 2019, 4:42 PM
ormris closed D57904: [llvm-objdump] Allow short options to be grouped.
Feb 13 2019, 4:42 PM · Restricted Project
ormris added a comment to D57904: [llvm-objdump] Allow short options to be grouped.

Thanks for the review! I'll go ahead and commit this.

Feb 13 2019, 4:10 PM · Restricted Project
ormris updated the diff for D57904: [llvm-objdump] Allow short options to be grouped.
  • Don't allow options that take arguments to be grouped.
  • Rename df to disassemble-functions.
Feb 13 2019, 3:39 PM · Restricted Project
ormris added inline comments to D57904: [llvm-objdump] Allow short options to be grouped.
Feb 13 2019, 1:32 PM · Restricted Project

Feb 7 2019

ormris added inline comments to D57904: [llvm-objdump] Allow short options to be grouped.
Feb 7 2019, 10:49 AM · Restricted Project
ormris created D57904: [llvm-objdump] Allow short options to be grouped.
Feb 7 2019, 9:39 AM · Restricted Project

Jan 28 2019

ormris updated the diff for D57366: Add zlib feature to compiler-rt lit config.

Update again due to git confusion.

Jan 28 2019, 5:32 PM
ormris retitled D57366: Add zlib feature to compiler-rt lit config from Add zlib feature to compiler-rt to Add zlib feature to compiler-rt lit config.
Jan 28 2019, 5:32 PM
ormris updated the diff for D57366: Add zlib feature to compiler-rt lit config.

Move this change to the top level of compiler-rt lit config.

Jan 28 2019, 5:30 PM
ormris created D57366: Add zlib feature to compiler-rt lit config.
Jan 28 2019, 5:25 PM

Jan 15 2019

ormris added a comment to D54630: Move detection of libc++ include dirs to Driver on MacOS.

Hi Ilya,

Jan 15 2019, 1:09 PM

Dec 19 2018

ormris committed rL349667: [ThinLTO] Remove dllimport attribute from locally defined symbols.
[ThinLTO] Remove dllimport attribute from locally defined symbols
Dec 19 2018, 11:11 AM
ormris closed D55627: [ThinLTO] Remove dllimport attribute from locally defined symbols.
Dec 19 2018, 11:10 AM
ormris added a comment to D55627: [ThinLTO] Remove dllimport attribute from locally defined symbols.

Thanks for the review! I'll go ahead and commit this.

Dec 19 2018, 10:11 AM

Dec 18 2018

ormris updated the diff for D55627: [ThinLTO] Remove dllimport attribute from locally defined symbols.

I've trimmed the patch, as suggested.

Dec 18 2018, 5:10 PM
ormris retitled D55627: [ThinLTO] Remove dllimport attribute from locally defined symbols from [ThinLTO] Change locally defined symbols marked dllimport to dllexport to [ThinLTO] Remove dllimport attribute from locally defined symbols.
Dec 18 2018, 2:23 PM
ormris updated the summary of D55627: [ThinLTO] Remove dllimport attribute from locally defined symbols.
Dec 18 2018, 2:21 PM
ormris updated the diff for D55627: [ThinLTO] Remove dllimport attribute from locally defined symbols.

That makes sense. Here's an updated diff.

Dec 18 2018, 2:20 PM

Dec 12 2018

ormris created D55627: [ThinLTO] Remove dllimport attribute from locally defined symbols.
Dec 12 2018, 4:13 PM

Nov 30 2018

ormris committed rL348028: Expect mixed path separators in FileManagerTest when resolving paths on Win32.
Expect mixed path separators in FileManagerTest when resolving paths on Win32
Nov 30 2018, 11:56 AM
ormris committed rC348028: Expect mixed path separators in FileManagerTest when resolving paths on Win32.
Expect mixed path separators in FileManagerTest when resolving paths on Win32
Nov 30 2018, 11:55 AM

Nov 28 2018

ormris committed rCTE347815: Ensure that test clang-tidy/export-relpath.cpp works with Windows path….
Ensure that test clang-tidy/export-relpath.cpp works with Windows path…
Nov 28 2018, 2:19 PM
ormris committed rL347815: Ensure that test clang-tidy/export-relpath.cpp works with Windows path….
Ensure that test clang-tidy/export-relpath.cpp works with Windows path…
Nov 28 2018, 2:19 PM
ormris committed rCTE347792: Revert "[clang-tools-extra] r347753 - [clangd] Build and test IndexBenchmark in….
Revert "[clang-tools-extra] r347753 - [clangd] Build and test IndexBenchmark in…
Nov 28 2018, 10:51 AM
ormris committed rL347792: Revert "[clang-tools-extra] r347753 - [clangd] Build and test IndexBenchmark in….
Revert "[clang-tools-extra] r347753 - [clangd] Build and test IndexBenchmark in…
Nov 28 2018, 10:51 AM

Nov 19 2018

ormris committed rC347284: Ensure FileManagerTest expects "\\" as path separator on Windows platforms.
Ensure FileManagerTest expects "\\" as path separator on Windows platforms
Nov 19 2018, 7:33 PM
ormris committed rL347284: Ensure FileManagerTest expects "\\" as path separator on Windows platforms.
Ensure FileManagerTest expects "\\" as path separator on Windows platforms
Nov 19 2018, 7:33 PM

Nov 13 2018

ormris committed rL346813: Make the ExpandTilde unit test expect "\" (not "/") on Win32.
Make the ExpandTilde unit test expect "\" (not "/") on Win32
Nov 13 2018, 3:23 PM

Oct 3 2018

ormris committed rL343707: Add template type and value parameter metadata nodes to template variable….
Add template type and value parameter metadata nodes to template variable…
Oct 3 2018, 11:49 AM
ormris committed rL343706: Emit template type and value parameter DIEs for template variables..
Emit template type and value parameter DIEs for template variables.
Oct 3 2018, 11:49 AM
ormris committed rC343707: Add template type and value parameter metadata nodes to template variable….
Add template type and value parameter metadata nodes to template variable…
Oct 3 2018, 11:49 AM
ormris closed D52058: Add template type and value parameter metadata nodes to template variable specializations.
Oct 3 2018, 11:49 AM · debug-info
ormris closed D52057: Emit template type and value parameter DIEs for template variables..
Oct 3 2018, 11:49 AM · debug-info
ormris updated the summary of D52057: Emit template type and value parameter DIEs for template variables..
Oct 3 2018, 11:45 AM · debug-info
ormris updated the summary of D52057: Emit template type and value parameter DIEs for template variables..
Oct 3 2018, 11:42 AM · debug-info
ormris updated the summary of D46138: Emit template type and value parameter DIEs for template variables..
Oct 3 2018, 11:42 AM
ormris retitled D52058: Add template type and value parameter metadata nodes to template variable specializations from Add Parameters to DW_AT_name Attribute of Template Variables to Add template type and value parameter metadata nodes to template variable specializations.
Oct 3 2018, 11:42 AM · debug-info
ormris added a comment to D52058: Add template type and value parameter metadata nodes to template variable specializations.

Thanks! I'll go ahead and commit this.

Oct 3 2018, 9:40 AM · debug-info

Oct 2 2018

ormris added a comment to D52058: Add template type and value parameter metadata nodes to template variable specializations.

Ping Ping

Oct 2 2018, 9:35 AM · debug-info