User Details
- User Since
- Jul 12 2017, 10:06 AM (196 w, 2 d)
Tue, Apr 13
@hoyFB wrote:
@ormris I'd like to follow up on this. We had a similar change internally which led up to some gains when combined with SPGO, and we'd like to help move forward with this patch here. Would you mind sharing the plan or progress on your side? Thanks!
Sorry for the late reply. Unfortunately, we weren't able to get very far beyond the experiments you see here. Feel free to take it from here.
Tue, Mar 23
LGTM
Feb 23 2021
Feb 19 2021
ping
Feb 18 2021
- Change initial value to -1 to avoid false warnings.
Feb 4 2021
ping
Jan 27 2021
- Update in-pass check to detect all duplicates
- Remove duplicate from MemOp pass test case
- Change warning to "Invalid profile"
Jan 26 2021
- Add in-pass profile data check
- Change error to warning in llvm-profdata
- Update tests
Jan 15 2021
OK. That makes sense. I'll go ahead and update the patch.
Jan 14 2021
ping
Jan 8 2021
Thanks!
Jan 7 2021
ping ping ping
Dec 17 2020
ping ping
Dec 11 2020
ping
Dec 2 2020
I would rather to fix this in the memop size transformation -- to detect this in the heuristic.
Nov 30 2020
Nov 24 2020
Aug 19 2020
LGTM
This builds on Windows. Do the comments need to be updated?
May 25 2020
There's a few test failures related to this change on the PS4 bot. Could you take a look?
Jan 14 2020
Hi Zach,
Dec 13 2019
Ping @tejohnson
Dec 5 2019
I've done testing with the following global parameters.
Nov 14 2019
Thanks for the review! I'll go ahead and commit this.
Nov 12 2019
Sep 23 2019
Sep 6 2019
Aug 21 2019
Jul 19 2019
Jul 18 2019
Jul 10 2019
Apr 18 2019
Apr 4 2019
Apr 1 2019
Mar 20 2019
Mar 8 2019
Feb 26 2019
LGTM. I would wait for one other review before committing.
Feb 25 2019
Feb 19 2019
Sounds good. Relanding.
Feb 15 2019
Sounds good. Thanks again for the review!
- Add grouped cases to tests that use more than one short switch.
Feb 14 2019
Good point. I'll take a look.
- Limit test to options that are more broadly supported
Reopening to fix bot failures.
Feb 13 2019
Thanks for the review! I'll go ahead and commit this.
- Don't allow options that take arguments to be grouped.
- Rename df to disassemble-functions.
Feb 7 2019
Jan 28 2019
Update again due to git confusion.
Move this change to the top level of compiler-rt lit config.
Jan 15 2019
Hi Ilya,
Dec 19 2018
Thanks for the review! I'll go ahead and commit this.
Dec 18 2018
I've trimmed the patch, as suggested.