Page MenuHomePhabricator

[Flang][openmp][5/5] Make dist_schedule clause part of OmpClause
ClosedPublic

Authored by sameeranjoshi on Dec 21 2020, 9:37 AM.

Details

Summary

After discussion in D93482 we found that the some of the clauses were not
following the common OmpClause convention.

The benefits of using OmpClause:

  • Functionalities from structure checker are mostly aligned to work with llvm::omp::Clause.
  • The unparsing as well can take advantage.
  • Homogeneity with OpenACC and rest of the clauses in OpenMP.
  • Could even generate the parser with TableGen, when there is homogeneity.
  • It becomes confusing when to use flangClass and flangClassValue inside TableGen, if incase we generate parser using TableGen we could have only a single let expression.

This patch makes OmpDistScheduleClause clause part of OmpClause.
The unparse function for OmpDistScheduleClause is adapted since the keyword
and parenthesis are issued by the corresponding unparse function for
parser::OmpClause::DistSchedule.

Diff Detail

Event Timeline

sameeranjoshi created this revision.Dec 21 2020, 9:37 AM
sameeranjoshi requested review of this revision.Dec 21 2020, 9:37 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: sstefan1. · View Herald Transcript
This revision is now accepted and ready to land.Dec 21 2020, 9:41 AM
sameeranjoshi added a project: Restricted Project.Dec 21 2020, 9:44 AM