clangd actions have various naming schemes, the most
common being PascalCase. This commit applies PascalCase
to all clangd actions, and fix the status rendering
in renderTUAction to look more consistent.
Details
- Reviewers
sammccall - Commits
- rG3fa2d37eb3f8: [clangd][NFC] Improve clangd status messages
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks! Changes to ClangdServer are definitely good, I'm less sure about renderTUAction.
clang-tools-extra/clangd/TUScheduler.cpp | ||
---|---|---|
1183 | Hmm, I'm not sure if this is more consistent or just different. In vscode I think this currently renders as "clangd: running CallHierarchy", and after this change it's "clangd: Running CallHierarchy". I'm not sure we need a capital letter here? | |
1208 | (if we do change this, this needs to be capitalized too) |
It's up to you - it's easy for me/others to land them on your behalf. Having your own commit access gives you more control, ability to deal with build breakages quickly, fix trivial things without review etc.
clang-format not found in user's PATH; not linting file.