Page MenuHomePhabricator

[openacc] Rename generated file from ACC.cpp.inc to ACC.inc to match D92955
ClosedPublic

Authored by clementval on Dec 17 2020, 12:38 PM.

Details

Summary

This patch rename the tablegen generated file ACC.cpp.inc to ACC.inc in order
to match what was done in D92955. This file is included in header file as well as .cpp
file so it make more sense.

Diff Detail

Event Timeline

clementval created this revision.Dec 17 2020, 12:38 PM
clementval requested review of this revision.Dec 17 2020, 12:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2020, 12:38 PM
clementval added a project: Restricted Project.Dec 18 2020, 7:21 AM
sameeranjoshi accepted this revision.Thu, Jan 14, 7:55 AM

Thank you for the patch.
It was pending since many days.
The changes look good to me from the matching point w.r.t the linked patch.
I couldn't understand still the rational for *.cpp.inc to *.inc for both OMP and OACC, could you please point why was that needed?
Thank you.

This revision is now accepted and ready to land.Thu, Jan 14, 7:55 AM

I couldn't understand still the rational for *.cpp.inc to *.inc for both OMP and OACC, could you please point why was that needed?

Well, when we started with the TableGen code generation we separated definition and declaration but this was not really the way to go and that's why now all code block are generated in a single file. Since this file is included in both headers and .cpp file, .inc is more appropriate.

This revision was landed with ongoing or failed builds.Thu, Jan 14, 11:20 AM
This revision was automatically updated to reflect the committed changes.