Page MenuHomePhabricator

[clang][cli] Create accessors for exception models in LangOptions
ClosedPublic

Authored by jansvoboda11 on Dec 14 2020, 7:09 AM.

Details

Summary

This abstracts away the members that are being replaced in a follow-up patch.

Diff Detail

Unit TestsFailed

TimeTest
890 msx64 debian > libomp.lock::omp_init_lock.c
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/lock/omp_init_lock.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/lock/Output/omp_init_lock.c.tmp -lm -latomic && /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/lock/Output/omp_init_lock.c.tmp
80 msx64 windows > LLVM.CodeGen/XCore::threads.ll
Script: -- : 'RUN: at line 1'; c:\ws\w1\llvm-project\premerge-checks\build\bin\llc.exe -march=xcore < C:\ws\w1\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll | c:\ws\w1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w1\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll

Event Timeline

jansvoboda11 requested review of this revision.Dec 14 2020, 7:09 AM
jansvoboda11 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2020, 7:09 AM
dexonsmith accepted this revision.Dec 14 2020, 10:31 AM

This LGTM, just a whitespace request from clang-format.

clang/lib/Frontend/InitPreprocessor.cpp
760–761

clang-format wants you to update this line.

This revision is now accepted and ready to land.Dec 14 2020, 10:31 AM
jansvoboda11 edited the summary of this revision. (Show Details)Dec 15 2020, 1:15 AM
This revision was landed with ongoing or failed builds.Dec 15 2020, 1:16 AM
This revision was automatically updated to reflect the committed changes.