Page MenuHomePhabricator

jansvoboda11 (Jan Svoboda)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 4 2020, 4:28 AM (37 w, 3 d)

Working on implicitly discovered, explicitly built Clang modules at Apple.

Recent Activity

Fri, Jun 18

jansvoboda11 added a comment to D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

Thanks for working on this, comments inline. @vsapsai @jansvoboda11 @dexonsmith any headermap related concerns on your side?

@jansvoboda11, I think it'd be prudent for us to test this patch out internally before it's landed, since I don't really trust that the existing unit tests cover all the interactions between header maps and modules. Might you be able to coordinate something with @arphaman?

Fri, Jun 18, 7:46 AM · Restricted Project
jansvoboda11 added a comment to D104465: [clang][deps] Prevent PCH validation failures by padding minimized files.

Thanks for sharing your ideas! I've left my initial thoughts below, but I want to revisit this and think about it some more.

Fri, Jun 18, 7:45 AM · Restricted Project
jansvoboda11 planned changes to D104536: WIP: [clang][deps] Avoid minimizing PCH input files.
Fri, Jun 18, 7:44 AM · Restricted Project
jansvoboda11 requested review of D104536: WIP: [clang][deps] Avoid minimizing PCH input files.
Fri, Jun 18, 7:33 AM · Restricted Project

Thu, Jun 17

jansvoboda11 added a comment to D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

I don't have any comments regarding header maps.

Thu, Jun 17, 8:05 AM · Restricted Project
jansvoboda11 updated the summary of D104465: [clang][deps] Prevent PCH validation failures by padding minimized files.
Thu, Jun 17, 7:51 AM · Restricted Project
jansvoboda11 updated the diff for D104459: [clang][lex] Ensure minimizer output is never larger than input.

Fix assert wording

Thu, Jun 17, 7:46 AM · Restricted Project
jansvoboda11 updated the summary of D104462: [clang][lex] Add minimizer option to pad the output to the input size.
Thu, Jun 17, 7:45 AM · Restricted Project
jansvoboda11 requested review of D104465: [clang][deps] Prevent PCH validation failures by padding minimized files.
Thu, Jun 17, 7:44 AM · Restricted Project
jansvoboda11 abandoned D104460: [clang][lex] NFC: Extract source variable in minimizer tests.

Found a way to do the thing in a follow up with less churn. Sorry for the noise.

Thu, Jun 17, 7:32 AM · Restricted Project
jansvoboda11 requested review of D104462: [clang][lex] Add minimizer option to pad the output to the input size.
Thu, Jun 17, 7:25 AM · Restricted Project
jansvoboda11 requested review of D104460: [clang][lex] NFC: Extract source variable in minimizer tests.
Thu, Jun 17, 6:37 AM · Restricted Project
jansvoboda11 requested review of D104459: [clang][lex] Ensure minimizer output is never larger than input.
Thu, Jun 17, 6:34 AM · Restricted Project
jansvoboda11 added a comment to D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`..

This seems reasonable on first look. Can you add a test that demonstrates the problem this patch solves?

Thu, Jun 17, 6:26 AM · Restricted Project

Mon, Jun 14

jansvoboda11 committed rGf95ff8162721: [clang][deps] NFC: Handle `DependencyOutputOptions` only once (authored by jansvoboda11).
[clang][deps] NFC: Handle `DependencyOutputOptions` only once
Mon, Jun 14, 6:16 AM
jansvoboda11 committed rG85208b96b85f: [clang][deps] NFC: Stop using moved-from object (authored by jansvoboda11).
[clang][deps] NFC: Stop using moved-from object
Mon, Jun 14, 6:16 AM
jansvoboda11 closed D104104: [clang][deps] NFC: Handle `DependencyOutputOptions` only once.
Mon, Jun 14, 6:16 AM · Restricted Project
jansvoboda11 closed D104106: [clang][deps] NFC: Stop using moved-from object.
Mon, Jun 14, 6:16 AM · Restricted Project
jansvoboda11 committed rGf39dcf85f994: [clang][deps] NFC: Fix an XFAIL test on Windows (authored by jansvoboda11).
[clang][deps] NFC: Fix an XFAIL test on Windows
Mon, Jun 14, 5:37 AM
jansvoboda11 added a comment to D104036: [clang][deps] Prevent unintended modifications of the original TU command-line.

Either this or your concurrent commit broke check-clang: http://45.33.8.238/linux/48839/step_7.txt

Please take a look and revert for now if it takes a while to fix.

Mon, Jun 14, 5:20 AM · Restricted Project
jansvoboda11 committed rG80c0c639687e: [clang][deps] Prevent unintended modifications of the original TU command-line (authored by jansvoboda11).
[clang][deps] Prevent unintended modifications of the original TU command-line
Mon, Jun 14, 5:05 AM
jansvoboda11 committed rG41115efca642: [clang][deps] NFC: Check the correct context hashes in tests (authored by jansvoboda11).
[clang][deps] NFC: Check the correct context hashes in tests
Mon, Jun 14, 5:05 AM
jansvoboda11 closed D104036: [clang][deps] Prevent unintended modifications of the original TU command-line.
Mon, Jun 14, 5:05 AM · Restricted Project
jansvoboda11 added inline comments to D104036: [clang][deps] Prevent unintended modifications of the original TU command-line.
Mon, Jun 14, 4:29 AM · Restricted Project
jansvoboda11 committed rG1d8882b5e44e: [clang][deps] Fix failing modules.cpp test (authored by jansvoboda11).
[clang][deps] Fix failing modules.cpp test
Mon, Jun 14, 3:56 AM
jansvoboda11 committed rG6c6dcfc4ce75: [clang][deps] Move enabling system header deps from `clang-scan-deps` to… (authored by jansvoboda11).
[clang][deps] Move enabling system header deps from `clang-scan-deps` to…
Mon, Jun 14, 3:24 AM
jansvoboda11 committed rGcf7d9704688d: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to… (authored by jansvoboda11).
[clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to…
Mon, Jun 14, 3:24 AM
jansvoboda11 committed rGd8bab69ead22: [clang][deps] Move invocation adjustments from `clang-scan-deps` to… (authored by jansvoboda11).
[clang][deps] Move invocation adjustments from `clang-scan-deps` to…
Mon, Jun 14, 3:23 AM
jansvoboda11 closed D104033: [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library.
Mon, Jun 14, 3:23 AM · Restricted Project
jansvoboda11 committed rG35fa3e60d161: [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps`… (authored by jansvoboda11).
[clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps`…
Mon, Jun 14, 3:23 AM
jansvoboda11 closed D104031: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library.
Mon, Jun 14, 3:23 AM · Restricted Project
jansvoboda11 closed D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library.
Mon, Jun 14, 3:23 AM · Restricted Project
jansvoboda11 closed D104012: [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps` to `DependencyScanning` library.
Mon, Jun 14, 3:23 AM · Restricted Project
jansvoboda11 raised a concern with rG673c5ba58497: [clang-format] Adds a formatter for aligning arrays of structs.

This causes a bunch of build bot failures:

Mon, Jun 14, 3:18 AM
jansvoboda11 committed rG4629554f0b66: [clang][deps] Handle modular dependencies present in PCH (authored by jansvoboda11).
[clang][deps] Handle modular dependencies present in PCH
Mon, Jun 14, 3:01 AM
jansvoboda11 closed D103526: [clang][deps] Handle modular dependencies present in PCH.
Mon, Jun 14, 3:01 AM · Restricted Project
jansvoboda11 committed rG9223209be11e: [clang][deps] Handle precompiled headers' AST files (authored by jansvoboda11).
[clang][deps] Handle precompiled headers' AST files
Mon, Jun 14, 2:29 AM
jansvoboda11 closed D103524: [clang][deps] Handle precompiled headers' AST files.
Mon, Jun 14, 2:29 AM · Restricted Project
jansvoboda11 committed rG78668c822af9: [clang][modules][pch] Allow loading PCH with different modules cache path (authored by jansvoboda11).
[clang][modules][pch] Allow loading PCH with different modules cache path
Mon, Jun 14, 2:05 AM
jansvoboda11 closed D103802: [clang][modules][pch] Allow loading PCH with different modules cache path.
Mon, Jun 14, 2:05 AM · Restricted Project
jansvoboda11 added a comment to D103461: [clang][deps] NFC: Preserve the original frontend action.

Okay, LGTM. (Sorry for the delay, I've been out.)

My reason for the FIXME is that we could get rid of bunch of Windows-specific logic by adjusting CompilerInvocation instead.

Please add that motivation to the FIXME itself.

Mon, Jun 14, 1:50 AM · Restricted Project
jansvoboda11 committed rG669771cfe75b: [clang][deps] NFC: Preserve the original frontend action (authored by jansvoboda11).
[clang][deps] NFC: Preserve the original frontend action
Mon, Jun 14, 1:49 AM
jansvoboda11 closed D103461: [clang][deps] NFC: Preserve the original frontend action.
Mon, Jun 14, 1:49 AM · Restricted Project

Fri, Jun 11

jansvoboda11 requested review of D104106: [clang][deps] NFC: Stop using moved-from object.
Fri, Jun 11, 3:47 AM · Restricted Project
jansvoboda11 requested review of D104104: [clang][deps] NFC: Handle `DependencyOutputOptions` only once.
Fri, Jun 11, 3:43 AM · Restricted Project

Thu, Jun 10

jansvoboda11 added a reviewer for D104036: [clang][deps] Prevent unintended modifications of the original TU command-line: arphaman.
Thu, Jun 10, 9:05 AM · Restricted Project
jansvoboda11 updated subscribers of D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library.

FYI @saudi.

Thu, Jun 10, 8:56 AM · Restricted Project
jansvoboda11 updated the summary of D104012: [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps` to `DependencyScanning` library.
Thu, Jun 10, 8:16 AM · Restricted Project
jansvoboda11 updated the summary of D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library.
Thu, Jun 10, 8:13 AM · Restricted Project
jansvoboda11 updated the summary of D104031: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library.
Thu, Jun 10, 8:12 AM · Restricted Project
jansvoboda11 updated the summary of D104033: [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library.
Thu, Jun 10, 8:11 AM · Restricted Project
jansvoboda11 updated the summary of D104036: [clang][deps] Prevent unintended modifications of the original TU command-line.
Thu, Jun 10, 8:00 AM · Restricted Project
jansvoboda11 updated the summary of D104036: [clang][deps] Prevent unintended modifications of the original TU command-line.
Thu, Jun 10, 7:59 AM · Restricted Project
jansvoboda11 requested review of D104036: [clang][deps] Prevent unintended modifications of the original TU command-line.
Thu, Jun 10, 7:54 AM · Restricted Project
jansvoboda11 requested review of D104033: [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library.
Thu, Jun 10, 7:34 AM · Restricted Project
jansvoboda11 requested review of D104031: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library.
Thu, Jun 10, 7:30 AM · Restricted Project
jansvoboda11 updated the summary of D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library.
Thu, Jun 10, 7:26 AM · Restricted Project
jansvoboda11 requested review of D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library.
Thu, Jun 10, 7:21 AM · Restricted Project
jansvoboda11 requested review of D104012: [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps` to `DependencyScanning` library.
Thu, Jun 10, 1:23 AM · Restricted Project

Tue, Jun 8

jansvoboda11 added inline comments to D103526: [clang][deps] Handle modular dependencies present in PCH.
Tue, Jun 8, 4:13 AM · Restricted Project

Mon, Jun 7

jansvoboda11 requested review of D103807: [clang][deps] Ensure deterministic order of TU '-fmodule-file=' arguments.
Mon, Jun 7, 6:09 AM · Restricted Project
jansvoboda11 retitled D103526: [clang][deps] Handle modular dependencies present in PCH from [clang][deps] Mark modules as file deps if they come from PCH to [clang][deps] Handle modular dependencies present in PCH.
Mon, Jun 7, 4:24 AM · Restricted Project
jansvoboda11 updated the diff for D103526: [clang][deps] Handle modular dependencies present in PCH.

Handle case when TU depends on a PCH module

Mon, Jun 7, 4:23 AM · Restricted Project
jansvoboda11 updated the diff for D103802: [clang][modules][pch] Allow loading PCH with different modules cache path.

Remove CC1Option

Mon, Jun 7, 4:20 AM · Restricted Project
jansvoboda11 updated the diff for D103802: [clang][modules][pch] Allow loading PCH with different modules cache path.

Mark as CC1Option

Mon, Jun 7, 4:17 AM · Restricted Project
jansvoboda11 requested review of D103802: [clang][modules][pch] Allow loading PCH with different modules cache path.
Mon, Jun 7, 4:15 AM · Restricted Project

Fri, Jun 4

jansvoboda11 planned changes to D103526: [clang][deps] Handle modular dependencies present in PCH.
Fri, Jun 4, 7:26 AM · Restricted Project
jansvoboda11 committed rGde07b1e84d8d: [clang][deps] Support object files (authored by jansvoboda11).
[clang][deps] Support object files
Fri, Jun 4, 5:59 AM
jansvoboda11 closed D103519: [clang][deps] Support object files.
Fri, Jun 4, 5:58 AM · Restricted Project
jansvoboda11 updated the summary of D103519: [clang][deps] Support object files.
Fri, Jun 4, 5:47 AM · Restricted Project
jansvoboda11 committed rG93a058190cc6: [clang][deps] Add argument for customizing PCM paths (authored by jansvoboda11).
[clang][deps] Add argument for customizing PCM paths
Fri, Jun 4, 5:46 AM
jansvoboda11 closed D103516: [clang][deps] Add argument for customizing PCM paths.
Fri, Jun 4, 5:45 AM · Restricted Project
jansvoboda11 retitled D103516: [clang][deps] Add argument for customizing PCM paths from [clang][deps] Customize PCM path via -build-dir argument to [clang][deps] Add argument for customizing PCM paths.
Fri, Jun 4, 5:03 AM · Restricted Project

Thu, Jun 3

jansvoboda11 retitled D103526: [clang][deps] Handle modular dependencies present in PCH from [clang][deps] Mark modular deps as file deps if they come from PCH to [clang][deps] Mark modules as file deps if they come from PCH.
Thu, Jun 3, 10:49 AM · Restricted Project
jansvoboda11 retitled D103526: [clang][deps] Handle modular dependencies present in PCH from [clang][deps] Mark modular deps to file deps if they come from PCH to [clang][deps] Mark modular deps as file deps if they come from PCH.
Thu, Jun 3, 10:35 AM · Restricted Project

Wed, Jun 2

jansvoboda11 updated the summary of D103526: [clang][deps] Handle modular dependencies present in PCH.
Wed, Jun 2, 8:10 AM · Restricted Project
jansvoboda11 updated the summary of D103524: [clang][deps] Handle precompiled headers' AST files.
Wed, Jun 2, 8:09 AM · Restricted Project
jansvoboda11 updated the summary of D103519: [clang][deps] Support object files.
Wed, Jun 2, 8:09 AM · Restricted Project
jansvoboda11 requested review of D103526: [clang][deps] Handle modular dependencies present in PCH.
Wed, Jun 2, 7:53 AM · Restricted Project
jansvoboda11 requested review of D103524: [clang][deps] Handle precompiled headers' AST files.
Wed, Jun 2, 7:06 AM · Restricted Project
jansvoboda11 requested review of D103519: [clang][deps] Support object files.
Wed, Jun 2, 5:55 AM · Restricted Project
jansvoboda11 added inline comments to D102488: [clang][deps] Prune unused header search paths.
Wed, Jun 2, 5:13 AM · Restricted Project
jansvoboda11 requested review of D103516: [clang][deps] Add argument for customizing PCM paths.
Wed, Jun 2, 5:12 AM · Restricted Project
jansvoboda11 retitled D103461: [clang][deps] NFC: Preserve the original frontend action from [clang][deps] NFC: Do not adjust the original action to [clang][deps] NFC: Preserve the original frontend action.
Wed, Jun 2, 4:46 AM · Restricted Project
jansvoboda11 added a comment to D103461: [clang][deps] NFC: Preserve the original frontend action.

Is there (or could there be) a mode where clang-scan-deps prints out the command-lines it sends to the dependency scanning action (maybe instead of actually scanning), so this could be tested?

Wed, Jun 2, 4:45 AM · Restricted Project
jansvoboda11 updated the diff for D103461: [clang][deps] NFC: Preserve the original frontend action.

Fix whitespace around fixme

Wed, Jun 2, 4:31 AM · Restricted Project

Tue, Jun 1

jansvoboda11 requested review of D103461: [clang][deps] NFC: Preserve the original frontend action.
Tue, Jun 1, 7:19 AM · Restricted Project
jansvoboda11 added a comment to D102923: [clang][lex] Remark for used header search paths.

Yup, seems like something that could be added as a follow up (although probably using the same remark). Is there a good place to leave behind a FIXME?

Tue, Jun 1, 7:09 AM · Restricted Project

Fri, May 28

jansvoboda11 added a comment to D102923: [clang][lex] Remark for used header search paths.

I also wonder how we should handle other things that are found via include paths such as module maps.

Fri, May 28, 7:11 AM · Restricted Project
jansvoboda11 updated the diff for D102923: [clang][lex] Remark for used header search paths.

Fix naming of new functions/variables

Fri, May 28, 7:03 AM · Restricted Project
jansvoboda11 committed rGb76df3235cd0: [clang] NFC: Replace std::pair by a struct in InitHeaderSearch (authored by jansvoboda11).
[clang] NFC: Replace std::pair by a struct in InitHeaderSearch
Fri, May 28, 5:06 AM
jansvoboda11 closed D102924: [clang] NFC: Replace std::pair by a struct in InitHeaderSearch.
Fri, May 28, 5:06 AM · Restricted Project

May 21 2021

jansvoboda11 updated the summary of D102488: [clang][deps] Prune unused header search paths.
May 21 2021, 8:51 AM · Restricted Project
jansvoboda11 updated the summary of D102923: [clang][lex] Remark for used header search paths.
May 21 2021, 8:50 AM · Restricted Project
jansvoboda11 updated the summary of D102923: [clang][lex] Remark for used header search paths.
May 21 2021, 8:49 AM · Restricted Project
jansvoboda11 planned changes to D101758: [clang][modules] Add -cc1 option to backup PCM files.
May 21 2021, 8:44 AM · Restricted Project
jansvoboda11 requested review of D102924: [clang] NFC: Replace std::pair by a struct in InitHeaderSearch.
May 21 2021, 8:44 AM · Restricted Project
jansvoboda11 requested review of D102923: [clang][lex] Remark for used header search paths.
May 21 2021, 8:42 AM · Restricted Project
jansvoboda11 added a comment to D102488: [clang][deps] Prune unused header search paths.

This is now ready for review.

May 21 2021, 8:34 AM · Restricted Project
jansvoboda11 updated the diff for D102488: [clang][deps] Prune unused header search paths.

Split out extra patch

May 21 2021, 8:29 AM · Restricted Project