Page MenuHomePhabricator

jansvoboda11 (Jan Svoboda)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 4 2020, 4:28 AM (8 w, 5 d)

Recent Activity

Tue, Dec 1

jansvoboda11 added a comment to D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

@Bigcheese brought up that if you wanted to mimic the current logic in OptInFFlag that automatically creates the -cc1 option with my current proposal, you'd need to remember to pass it to the right Flags (e.g.: use NegativeFlag<[CC1Option]> when using InvertedByNegativeFlag). My hope is that this could be handled automatically by a thin wrapper around BoolOption.

Tue, Dec 1, 9:19 AM · Restricted Project, Restricted Project
jansvoboda11 accepted D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC.

LGTM

Tue, Dec 1, 8:10 AM
jansvoboda11 accepted D91296: Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost NFC.

LGTM

Tue, Dec 1, 8:07 AM
jansvoboda11 accepted D90893: Support: Change InMemoryFileSystem::addFileNoOwn to take a MemoryBufferRef, NFC.

LGTM

Tue, Dec 1, 8:05 AM · Restricted Project, Restricted Project
jansvoboda11 accepted D90889: Remove RemappedFiles param from ASTUnit::LoadFromASTFile, NFC.

LGTM

Tue, Dec 1, 8:02 AM
jansvoboda11 accepted D90888: Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC.

LGTM

Tue, Dec 1, 8:01 AM · Restricted Project
jansvoboda11 accepted D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager.

LGTM

Tue, Dec 1, 8:00 AM · Restricted Project
jansvoboda11 accepted D90887: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC.

LGTM.

Tue, Dec 1, 8:00 AM · Restricted Project
jansvoboda11 added a comment to D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

I wanted to defer the resolution of the todos after all existing patches (https://reviews.llvm.org/search/query/wPZcRaH7zHgu/#R) are upstreamed to avoid conflicts when rebasing and refactoring. Looking at the patches more closely, only two of them seem to be dealing with boolean flags, so we might as well come up with the right naming convention and put it in a prep patch. Below are my notes and though process.

Tue, Dec 1, 6:00 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

Rebase

Tue, Dec 1, 2:39 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83979: [clang][cli] Port LangOpts option flags to new option parsing system.

Rebase

Tue, Dec 1, 2:39 AM · Restricted Project
jansvoboda11 committed rG398b729243b1: [clang][cli] Port HeaderSearch option flags to new option parsing system (authored by jansvoboda11).
[clang][cli] Port HeaderSearch option flags to new option parsing system
Tue, Dec 1, 1:52 AM
jansvoboda11 closed D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system.
Tue, Dec 1, 1:52 AM · Restricted Project
jansvoboda11 committed rG8e41a688a5b1: [clang][cli] Port DependencyOutput option flags to new option parsing system (authored by jansvoboda11).
[clang][cli] Port DependencyOutput option flags to new option parsing system
Tue, Dec 1, 1:36 AM
jansvoboda11 closed D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system.
Tue, Dec 1, 1:36 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system.

Remove unnecessary std namespace

Tue, Dec 1, 1:18 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG2b84efa00040: [clang][cli] Port Frontend option flags to new option parsing system (authored by jansvoboda11).
[clang][cli] Port Frontend option flags to new option parsing system
Tue, Dec 1, 1:11 AM
jansvoboda11 closed D83697: [clang][cli] Port Frontend option flags to new option parsing system.
Tue, Dec 1, 1:11 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG88ab38449b49: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf (authored by jansvoboda11).
[clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf
Tue, Dec 1, 1:00 AM
jansvoboda11 closed D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf.
Tue, Dec 1, 1:00 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG973843681b9d: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC) (authored by jansvoboda11).
[clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC)
Tue, Dec 1, 12:43 AM
jansvoboda11 closed D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC).
Tue, Dec 1, 12:43 AM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

I'm seeing build failures that might be triggered by this patch: http://lab.llvm.org:8011/#/builders/109/builds/3714

Tue, Dec 1, 12:42 AM · Restricted Project, Restricted Project

Mon, Nov 30

jansvoboda11 accepted D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef.

Left tiny question inline, but LGTM anyways.

Mon, Nov 30, 8:58 AM · Restricted Project
jansvoboda11 accepted D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC.

LGTM.

Mon, Nov 30, 8:48 AM · Restricted Project
jansvoboda11 accepted D90485: Lex: Update Module::findHeader to return FileEntryRef, NFC.

LGTM.

Mon, Nov 30, 8:45 AM · Restricted Project
jansvoboda11 accepted D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC.

LGTM.

Mon, Nov 30, 8:44 AM · Restricted Project
jansvoboda11 updated the diff for D83979: [clang][cli] Port LangOpts option flags to new option parsing system.

Revert accidental changes

Mon, Nov 30, 4:28 AM · Restricted Project
jansvoboda11 updated the diff for D83979: [clang][cli] Port LangOpts option flags to new option parsing system.

Fix formatting

Mon, Nov 30, 3:48 AM · Restricted Project
jansvoboda11 updated the diff for D83979: [clang][cli] Port LangOpts option flags to new option parsing system.

Rebase, move options back, port new options

Mon, Nov 30, 3:42 AM · Restricted Project
jansvoboda11 retitled D83979: [clang][cli] Port LangOpts option flags to new option parsing system from Port LangOpts option flags to new option parsing system to [clang][cli] Port LangOpts option flags to new option parsing system.
Mon, Nov 30, 3:40 AM · Restricted Project
jansvoboda11 commandeered D83979: [clang][cli] Port LangOpts option flags to new option parsing system.

Taking over this patch, as Daniel is no longer involved.

Mon, Nov 30, 3:39 AM · Restricted Project

Fri, Nov 27

jansvoboda11 updated the diff for D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system.

Rebase

Fri, Nov 27, 8:57 AM · Restricted Project
jansvoboda11 updated the summary of D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system.
Fri, Nov 27, 8:46 AM · Restricted Project
jansvoboda11 updated the summary of D83892: [clang][cli] Port CodeGen option flags to new option parsing system.
Fri, Nov 27, 8:45 AM · Restricted Project, Restricted Project
jansvoboda11 updated the summary of D83697: [clang][cli] Port Frontend option flags to new option parsing system.
Fri, Nov 27, 8:45 AM · Restricted Project, Restricted Project
jansvoboda11 updated the summary of D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system.
Fri, Nov 27, 8:29 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system.

Rebase & revert move of options

Fri, Nov 27, 8:23 AM · Restricted Project
jansvoboda11 retitled D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system from Port HeaderSearch option flags to new option parsing system to [clang][cli] Port HeaderSearch option flags to new option parsing system.
Fri, Nov 27, 8:22 AM · Restricted Project
jansvoboda11 commandeered D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system.

Taking over this patch as Daniel is no longer involved.

Fri, Nov 27, 8:21 AM · Restricted Project

Thu, Nov 26

jansvoboda11 committed rGa3258566868b: [clang][cli] Port Target option flags to new option parsing system (authored by jansvoboda11).
[clang][cli] Port Target option flags to new option parsing system
Thu, Nov 26, 6:36 AM
jansvoboda11 closed D83698: [clang][cli] Port Target option flags to new option parsing system.
Thu, Nov 26, 6:36 AM · Restricted Project
jansvoboda11 updated the diff for D83698: [clang][cli] Port Target option flags to new option parsing system.

Rebase

Thu, Nov 26, 6:31 AM · Restricted Project
jansvoboda11 updated the diff for D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC).

Undo whitespace change

Thu, Nov 26, 5:17 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC).

Remove lifetime comment

Thu, Nov 26, 5:15 AM · Restricted Project, Restricted Project
jansvoboda11 retitled D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC) from Factor out call to EXTRACTOR in generateCC1CommandLine to [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC).
Thu, Nov 26, 5:12 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC).

Implement review feedback

Thu, Nov 26, 5:12 AM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

This is now ready to be reviewed. If you see a deleted option in the diff, it's either because it was moved closer to its counterpart, or because it's now generated by a multiclass.
I've added a bunch of TODOs I plan to address in a future patch, most of them aim to compress two options into a single multiclass that describes their relationship (e.g. OptOutPositiveFlag).
I'd like to make OptInFFlag et al. modular with something like OptInFlag that does not imply Flags<[CC1Option]> and Group<f_Group> and can be marked with IsPositive or IsNegative.

Thu, Nov 26, 1:04 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

Revert accidental help change, do not AlwaysEmit

Thu, Nov 26, 12:57 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

Remove whitespace change

Thu, Nov 26, 12:23 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

Port AAPCS flags, add tests

Thu, Nov 26, 12:03 AM · Restricted Project, Restricted Project

Wed, Nov 25

jansvoboda11 updated the diff for D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

Add squashed commits

Wed, Nov 25, 4:12 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

Introduce OptOutPositiveFFlag, simplify a couple of boolean options with multiclasses

Wed, Nov 25, 4:11 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

Rebase, undo unnecessary moves, port recently added options, add TODOs (WIP)

Wed, Nov 25, 1:02 AM · Restricted Project, Restricted Project
jansvoboda11 retitled D83892: [clang][cli] Port CodeGen option flags to new option parsing system from Port CodeGen option flags to new option parsing system to [clang][cli] Port CodeGen option flags to new option parsing system.
Wed, Nov 25, 12:43 AM · Restricted Project, Restricted Project
jansvoboda11 added a reviewer for D83892: [clang][cli] Port CodeGen option flags to new option parsing system: dexonsmith.
Wed, Nov 25, 12:42 AM · Restricted Project, Restricted Project
jansvoboda11 commandeered D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

Taking over this patch as Daniel is no longer involved.

Wed, Nov 25, 12:41 AM · Restricted Project, Restricted Project

Tue, Nov 24

jansvoboda11 updated the diff for D83698: [clang][cli] Port Target option flags to new option parsing system.

Undo moving of options (NFC) & rebase

Tue, Nov 24, 3:49 AM · Restricted Project
jansvoboda11 retitled D83698: [clang][cli] Port Target option flags to new option parsing system from Port Target option flags to new option parsing system to [clang][cli] Port Target option flags to new option parsing system.
Tue, Nov 24, 3:47 AM · Restricted Project
jansvoboda11 commandeered D83698: [clang][cli] Port Target option flags to new option parsing system.

Taking over this patch as Daniel is no longer involved.

Tue, Nov 24, 3:47 AM · Restricted Project

Mon, Nov 23

jansvoboda11 added inline comments to D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC).
Mon, Nov 23, 5:43 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83697: [clang][cli] Port Frontend option flags to new option parsing system.

Drop namespace specifier & names of unused args, add tests

Mon, Nov 23, 4:52 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system.

Rebase

Mon, Nov 23, 4:13 AM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system.

Addressed review feedback.

Mon, Nov 23, 4:07 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system.

Reduce template instantiations, remove names of unused parameters

Mon, Nov 23, 4:05 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf.

Add tests, fix condition in generator

Mon, Nov 23, 3:29 AM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf.

Thanks for the feedback. I left some comments inline and will update the patch accordingly.

Mon, Nov 23, 3:08 AM · Restricted Project, Restricted Project

Fri, Nov 20

jansvoboda11 retitled D83697: [clang][cli] Port Frontend option flags to new option parsing system from Port Frontend option flags to new option parsing system to [clang][cli] Port Frontend option flags to new option parsing system.
Fri, Nov 20, 6:06 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83697: [clang][cli] Port Frontend option flags to new option parsing system.

Rebase, undo move of options, implement IsNegative.

Fri, Nov 20, 6:04 AM · Restricted Project, Restricted Project
jansvoboda11 commandeered D83697: [clang][cli] Port Frontend option flags to new option parsing system.

Taking over this patch as Daniel is no longer involved.

Fri, Nov 20, 6:02 AM · Restricted Project, Restricted Project
jansvoboda11 added inline comments to D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system.
Fri, Nov 20, 5:19 AM · Restricted Project, Restricted Project
jansvoboda11 retitled D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system from Port DependencyOutput option flags to new option parsing system to [clang][cli] Port DependencyOutput option flags to new option parsing system.
Fri, Nov 20, 5:14 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system.

Rebase, undo the move of options, introduce makeFlagToValueNormalizer

Fri, Nov 20, 5:13 AM · Restricted Project, Restricted Project
jansvoboda11 commandeered D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system.

Taking over this revision as Daniel is no longer involved.

Fri, Nov 20, 5:05 AM · Restricted Project, Restricted Project
jansvoboda11 updated the summary of D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf.
Fri, Nov 20, 4:36 AM · Restricted Project, Restricted Project
jansvoboda11 added reviewers for D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf: dexonsmith, Bigcheese.
Fri, Nov 20, 4:34 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf.
Fri, Nov 20, 4:28 AM · Restricted Project, Restricted Project

Thu, Nov 19

jansvoboda11 committed rG7a0ea120e2a1: [clang][cli] Port analyzer flags to new option parsing system (authored by jansvoboda11).
[clang][cli] Port analyzer flags to new option parsing system
Thu, Nov 19, 6:43 AM
jansvoboda11 closed D83693: Port analyzer flags to new option parsing system.
Thu, Nov 19, 6:43 AM · Restricted Project
jansvoboda11 committed rGa1702a297b8b: [clang][cli] Port Comment option flags to new parsing system (authored by jansvoboda11).
[clang][cli] Port Comment option flags to new parsing system
Thu, Nov 19, 6:31 AM
jansvoboda11 closed D83691: Port Comment option flags to new parsing system.
Thu, Nov 19, 6:31 AM · Restricted Project
jansvoboda11 added a comment to D83691: Port Comment option flags to new parsing system.

Thanks. Committing this without the NFC change.

Thu, Nov 19, 6:23 AM · Restricted Project

Wed, Nov 18

jansvoboda11 added a comment to D83693: Port analyzer flags to new option parsing system.

WDYT @Bigcheese?

Wed, Nov 18, 4:21 AM · Restricted Project
jansvoboda11 updated the diff for D83693: Port analyzer flags to new option parsing system.

Rebase

Wed, Nov 18, 4:21 AM · Restricted Project
jansvoboda11 commandeered D83693: Port analyzer flags to new option parsing system.

Taking over this patch, as Daniel is no longer involved.

Wed, Nov 18, 4:20 AM · Restricted Project
jansvoboda11 added a comment to D83691: Port Comment option flags to new parsing system.

WDYT @Bigcheese?

Wed, Nov 18, 4:05 AM · Restricted Project
jansvoboda11 updated the diff for D83691: Port Comment option flags to new parsing system.

Rebase

Wed, Nov 18, 4:05 AM · Restricted Project
jansvoboda11 commandeered D83691: Port Comment option flags to new parsing system.

Taking over this patch, as Daniel is no longer involved.

Wed, Nov 18, 4:04 AM · Restricted Project
jansvoboda11 updated the diff for D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC).

Rebase

Wed, Nov 18, 3:31 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG1e6fc2fa532c: [clang][cli] Port Migrator option flags to new option parsing system (authored by jansvoboda11).
[clang][cli] Port Migrator option flags to new option parsing system
Wed, Nov 18, 3:19 AM
jansvoboda11 closed D83690: Port Migator option flags to new option parsing system.
Wed, Nov 18, 3:18 AM · Restricted Project
jansvoboda11 commandeered D83690: Port Migator option flags to new option parsing system.

Taking over this patch, as Daniel is no longer involved.

Wed, Nov 18, 2:43 AM · Restricted Project
jansvoboda11 committed rG5e696d895bde: [clang][cli] Remove NormalizerRetTy and use the decltype of the KeyPath instead (authored by jansvoboda11).
[clang][cli] Remove NormalizerRetTy and use the decltype of the KeyPath instead
Wed, Nov 18, 2:31 AM
jansvoboda11 closed D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead.
Wed, Nov 18, 2:31 AM · Restricted Project, Restricted Project
jansvoboda11 commandeered D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead.

Taking over this patch, as Daniel is no longer involved.

Wed, Nov 18, 2:30 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG05eeda9752b3: [clang][cli] Turn arcmt-* options into a single option (authored by jansvoboda11).
[clang][cli] Turn arcmt-* options into a single option
Wed, Nov 18, 1:54 AM
jansvoboda11 closed D83315: Turn arcmt-* options into a single option.
Wed, Nov 18, 1:54 AM · Restricted Project, Restricted Project
jansvoboda11 commandeered D83315: Turn arcmt-* options into a single option.

Taking over this patch, as Daniel is no longer involved.

Wed, Nov 18, 1:42 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG2be569870486: [clang][cli] Add ability to make fixups to CompilerInvocation after option… (authored by jansvoboda11).
[clang][cli] Add ability to make fixups to CompilerInvocation after option…
Wed, Nov 18, 1:38 AM
jansvoboda11 closed D83298: Add ability to make fixups to CompilerInvocation after option parsing.
Wed, Nov 18, 1:38 AM · Restricted Project