Page MenuHomePhabricator

aheejin (Heejin Ahn)
Bot

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2016, 12:33 AM (234 w, 5 d)

Recent Activity

Wed, Jan 20

aheejin accepted D95012: [WebAssembly] Prototype new f64x2 conversions.
Wed, Jan 20, 6:10 AM · Restricted Project, Restricted Project

Tue, Jan 19

aheejin updated the diff for D94049: [WebAssembly] Fix catch unwind mismatches.

rebase

Tue, Jan 19, 3:47 AM · Restricted Project
aheejin updated the diff for D94048: [WebAssembly] Fix call unwind mismatches.

Add a missing LABEL line

Tue, Jan 19, 3:36 AM · Restricted Project
aheejin updated the diff for D94048: [WebAssembly] Fix call unwind mismatches.

Add test + Merge two RUN lines into one

Tue, Jan 19, 3:26 AM · Restricted Project

Mon, Jan 18

aheejin added inline comments to D94049: [WebAssembly] Fix catch unwind mismatches.
Mon, Jan 18, 8:54 AM · Restricted Project
aheejin updated the diff for D94049: [WebAssembly] Fix catch unwind mismatches.
  • Address comments
Mon, Jan 18, 8:54 AM · Restricted Project

Fri, Jan 15

aheejin updated the diff for D94048: [WebAssembly] Fix call unwind mismatches.
  • Address comments + change delegate's opcode
Fri, Jan 15, 9:05 AM · Restricted Project
aheejin added a comment to D94048: [WebAssembly] Fix call unwind mismatches.

Thanks for the review, and sorry for delayed reply.

Fri, Jan 15, 9:05 AM · Restricted Project

Tue, Jan 12

aheejin committed rGc93b95593907: [WebAssembly] Remove more unnecessary brs in CFGStackify (authored by aheejin).
[WebAssembly] Remove more unnecessary brs in CFGStackify
Tue, Jan 12, 1:18 AM
aheejin closed D94047: [WebAssembly] Remove more unnecessary brs in CFGStackify.
Tue, Jan 12, 1:18 AM · Restricted Project
aheejin committed rG1cc5235712f2: [WebAssembly] Misc. refactoring in CFGStackify (NFC) (authored by aheejin).
[WebAssembly] Misc. refactoring in CFGStackify (NFC)
Tue, Jan 12, 12:40 AM
aheejin closed D94046: [WebAssembly] Misc. refactoring in CFGStackify (NFC).
Tue, Jan 12, 12:39 AM · Restricted Project

Mon, Jan 11

aheejin committed rG9f8b25769efa: [WebAssembly] Ensure terminate pads are a single BB (authored by aheejin).
[WebAssembly] Ensure terminate pads are a single BB
Mon, Jan 11, 5:55 PM
aheejin closed D94045: [WebAssembly] Ensure terminate pads are a single BB.
Mon, Jan 11, 5:55 PM · Restricted Project

Sat, Jan 9

aheejin updated the diff for D94047: [WebAssembly] Remove more unnecessary brs in CFGStackify.

Address comments

Sat, Jan 9, 10:53 PM · Restricted Project
aheejin updated the diff for D94045: [WebAssembly] Ensure terminate pads are a single BB.

Fix duplicate __clang_call_terminate call case

Sat, Jan 9, 10:27 PM · Restricted Project
aheejin added inline comments to D94045: [WebAssembly] Ensure terminate pads are a single BB.
Sat, Jan 9, 10:27 PM · Restricted Project
aheejin added inline comments to D94045: [WebAssembly] Ensure terminate pads are a single BB.
Sat, Jan 9, 4:40 AM · Restricted Project
aheejin committed rG4e4df1e38d6b: [WebAssembly] Remove unreachable EH pads (authored by aheejin).
[WebAssembly] Remove unreachable EH pads
Sat, Jan 9, 3:43 AM
aheejin closed D94044: [WebAssembly] Remove unreachable EH pads.
Sat, Jan 9, 3:43 AM · Restricted Project
aheejin added inline comments to D94044: [WebAssembly] Remove unreachable EH pads.
Sat, Jan 9, 3:43 AM · Restricted Project
aheejin committed rG0d8dfbb42a7d: [WebAssembly] Update InstPrinter support for EH (authored by aheejin).
[WebAssembly] Update InstPrinter support for EH
Sat, Jan 9, 2:43 AM
aheejin closed D94043: [WebAssembly] Update InstPrinter support for EH.
Sat, Jan 9, 2:43 AM · Restricted Project
aheejin committed rG52e240a0721e: [WebAssembly] Remove exnref and br_on_exn (authored by aheejin).
[WebAssembly] Remove exnref and br_on_exn
Sat, Jan 9, 2:10 AM
aheejin closed D94041: [WebAssembly] Remove exnref and br_on_exn.
Sat, Jan 9, 2:10 AM · Restricted Project
aheejin committed rG9e4eadeb135d: [WebAssembly] Update basic EH instructions for the new spec (authored by aheejin).
[WebAssembly] Update basic EH instructions for the new spec
Sat, Jan 9, 1:49 AM
aheejin closed D94040: [WebAssembly] Update basic EH instructions for the new spec.
Sat, Jan 9, 1:48 AM · Restricted Project
aheejin added inline comments to D94040: [WebAssembly] Update basic EH instructions for the new spec.
Sat, Jan 9, 1:07 AM · Restricted Project
aheejin updated the diff for D94040: [WebAssembly] Update basic EH instructions for the new spec.

CATCH -> CATCH_ALL in comment

Sat, Jan 9, 1:07 AM · Restricted Project

Fri, Jan 8

aheejin committed rG9724c3cff46f: [WebAssembly] Update WasmEHPrepare for the new spec (authored by aheejin).
[WebAssembly] Update WasmEHPrepare for the new spec
Fri, Jan 8, 11:57 PM
aheejin closed D94039: [WebAssembly] Update WasmEHPrepare for the new spec.
Fri, Jan 8, 11:57 PM · Restricted Project, Restricted Project
aheejin updated the diff for D94039: [WebAssembly] Update WasmEHPrepare for the new spec.

Delete declare void @_ZSt9terminatev()

Fri, Jan 8, 7:23 AM · Restricted Project, Restricted Project
aheejin added a comment to D94039: [WebAssembly] Update WasmEHPrepare for the new spec.

In the description I think "but LLVM does not have a way of that kind of behavior" is missing the word "modeling" => "but LLVM does not have a way of modeling that kind of behavior"

Fri, Jan 8, 7:23 AM · Restricted Project, Restricted Project
aheejin updated the summary of D94039: [WebAssembly] Update WasmEHPrepare for the new spec.
Fri, Jan 8, 7:12 AM · Restricted Project, Restricted Project
aheejin committed rG7be271537e97: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin (authored by aheejin).
[WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin
Fri, Jan 8, 6:55 AM
aheejin closed D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin.
Fri, Jan 8, 6:55 AM · Restricted Project, Restricted Project
aheejin updated the diff for D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin.

Remove an extra word

Fri, Jan 8, 5:58 AM · Restricted Project, Restricted Project
aheejin committed rGd012430eee7d: [WebAssembly] Change label numbers to variables in test (authored by aheejin).
[WebAssembly] Change label numbers to variables in test
Fri, Jan 8, 5:51 AM
aheejin closed D94037: [WebAssembly] Change label numbers to variables in test.
Fri, Jan 8, 5:50 AM · Restricted Project
aheejin added inline comments to D94037: [WebAssembly] Change label numbers to variables in test.
Fri, Jan 8, 5:42 AM · Restricted Project

Mon, Jan 4

aheejin committed rGc4f12a07a44c: [WebAssembly] Remove old SDT_WebAssemblyCalls (NFC) (authored by aheejin).
[WebAssembly] Remove old SDT_WebAssemblyCalls (NFC)
Mon, Jan 4, 4:32 PM
aheejin closed D94036: [WebAssembly] Remove old SDT_WebAssemblyCalls (NFC).
Mon, Jan 4, 4:32 PM · Restricted Project
aheejin requested review of D94051: [WebAssembly] Update InstPrinter and AsmParser for new EH instructions.
Mon, Jan 4, 3:57 PM · Restricted Project
aheejin requested review of D94050: [WebAssembly] Handle EH terminate pads for cleanup.
Mon, Jan 4, 3:56 PM · Restricted Project
aheejin requested review of D94049: [WebAssembly] Fix catch unwind mismatches.
Mon, Jan 4, 3:54 PM · Restricted Project
aheejin requested review of D94048: [WebAssembly] Fix call unwind mismatches.
Mon, Jan 4, 3:53 PM · Restricted Project
aheejin requested review of D94047: [WebAssembly] Remove more unnecessary brs in CFGStackify.
Mon, Jan 4, 3:52 PM · Restricted Project
aheejin requested review of D94046: [WebAssembly] Misc. refactoring in CFGStackify (NFC).
Mon, Jan 4, 3:51 PM · Restricted Project
aheejin requested review of D94045: [WebAssembly] Ensure terminate pads are a single BB.
Mon, Jan 4, 3:50 PM · Restricted Project
aheejin requested review of D94044: [WebAssembly] Remove unreachable EH pads.
Mon, Jan 4, 3:49 PM · Restricted Project
aheejin requested review of D94043: [WebAssembly] Update InstPrinter support for EH.
Mon, Jan 4, 3:47 PM · Restricted Project
aheejin updated the diff for D94041: [WebAssembly] Remove exnref and br_on_exn.

Revert clang-format for MachineValueType.h

Mon, Jan 4, 3:45 PM · Restricted Project
aheejin requested review of D94041: [WebAssembly] Remove exnref and br_on_exn.
Mon, Jan 4, 3:43 PM · Restricted Project
aheejin requested review of D94040: [WebAssembly] Update basic EH instructions for the new spec.
Mon, Jan 4, 3:40 PM · Restricted Project
aheejin requested review of D94039: [WebAssembly] Update WasmEHPrepare for the new spec.
Mon, Jan 4, 3:39 PM · Restricted Project, Restricted Project
aheejin requested review of D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin.
Mon, Jan 4, 3:37 PM · Restricted Project, Restricted Project
aheejin requested review of D94037: [WebAssembly] Change label numbers to variables in test.
Mon, Jan 4, 3:33 PM · Restricted Project
aheejin requested review of D94036: [WebAssembly] Remove old SDT_WebAssemblyCalls (NFC).
Mon, Jan 4, 3:32 PM · Restricted Project

Tue, Dec 29

aheejin added inline comments to D93883: [WebAssembly] Prototype prefetch instructions.
Tue, Dec 29, 2:53 AM · Restricted Project, Restricted Project
aheejin accepted D93883: [WebAssembly] Prototype prefetch instructions.
Tue, Dec 29, 2:51 AM · Restricted Project, Restricted Project

Dec 23 2020

aheejin accepted D93771: [WebAssembly][NFC] Finish cleaning up SIMD tablegen.

Thanks for the explanation! LGTM % the alignment nit

Dec 23 2020, 11:04 PM · Restricted Project
aheejin accepted D93775: [WebAssembly] Prototype extending pairwise add instructions.
Dec 23 2020, 2:57 PM · Restricted Project, Restricted Project
aheejin added a comment to D93771: [WebAssembly][NFC] Finish cleaning up SIMD tablegen.

Nice!

Dec 23 2020, 2:45 PM · Restricted Project

Dec 22 2020

aheejin accepted D93660: [WebAssembly][NFC] Refactor SIMD load/store tablegen defs.

Nice!

Dec 22 2020, 3:36 PM · Restricted Project
aheejin accepted D93722: [WebAssembly][SIMD] Rename shuffle, swizzle, and load_splats.
Dec 22 2020, 1:27 PM · Restricted Project
aheejin added a comment to D93660: [WebAssembly][NFC] Refactor SIMD load/store tablegen defs.

Thanks for the info!

Dec 22 2020, 2:55 AM · Restricted Project

Dec 21 2020

aheejin added a comment to D93660: [WebAssembly][NFC] Refactor SIMD load/store tablegen defs.

Wow, I didn't know we can do OOP in TableGen! (Are these new functionalities?)

Dec 21 2020, 7:04 PM · Restricted Project

Dec 9 2020

aheejin added inline comments to D92840: [WebAssembly] call_indirect causes indirect function table import.
Dec 9 2020, 4:05 PM · Restricted Project
aheejin added inline comments to D92840: [WebAssembly] call_indirect causes indirect function table import.
Dec 9 2020, 2:23 AM · Restricted Project
aheejin added inline comments to D92840: [WebAssembly] call_indirect causes indirect function table import.
Dec 9 2020, 1:28 AM · Restricted Project
aheejin added inline comments to D92840: [WebAssembly] call_indirect causes indirect function table import.
Dec 9 2020, 12:38 AM · Restricted Project

Dec 8 2020

aheejin added a comment to D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode.

Yeah I think that should be fine.

Dec 8 2020, 6:36 PM · Restricted Project
aheejin added inline comments to D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode.
Dec 8 2020, 4:24 PM · Restricted Project

Dec 7 2020

aheejin accepted D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode.

Oh, I see what you mean. LGTM and I don't think we need a more complicated approach at the moment.

Dec 7 2020, 11:18 AM · Restricted Project

Dec 1 2020

aheejin committed rG60653e24b629: [WebAssembly] Support select and block for reference types (authored by aheejin).
[WebAssembly] Support select and block for reference types
Dec 1 2020, 7:24 PM
aheejin closed D92359: [WebAssembly] Support select and block for reference types.
Dec 1 2020, 7:24 PM · Restricted Project
aheejin committed rG6fb88c6cd52b: [lld-macho] Add dependency to DebugInfoDWARF (authored by aheejin).
[lld-macho] Add dependency to DebugInfoDWARF
Dec 1 2020, 7:12 PM

Nov 30 2020

aheejin added inline comments to D92359: [WebAssembly] Support select and block for reference types.
Nov 30 2020, 11:16 PM · Restricted Project
aheejin updated the diff for D92359: [WebAssembly] Support select and block for reference types.

Add missing COPY opcode handling in Peephole

Nov 30 2020, 11:09 PM · Restricted Project
aheejin updated the diff for D92359: [WebAssembly] Support select and block for reference types.

Fix signature

Nov 30 2020, 10:34 PM · Restricted Project
aheejin added a comment to D92359: [WebAssembly] Support select and block for reference types.
Nov 30 2020, 10:27 PM · Restricted Project
aheejin updated the diff for D92359: [WebAssembly] Support select and block for reference types.

Add tests to test reference types in params and results

Nov 30 2020, 10:00 PM · Restricted Project
aheejin added inline comments to D92359: [WebAssembly] Support select and block for reference types.
Nov 30 2020, 8:09 PM · Restricted Project
aheejin updated the diff for D92359: [WebAssembly] Support select and block for reference types.

Fix a typo

Nov 30 2020, 6:28 PM · Restricted Project
aheejin updated the diff for D92359: [WebAssembly] Support select and block for reference types.

Add missing reference types in utility functions

Nov 30 2020, 6:27 PM · Restricted Project
aheejin requested review of D92359: [WebAssembly] Support select and block for reference types.
Nov 30 2020, 5:54 PM · Restricted Project

Nov 18 2020

aheejin committed rG803af31e5b29: [WebAssembly] Support fp reg class in r constraint (authored by snek).
[WebAssembly] Support fp reg class in r constraint
Nov 18 2020, 5:07 PM
aheejin closed D90978: [WebAssembly] Support fp reg class in r constraint.
Nov 18 2020, 5:06 PM · Restricted Project
aheejin added a comment to D91574: [libc++] Simplify how we pick the typeinfo comparison.

I think your CMakeLists.txt broke the green dragon build: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/24893/consoleFull#349140555e9a0fee5-ebcc-4238-a641-c5aa112c323e

It is not obvious to me what the problem is though.

Nov 18 2020, 2:46 PM · Restricted Project
aheejin accepted D90978: [WebAssembly] Support fp reg class in r constraint.

LGTM. Do you have commit access? If not, I can commit this for you. You can also provide your name and email address if you want, so that I can use your info for the commit, as described here: https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator

Nov 18 2020, 2:19 AM · Restricted Project

Nov 13 2020

aheejin committed rG902ea588eab8: [WebAssembly] Rename atomic.notify and *.atomic.wait (authored by aheejin).
[WebAssembly] Rename atomic.notify and *.atomic.wait
Nov 13 2020, 12:05 PM
aheejin closed D91447: [WebAssembly] Rename atomic.notify and *.atomic.wait.
Nov 13 2020, 12:05 PM · Restricted Project, Restricted Project
aheejin committed rG01d871536940: [WebAssembly] Remove a temporarily added RUN line (authored by aheejin).
[WebAssembly] Remove a temporarily added RUN line
Nov 13 2020, 11:57 AM
aheejin closed D91448: [WebAssembly] Remove a temporarily added RUN line.
Nov 13 2020, 11:57 AM · Restricted Project
aheejin requested review of D91448: [WebAssembly] Remove a temporarily added RUN line.
Nov 13 2020, 11:12 AM · Restricted Project
aheejin requested review of D91447: [WebAssembly] Rename atomic.notify and *.atomic.wait.
Nov 13 2020, 11:11 AM · Restricted Project, Restricted Project

Nov 12 2020

aheejin added a comment to D90978: [WebAssembly] Support fp reg class in r constraint.

It seems we have inline asm tests here: https://github.com/llvm/llvm-project/blob/master/llvm/test/CodeGen/WebAssembly/inline-asm.ll

Nov 12 2020, 2:09 PM · Restricted Project

Nov 9 2020

aheejin accepted D91041: [libc++] Remove emscripten handling from exception_fallback.ipp.
Nov 9 2020, 12:42 AM · Restricted Project

Nov 6 2020

aheejin added a comment to D90978: [WebAssembly] Support fp reg class in r constraint.
Nov 6 2020, 3:10 PM · Restricted Project

Nov 3 2020

aheejin committed rG0fca6517118d: [WebAssembly] Don't fold frame offset for global addresses (authored by Julien Jorge <jjorge@quarkslab.com>).
[WebAssembly] Don't fold frame offset for global addresses
Nov 3 2020, 2:57 PM