Page MenuHomePhabricator

aheejin (Heejin Ahn)
Bot

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2016, 12:33 AM (285 w, 5 d)

Recent Activity

Yesterday

aheejin updated the diff for D117610: [WebAssembly] Support Wasm EH + Wasm SjLj.

Add TODO

Tue, Jan 18, 2:33 PM · Restricted Project
aheejin updated the diff for D117610: [WebAssembly] Support Wasm EH + Wasm SjLj.

clang-format

Tue, Jan 18, 2:32 PM · Restricted Project
aheejin requested review of D117610: [WebAssembly] Support Wasm EH + Wasm SjLj.
Tue, Jan 18, 2:31 PM · Restricted Project

Fri, Jan 14

aheejin committed rGc3a68c5d63c6: [SROA] Bail out on PHIs in catchswitch BBs (authored by aheejin).
[SROA] Bail out on PHIs in catchswitch BBs
Fri, Jan 14, 2:55 PM
aheejin closed D117168: [SROA] Bail out on PHIs in catchswitch BBs.
Fri, Jan 14, 2:55 PM · Restricted Project
aheejin added a reviewer for D117168: [SROA] Bail out on PHIs in catchswitch BBs: dschuff.
Fri, Jan 14, 2:16 PM · Restricted Project
aheejin updated the summary of D117168: [SROA] Bail out on PHIs in catchswitch BBs.
Fri, Jan 14, 11:41 AM · Restricted Project

Thu, Jan 13

aheejin updated the diff for D117168: [SROA] Bail out on PHIs in catchswitch BBs.

Add preds comments to test

Thu, Jan 13, 5:19 PM · Restricted Project
aheejin updated the diff for D117168: [SROA] Bail out on PHIs in catchswitch BBs.

Add CHECK-LABEL

Thu, Jan 13, 2:14 PM · Restricted Project
aheejin added inline comments to D117168: [SROA] Bail out on PHIs in catchswitch BBs.
Thu, Jan 13, 1:06 PM · Restricted Project
aheejin updated the diff for D117168: [SROA] Bail out on PHIs in catchswitch BBs.

Add RUN line + checks

Thu, Jan 13, 1:05 PM · Restricted Project

Wed, Jan 12

aheejin updated the summary of D117168: [SROA] Bail out on PHIs in catchswitch BBs.
Wed, Jan 12, 3:39 PM · Restricted Project
aheejin requested review of D117168: [SROA] Bail out on PHIs in catchswitch BBs.
Wed, Jan 12, 3:38 PM · Restricted Project

Tue, Jan 4

aheejin committed rGf2a43f06dd0c: [WebAssembly] Use llvm utility functions in EH/SjLj (authored by aheejin).
[WebAssembly] Use llvm utility functions in EH/SjLj
Tue, Jan 4, 5:48 PM
aheejin closed D116620: [WebAssembly] Use llvm utility functions in EH/SjLj.
Tue, Jan 4, 5:48 PM · Restricted Project
aheejin committed rGf178f61e1dd2: [WebAssembly] Nullify unnecessary setjmp calls (authored by aheejin).
[WebAssembly] Nullify unnecessary setjmp calls
Tue, Jan 4, 5:45 PM
aheejin closed D116619: [WebAssembly] Nullify unnecessary setjmp calls.
Tue, Jan 4, 5:45 PM · Restricted Project
aheejin updated the summary of D116620: [WebAssembly] Use llvm utility functions in EH/SjLj.
Tue, Jan 4, 4:27 PM · Restricted Project
aheejin retitled D116620: [WebAssembly] Use llvm utility functions in EH/SjLj from [WebAssembly] Use llvm utility functions to [WebAssembly] Use llvm utility functions in EH/SjLj.
Tue, Jan 4, 12:47 PM · Restricted Project
aheejin requested review of D116620: [WebAssembly] Use llvm utility functions in EH/SjLj.
Tue, Jan 4, 12:46 PM · Restricted Project
aheejin updated the diff for D116619: [WebAssembly] Nullify unnecessary setjmp calls.

Test fix

Tue, Jan 4, 12:44 PM · Restricted Project
aheejin requested review of D116619: [WebAssembly] Nullify unnecessary setjmp calls.
Tue, Jan 4, 12:42 PM · Restricted Project

Tue, Dec 21

aheejin added inline comments to D116011: [Clang] Own the CommandLineArgs in CodeGenOptions.
Tue, Dec 21, 2:50 PM · Restricted Project, Restricted Project

Dec 16 2021

aheejin committed rG4625b848793f: [WebAssembly] Support clang -fwasm-exceptions for bitcode (authored by aheejin).
[WebAssembly] Support clang -fwasm-exceptions for bitcode
Dec 16 2021, 4:50 PM
aheejin closed D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode.
Dec 16 2021, 4:50 PM · Restricted Project, Restricted Project
aheejin updated the diff for D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode.

Remove an unnecessary include

Dec 16 2021, 4:14 PM · Restricted Project, Restricted Project
aheejin added inline comments to D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode.
Dec 16 2021, 4:14 PM · Restricted Project, Restricted Project
aheejin updated the diff for D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode.

Address comments

Dec 16 2021, 4:12 PM · Restricted Project, Restricted Project
aheejin updated the summary of D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode.
Dec 16 2021, 3:41 PM · Restricted Project, Restricted Project
aheejin updated the diff for D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode.

Revert a function name change

Dec 16 2021, 12:02 PM · Restricted Project, Restricted Project
aheejin updated the summary of D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode.
Dec 16 2021, 11:55 AM · Restricted Project, Restricted Project
aheejin requested review of D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode.
Dec 16 2021, 11:50 AM · Restricted Project, Restricted Project

Oct 15 2021

aheejin added a comment to D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob().

After this patch, -print-stats started erroring out. I filed a bug at https://bugs.llvm.org/show_bug.cgi?id=52193.

Oct 15 2021, 8:15 PM · Restricted Project

Oct 12 2021

aheejin committed rG9261ee32dc41: [WebAssembly] Make EH work with dynamic linking (authored by aheejin).
[WebAssembly] Make EH work with dynamic linking
Oct 12 2021, 11:29 PM
aheejin closed D111388: [WebAssembly] Make EH work with dynamic linking.
Oct 12 2021, 11:29 PM · Restricted Project

Oct 11 2021

aheejin added inline comments to D111388: [WebAssembly] Make EH work with dynamic linking.
Oct 11 2021, 12:15 PM · Restricted Project
aheejin updated the diff for D111388: [WebAssembly] Make EH work with dynamic linking.

Address comments + improve test

Oct 11 2021, 12:15 PM · Restricted Project

Oct 8 2021

aheejin updated the summary of D111388: [WebAssembly] Make EH work with dynamic linking.
Oct 8 2021, 1:19 AM · Restricted Project
aheejin added inline comments to D111388: [WebAssembly] Make EH work with dynamic linking.
Oct 8 2021, 1:17 AM · Restricted Project
aheejin updated the summary of D111388: [WebAssembly] Make EH work with dynamic linking.
Oct 8 2021, 1:15 AM · Restricted Project
aheejin added inline comments to D111388: [WebAssembly] Make EH work with dynamic linking.
Oct 8 2021, 1:12 AM · Restricted Project
aheejin requested review of D111388: [WebAssembly] Make EH work with dynamic linking.
Oct 8 2021, 1:08 AM · Restricted Project

Oct 5 2021

aheejin committed rG3ec1760d91a3: [WebAssembly] Remove WasmTagType (authored by aheejin).
[WebAssembly] Remove WasmTagType
Oct 5 2021, 5:11 PM
aheejin closed D111086: [WebAssembly] Remove WasmTagType.
Oct 5 2021, 5:11 PM · Restricted Project
aheejin added a comment to D111086: [WebAssembly] Remove WasmTagType.

Not sure if the description needs updating after the simplification?

Oct 5 2021, 5:10 PM · Restricted Project
aheejin updated the summary of D111086: [WebAssembly] Remove WasmTagType.
Oct 5 2021, 5:08 PM · Restricted Project
aheejin updated the diff for D111086: [WebAssembly] Remove WasmTagType.

Check if imported function/tag's sig index is within bounds

Oct 5 2021, 4:15 PM · Restricted Project
aheejin added inline comments to D111086: [WebAssembly] Remove WasmTagType.
Oct 5 2021, 4:14 PM · Restricted Project
aheejin updated the diff for D111086: [WebAssembly] Remove WasmTagType.

Rebase onto D111104 and remove WasmObjectFile::tagTypes()

Oct 5 2021, 4:06 PM · Restricted Project
aheejin committed rG9a9ec8e04b6b: [lld][WebAssembly] Remove redundant check for undefined global (NFC) (authored by aheejin).
[lld][WebAssembly] Remove redundant check for undefined global (NFC)
Oct 5 2021, 3:12 PM
aheejin closed D111101: [lld][WebAssembly] Remove redundant check for undefined global (NFC).
Oct 5 2021, 3:11 PM · Restricted Project
aheejin updated the diff for D111101: [lld][WebAssembly] Remove redundant check for undefined global (NFC).

Oops, || -> &&

Oct 5 2021, 3:07 PM · Restricted Project
aheejin updated the diff for D111101: [lld][WebAssembly] Remove redundant check for undefined global (NFC).

Comment fix

Oct 5 2021, 10:59 AM · Restricted Project
aheejin added inline comments to D111101: [lld][WebAssembly] Remove redundant check for undefined global (NFC).
Oct 5 2021, 12:12 AM · Restricted Project
aheejin updated the diff for D111101: [lld][WebAssembly] Remove redundant check for undefined global (NFC).

Address comments

Oct 5 2021, 12:11 AM · Restricted Project
aheejin added inline comments to D111101: [lld][WebAssembly] Remove redundant check for undefined global (NFC).
Oct 5 2021, 12:07 AM · Restricted Project
aheejin added inline comments to D111101: [lld][WebAssembly] Remove redundant check for undefined global (NFC).
Oct 5 2021, 12:04 AM · Restricted Project

Oct 4 2021

aheejin added inline comments to D111086: [WebAssembly] Remove WasmTagType.
Oct 4 2021, 5:00 PM · Restricted Project
aheejin accepted D111104: [Object][WebAssemlby] Report function types (signatures). NFC.

Thanks!

Oct 4 2021, 4:59 PM · Restricted Project
aheejin added inline comments to D111101: [lld][WebAssembly] Remove redundant check for undefined global (NFC).
Oct 4 2021, 4:57 PM · Restricted Project
aheejin added inline comments to D111086: [WebAssembly] Remove WasmTagType.
Oct 4 2021, 4:54 PM · Restricted Project
aheejin added inline comments to D111101: [lld][WebAssembly] Remove redundant check for undefined global (NFC).
Oct 4 2021, 4:40 PM · Restricted Project
aheejin requested review of D111101: [lld][WebAssembly] Remove redundant check for undefined global (NFC).
Oct 4 2021, 3:57 PM · Restricted Project
aheejin added inline comments to D111086: [WebAssembly] Remove WasmTagType.
Oct 4 2021, 2:21 PM · Restricted Project
aheejin updated the diff for D111086: [WebAssembly] Remove WasmTagType.

Make incorrect attribute an error

Oct 4 2021, 12:05 PM · Restricted Project
aheejin updated the summary of D111086: [WebAssembly] Remove WasmTagType.
Oct 4 2021, 11:57 AM · Restricted Project
aheejin requested review of D111086: [WebAssembly] Remove WasmTagType.
Oct 4 2021, 11:52 AM · Restricted Project

Sep 22 2021

aheejin accepted D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions.
Sep 22 2021, 8:43 PM · Restricted Project, Restricted Project

Sep 14 2021

aheejin added a reverting change for rGb7b4ebbcfa46: [WebAssembly] Rethrow longjmp in EH handling if EmSjLj is enabled: rG468c4409f614: Revert "[WebAssembly] Rethrow longjmp in EH handling if EmSjLj is enabled".
Sep 14 2021, 1:00 PM
aheejin committed rG468c4409f614: Revert "[WebAssembly] Rethrow longjmp in EH handling if EmSjLj is enabled" (authored by aheejin).
Revert "[WebAssembly] Rethrow longjmp in EH handling if EmSjLj is enabled"
Sep 14 2021, 1:00 PM
aheejin added a reverting change for D109670: [WebAssembly] Rethrow longjmp in EH handling if EmSjLj is enabled: rG468c4409f614: Revert "[WebAssembly] Rethrow longjmp in EH handling if EmSjLj is enabled".
Sep 14 2021, 1:00 PM · Restricted Project
aheejin committed rGe85ed4437307: [WebAssembly] Fix a typo in comments (authored by aheejin).
[WebAssembly] Fix a typo in comments
Sep 14 2021, 12:45 AM

Sep 13 2021

aheejin accepted D109689: [WebAssembly] NFC: Remove unused tblgen template args.

Thank you!

Sep 13 2021, 4:14 PM · Restricted Project
aheejin committed rGc55b6c593b32: [WebAssembly] Handle _setjmp and _longjmp in SjLj (authored by aheejin).
[WebAssembly] Handle _setjmp and _longjmp in SjLj
Sep 13 2021, 2:46 PM
aheejin closed D109669: [WebAssembly] Handle _setjmp and _longjmp in SjLj.
Sep 13 2021, 2:46 PM · Restricted Project
aheejin updated the diff for D109669: [WebAssembly] Handle _setjmp and _longjmp in SjLj.

Change to report_fatal_error

Sep 13 2021, 2:20 PM · Restricted Project
aheejin committed rGb7b4ebbcfa46: [WebAssembly] Rethrow longjmp in EH handling if EmSjLj is enabled (authored by aheejin).
[WebAssembly] Rethrow longjmp in EH handling if EmSjLj is enabled
Sep 13 2021, 2:16 PM
aheejin closed D109670: [WebAssembly] Rethrow longjmp in EH handling if EmSjLj is enabled.
Sep 13 2021, 2:16 PM · Restricted Project
aheejin added inline comments to D109669: [WebAssembly] Handle _setjmp and _longjmp in SjLj.
Sep 13 2021, 2:01 PM · Restricted Project
aheejin added inline comments to D109669: [WebAssembly] Handle _setjmp and _longjmp in SjLj.
Sep 13 2021, 2:00 PM · Restricted Project

Sep 12 2021

aheejin updated the summary of D109669: [WebAssembly] Handle _setjmp and _longjmp in SjLj.
Sep 12 2021, 7:19 PM · Restricted Project
aheejin requested review of D109670: [WebAssembly] Rethrow longjmp in EH handling if EmSjLj is enabled.
Sep 12 2021, 7:17 PM · Restricted Project
aheejin requested review of D109669: [WebAssembly] Handle _setjmp and _longjmp in SjLj.
Sep 12 2021, 7:16 PM · Restricted Project

Sep 10 2021

aheejin added a comment to rGfe6dbe7e9512: [WebAssembly][test] Fix lower-em-sjlj-indirect-setjmp.ll after D109375.

Sorry, and thank you for taking care of this!

Sep 10 2021, 3:39 PM
aheejin updated subscribers of D109375: [WebAssembly] Error out on indirect uses of setjmp.

Oh sorry, I forgot to change the test, and somehow missed the breakage notifications. And thank you @MaskRay for fixing this.

Sep 10 2021, 3:38 PM · Restricted Project

Sep 7 2021

aheejin committed rGa1d522939c64: [WebAssembly] Error out on indirect uses of setjmp (authored by aheejin).
[WebAssembly] Error out on indirect uses of setjmp
Sep 7 2021, 3:53 PM
aheejin closed D109375: [WebAssembly] Error out on indirect uses of setjmp.
Sep 7 2021, 3:53 PM · Restricted Project
aheejin updated the diff for D109375: [WebAssembly] Error out on indirect uses of setjmp.

Change the error message

Sep 7 2021, 3:50 PM · Restricted Project
aheejin requested review of D109375: [WebAssembly] Error out on indirect uses of setjmp.
Sep 7 2021, 10:15 AM · Restricted Project

Sep 2 2021

aheejin committed rG28780e59f615: [WebAssembly] Add Wasm SjLj support (authored by aheejin).
[WebAssembly] Add Wasm SjLj support
Sep 2 2021, 10:52 AM
aheejin closed D108960: [WebAssembly] Add Wasm SjLj support.
Sep 2 2021, 10:51 AM · Restricted Project

Aug 31 2021

aheejin added inline comments to D108960: [WebAssembly] Add Wasm SjLj support.
Aug 31 2021, 5:28 PM · Restricted Project
aheejin added inline comments to D108960: [WebAssembly] Add Wasm SjLj support.
Aug 31 2021, 3:48 PM · Restricted Project
aheejin updated the diff for D108960: [WebAssembly] Add Wasm SjLj support.

Address comments

Aug 31 2021, 3:47 PM · Restricted Project

Aug 30 2021

aheejin committed rG3419e85b15e3: [WebAssembly] Free setjmpTable before exiting calls in EmSjLj (authored by aheejin).
[WebAssembly] Free setjmpTable before exiting calls in EmSjLj
Aug 30 2021, 9:47 PM
aheejin closed D108955: [WebAssembly] Free setjmpTable before exiting calls in EmSjLj.
Aug 30 2021, 9:46 PM · Restricted Project
aheejin committed rGb8fc71b7aeed: [WebAssembly] Share rethrowing BBs in LowerEmscriptenEHSjLj (authored by aheejin).
[WebAssembly] Share rethrowing BBs in LowerEmscriptenEHSjLj
Aug 30 2021, 9:45 PM
aheejin closed D108945: [WebAssembly] Share rethrowing BBs in LowerEmscriptenEHSjLj.
Aug 30 2021, 9:44 PM · Restricted Project
aheejin updated the diff for D108960: [WebAssembly] Add Wasm SjLj support.

Remove debug print

Aug 30 2021, 5:24 PM · Restricted Project
aheejin requested review of D108960: [WebAssembly] Add Wasm SjLj support.
Aug 30 2021, 5:23 PM · Restricted Project