This is an archive of the discontinued LLVM Phabricator instance.

Differential D92555

mlir-nvidia: added -DBUILD_SHARED_LIBS=ON
ClosedPublic

Authored by kuhnel on Dec 3 2020, 1:27 AM.

Details

Reviewers
gkistanova
stellaraccident
herhut
ezhulenev
Commits
rZORG4ff41f5740f6: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON
Summary

added the flag as you requested

Diff Detail

Event Timeline

kuhnel created this revision.Dec 3 2020, 1:27 AM
Herald added a reviewer: gkistanova. · View Herald TranscriptDec 3 2020, 1:27 AM
Herald added a subscriber: rriddle. · View Herald Transcript
kuhnel requested review of this revision.Dec 3 2020, 1:27 AM
Herald added a subscriber: stephenneuendorffer. · View Herald TranscriptDec 3 2020, 1:27 AM
Harbormaster completed remote builds in B80926: Diff 309185.Dec 3 2020, 1:27 AM
kuhnel edited the summary of this revision. (Show Details)Dec 3 2020, 1:28 AM
kuhnel added reviewers: stellaraccident, herhut, ezhulenev.
herhut added inline comments.Dec 3 2020, 1:33 AM
buildbot/osuosl/master/config/builders.py
1092

I wonder whether we want this for all mlir builders in general. AFAIU the shared libs mode is the one that breaks more easily and also likely would show breakages for the non shared build. But I am far from an expert in the build setup with CMake.

stellaraccident accepted this revision.Dec 4 2020, 7:36 PM
stellaraccident added inline comments.
buildbot/osuosl/master/config/builders.py
1092

I'm game to try it on one and see.

This revision is now accepted and ready to land.Dec 4 2020, 7:36 PM
kuhnel updated this revision to Diff 309886.Dec 7 2020, 5:25 AM

enabled ccache

Harbormaster completed remote builds in B81281: Diff 309886.Dec 7 2020, 5:25 AM
Closed by commit rZORG4ff41f5740f6: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON (authored by kuhnel). · Explain WhyDec 7 2020, 5:26 AM
This revision was automatically updated to reflect the committed changes.
kuhnel added a commit: rZORG4ff41f5740f6: mlir-nvidia: added -DBUILD_SHARED_LIBS=ON.
kuhnel added a comment.Dec 7 2020, 5:29 AM

Alright, change landed. It will take a while until that is deployed.

In the process I also:

  • updated the buildbot to use the latest buildbot worker version
  • kicked out python2
  • enabled ccache
  • fixed the docker volumes

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
2 lines

Diff 309887

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 1,083 Lines • ▼ Show 20 Lines 'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
depends_on_projects=['llvm','mlir'], depends_on_projects=['llvm','mlir'],
extra_configure_args=[ extra_configure_args=[
'-DLLVM_BUILD_EXAMPLES=ON', '-DLLVM_BUILD_EXAMPLES=ON',
'-DLLVM_TARGETS_TO_BUILD=host;NVPTX', '-DLLVM_TARGETS_TO_BUILD=host;NVPTX',
'-DLLVM_ENABLE_PROJECTS=mlir', '-DLLVM_ENABLE_PROJECTS=mlir',
'-DMLIR_CUDA_RUNNER_ENABLED=1', '-DMLIR_CUDA_RUNNER_ENABLED=1',
'-DCMAKE_CUDA_COMPILER=/usr/local/cuda/bin/nvcc', '-DCMAKE_CUDA_COMPILER=/usr/local/cuda/bin/nvcc',
'-DMLIR_VULKAN_RUNNER_ENABLED=1', '-DMLIR_VULKAN_RUNNER_ENABLED=1',
'-DBUILD_SHARED_LIBS=ON',
herhutUnsubmitted
Not Done
ReplyInline Actions

I wonder whether we want this for all mlir builders in general. AFAIU the shared libs mode is the one that breaks more easily and also likely would show breakages for the non shared build. But I am far from an expert in the build setup with CMake.

herhut: I wonder whether we want this for all mlir builders in general. AFAIU the shared libs mode is…
stellaraccidentUnsubmitted
Not Done
ReplyInline Actions

I'm game to try it on one and see.

stellaraccident: I'm game to try it on one and see.
'-DLLVM_CCACHE_BUILD=ON',
], ],
env={ env={
'CC':'clang', 'CC':'clang',
'CXX': 'clang++', 'CXX': 'clang++',
'LD': 'lld', 'LD': 'lld',
})}, })},
{'name' : "mlir-windows", {'name' : "mlir-windows",
▲ Show 20 Lines • Show All 691 Lines • Show Last 20 Lines