added missing information on worker tab

thx for the review and feedback!

Yes, I was looking for feedback on this one as I wasn't happy with my design.

@sammccall here the first implementation we talked about yesterday. This works well on my testing poject that has a compile_commands.json. It does not work without one.

I'm not using the current deployment of the "windows10_vs2019" any more. So feel free to just modify that image and re-use the worker-config. That way you don't have to configure another deployment.

Not pursuing work on the windows buildbot any more

removed backwards compatibility, directly replacing all clean actions

Alright, change landed. It will take a while until that is deployed.

enabled ccache

I can't really reproduce the issue outside of buildbot. Deleting the files locally always works.

added empty last line

@kbobyrev Yes, the main.tf was a dirty working copy. I fixed that now.

removed stray edit to Dockerfile

addressed Sam's comments

fixed typos

Looking at the documentation, it seems like we also need to modify the cmake command line parameters: https://mlir.llvm.org/docs/Bindings/Python/

Teh build error looks like a connection issue to github, the script can't git fetch. We already have an issue to retry in such cases.

looks good to me

It also broke pre-merge testing for everyone: https://buildkite.com/llvm-project/llvm-master-build/builds/1071#7bfa9e1f-a2fe-47aa-8263-d2646ac0a0f5

@phosek sorry for the late reply, the builds on master are still green, so your changes are working on Windows as well.

Looking at the error, it seems like you have a 32-bit version of zlib installed and in your search path on a 64-bit version of Windows. I'm not quite sure how to handle that in CMake.

In D79219#2202048, @phosek wrote:

How can I test this change on pre-merge bots? I haven't seen any builds posted on this change before.

This patch broke the Windows compilation on buildbot and pre-merge testing. So I'll revert it to get pre-merge testing back online. Otherwise this will cause false-positives for pre-merge testing.

Nice. I'll give that a try tomorrow!