Page MenuHomePhabricator

[builtins][ARM] Check __ARM_FP instead of __VFP_FP__.
ClosedPublic

Authored by chaosdefinition on Dec 2 2020, 10:29 AM.

Details

Summary

This patch fixes builtins' CMakeLists.txt and their VFP tests to check the standard macro defined in the ACLE for VFP support. It also enables the tests to be built and run for single-precision-only targets while builtins were built with double-precision support.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2020, 10:29 AM
Herald added subscribers: Restricted Project, danielkiss, kristof.beyls, mgorny. · View Herald Transcript
chaosdefinition requested review of this revision.Dec 2 2020, 10:29 AM
compnerd accepted this revision.Dec 2 2020, 3:44 PM

Following the ACLE is definitely preferable. One thing to verify is if gcc does support this correctly as well. IIRC, it does support __ARM_FP properly and this should be safe, but please do verify that.

This revision is now accepted and ready to land.Dec 2 2020, 3:44 PM

Following the ACLE is definitely preferable. One thing to verify is if gcc does support this correctly as well. IIRC, it does support __ARM_FP properly and this should be safe, but please do verify that.

Thank you for reviewing! I checked the source code of gcc 5.1.0 (current minimum supported version to build LLVM) and it does support __ARM_FP.

This revision was landed with ongoing or failed builds.Dec 4 2020, 8:54 PM
This revision was automatically updated to reflect the committed changes.